From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A24E4C432C0 for ; Mon, 2 Dec 2019 11:41:25 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6A2082084F for ; Mon, 2 Dec 2019 11:41:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=greensocs.com header.i=@greensocs.com header.b="3qnXKbgn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6A2082084F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=greensocs.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34532 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibk4y-0007Et-Cl for qemu-devel@archiver.kernel.org; Mon, 02 Dec 2019 06:41:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44590) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibk2C-0006Kp-UF for qemu-devel@nongnu.org; Mon, 02 Dec 2019 06:38:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibk2B-0004Qz-3g for qemu-devel@nongnu.org; Mon, 02 Dec 2019 06:38:32 -0500 Received: from beetle.greensocs.com ([5.135.226.135]:51086) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibk27-0004PE-FE; Mon, 02 Dec 2019 06:38:28 -0500 Received: from [172.16.11.102] (crumble.bar.greensocs.com [172.16.11.102]) by beetle.greensocs.com (Postfix) with ESMTPSA id 82F8696EF0; Mon, 2 Dec 2019 11:38:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1575286701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kc4rOJaJAYsNyCWNjPbW9WW8Alz48HOG756F5zrMF0A=; b=3qnXKbgngrLys298wuE/JEhUm0wVSEaZ89fMLWV4Cb34aYF/4myeg4+4+XSagbqI3LafXk IhRQHAqQYfQfC3GP97klTyipM93omHoIP2Mq6fqQefl7XCghoBMbNGmrXnO7AmXlh6WwY8 qYu2RljaoW3ebaC1K2uAmgcxphur5uQ= Subject: Re: [PATCH v5 04/13] hw/core: add Resettable support to BusClass and DeviceClass To: Peter Maydell References: <20191018150630.31099-1-damien.hedde@greensocs.com> <20191018150630.31099-5-damien.hedde@greensocs.com> From: Damien Hedde Message-ID: <0befd5d7-dde3-9a41-6c60-1bc372f7fd28@greensocs.com> Date: Mon, 2 Dec 2019 12:38:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US-large Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=greensocs.com; s=mail; t=1575286701; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kc4rOJaJAYsNyCWNjPbW9WW8Alz48HOG756F5zrMF0A=; b=Wi4oqgutqhzNbKcEtiG4+L4eiPJCFAsdD4tm4s9izLCm1Ju2q41Lv7sAOnTuh8Pm6Rfo2F JCNDiq6dDsKhlrgZteDGN3NWCfjUzRJPhTfJZ05H77uYoC4VoUpW1E7Zi+R4j3PmtkR36A UIpLYX8uNZvuektGCsFrIPCoPyUoYls= ARC-Seal: i=1; s=mail; d=greensocs.com; t=1575286701; a=rsa-sha256; cv=none; b=a5+O9S4I9dxfA+Rnf7LutTBtMjnLdCtsP1Uiv3LCOVrc80pTRx1i+NPR4ofgLPefyvngrv H65jPJ2pdBO/uL5Rqr6K2HqSzL/j0eA0rFbJzkGgtOgHQG+pxcqx0ji9M47acfIZPTPrTv Gs7YpitOBwpWbXPIM6JRKXWl/gpu2Uo= ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=damien smtp.mailfrom=damien.hedde@greensocs.com X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 5.135.226.135 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P. Berrange" , Eduardo Habkost , qemu-s390x , Cornelia Huck , Mark Burton , QEMU Developers , Edgar Iglesias , qemu-arm , Paolo Bonzini , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 11/29/19 7:36 PM, Peter Maydell wrote: > On Fri, 18 Oct 2019 at 16:07, Damien Hedde wrote: >> >> This commit adds support of Resettable interface to buses and devices: >> + ResettableState structure is added in the Bus/Device state >> + Resettable methods are implemented. >> + device/bus_is_in_reset function defined >> >> This commit allows to transition the objects to the new >> multi-phase interface without changing the reset behavior at all. >> Object single reset method can be split into the 3 different phases >> but the 3 phases are still executed in a row for a given object. >> From the qdev/qbus reset api point of view, nothing is changed. >> qdev_reset_all() and qbus_reset_all() are not modified as well as >> device_legacy_reset(). >> >> Transition of an object must be done from mother class to daughter >> classes. > > The standard terminology here is "parent class" and "child class". > > I notice you've used mother/daughter in a bunch of other comments > in various patches -- could you change that to the more usual > terms, please? Yes. Sorry for that. > >> Care has been taken to allow the transition of a mother class >> without requiring the daughter classes to be transitioned at the same >> time. Note that SysBus and SysBusDevice class do not need any transition >> because they do not override the legacy reset method. >> >> Signed-off-by: Damien Hedde > > Otherwise > Reviewed-by: Peter Maydell > > thanks > -- PMM > -- Damien