From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26164C433DB for ; Wed, 24 Mar 2021 10:35:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D11961A01 for ; Wed, 24 Mar 2021 10:35:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D11961A01 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lP0rV-0001vz-CK for qemu-devel@archiver.kernel.org; Wed, 24 Mar 2021 06:35:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38564) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lP0oq-0000qF-0j for qemu-devel@nongnu.org; Wed, 24 Mar 2021 06:32:56 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:50438) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lP0og-0001g1-LC for qemu-devel@nongnu.org; Wed, 24 Mar 2021 06:32:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616581962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=li8GaBA80oDoyil4iY6CsTM32uPm9q8VTdoZoPLhUHs=; b=Js+TFgr+vF+lPAltRlVjEGZ0hDVaB1KvCyxrOpCveR7btVGWYtxEC8X0eoE1JJ13EXMMut QPtZA8kpwC4PPNvhwemS8KOdyJhRt7jY+jL+oIKHMmRoQ3MEa8GYe8yvKRhy+C+E/8EovS h1UuT7/JQzK+l09K3HvhAGOl4913vMM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-540-NnPVy6cvNtS1Ubj_ovYp2g-1; Wed, 24 Mar 2021 06:32:40 -0400 X-MC-Unique: NnPVy6cvNtS1Ubj_ovYp2g-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 73E1E57210; Wed, 24 Mar 2021 10:32:39 +0000 (UTC) Received: from thuth.remote.csb (ovpn-112-47.ams2.redhat.com [10.36.112.47]) by smtp.corp.redhat.com (Postfix) with ESMTP id 3E33754274; Wed, 24 Mar 2021 10:32:36 +0000 (UTC) Subject: Re: Crashes with qemu-system-ppc64 From: Thomas Huth To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Greg Kurz References: <1e4835a5-b785-5d0d-64d8-bb01afeea432@redhat.com> <20210324000056.349b6782@bahia.lan> <72f4839a-2a0d-f73b-bbde-8cad398dbbc9@amsat.org> Message-ID: <0bf1a651-207f-f620-e124-3f2085b492b1@redhat.com> Date: Wed, 24 Mar 2021 11:32:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=thuth@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=63.128.21.124; envelope-from=thuth@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Paolo Bonzini , "qemu-ppc@nongnu.org" , QEMU Developers , David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 24/03/2021 11.10, Thomas Huth wrote: > On 24/03/2021 00.35, Philippe Mathieu-Daudé wrote: > [...] >> Hmmm does this assert() matches your comment? >> >> -- >8 -- >> diff --git a/hw/core/qdev.c b/hw/core/qdev.c >> index cefc5eaa0a9..41cbee77d14 100644 >> --- a/hw/core/qdev.c >> +++ b/hw/core/qdev.c >> @@ -1130,6 +1130,8 @@ Object *qdev_get_machine(void) >>   { >>       static Object *dev; >> >> +    assert(phase_check(PHASE_MACHINE_CREATED)); >> + >>       if (dev == NULL) { >>           dev = container_get(object_get_root(), "/machine"); >>       } > > Sounds like a good idea, but I think it should be sufficient to put it into > the if-statement instead. Scratch that. QEMU quickly asserts with that statement, which makes sense if you consider that container_get also creates the container objects along the way. Thomas