From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DF49C433E9 for ; Wed, 3 Mar 2021 15:05:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B62A964E02 for ; Wed, 3 Mar 2021 15:05:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444085AbhCCPBQ (ORCPT ); Wed, 3 Mar 2021 10:01:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1843059AbhCCKZE (ORCPT ); Wed, 3 Mar 2021 05:25:04 -0500 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2062f.outbound.protection.outlook.com [IPv6:2a01:111:f400:7e88::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11D76C06121D for ; Wed, 3 Mar 2021 00:30:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4YUdLZtUmXO9WwFQSt9D62WdcKyRjooT6jGkHiB8rClxuaIpyh64zl44zmoFOLiRfxT2qB2j6/3jyJ+zukxFK6NTMyhwnOidNk84vDG/qPcGiQhgw0XLZIll91LQCR8iHni0xpYsoyhPUpiITmMAC5RvM7Fkp1DaAKd1SoTSr9H7vNRHj/xpmXLQRG2SAuzQb0usAQjIrXyiRLrw+F0N2VFdx5wvOaMT2GKHJTEcyeQybCBiHqRUTW4B5Mii7rQO3mvHckTzyW0Ct6FhHsRsb9V6dXtHX9Ap4QlBjLegoBQ/AH/5EcuOOKm3h88oYFL5zI+RuKmh+8CH0YoERBYRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h90L60eBns+8UXaMe11qcdZ4w5DYYE5GY+wsWGOZLx0=; b=JUfN6mjcnfBMYq//l5bBp0AJRlkMOnWa1JqTemFzLWp7w4fa1/iG9HYMzAO6XHFEx8qBVXKnKYUcy4n1jzGEHNin+XtSw3Xxf2mAYeegGAQABpP3+1WTjvKR3XvnQvAs/Sr2BUdNRbzEfcUOtLpqvEkNzBir6yq/Sjk8MSKEcy71x08SqxE0c1jbGlh5hFyD6quTQ/3Gb/SNpUe9tQJwwDY0PDe7XKAY8B2awNhDj56XqSid+8xK/EaD6rjnOVOZ4Evt+cNPB/REtB1nrrP4461fKNGob52ljvlxnnegjFtr3BwN2PU2AHgYhXKxGim//Ugt8uulQVd+3C4gdaJExg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h90L60eBns+8UXaMe11qcdZ4w5DYYE5GY+wsWGOZLx0=; b=Y5OPB6gvsLQAv8yjC3joGklSWZV46La68gYnKNYukfo2jUJ1LumYbjeYHt2AWXQHqkoqlUCVfxmM0yvIe56JuLLQYjSXzHI60sAFPWE0KbNSULrzdAo5pyCRPZ17mQVqJVNZ3PufLLHmhD8GO1djLYZK4GSA/pvUU1ORjTPwPLg= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=windriver.com; Received: from MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) by MWHPR11MB1680.namprd11.prod.outlook.com (2603:10b6:301:d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.22; Wed, 3 Mar 2021 08:30:35 +0000 Received: from MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::ad02:3dcf:d3e5:b27d]) by MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::ad02:3dcf:d3e5:b27d%10]) with mapi id 15.20.3890.030; Wed, 3 Mar 2021 08:30:35 +0000 Subject: Re: [PATCH 2/2] perf tools: Improve EOPNOTSUPP error reporting From: He Zhe To: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , mingo@redhat.com, acme@kernel.org References: <20210223082535.48730-1-zhe.he@windriver.com> <20210223082535.48730-2-zhe.he@windriver.com> Message-ID: <0bf98239-8956-9d9b-64e1-dee31bf18d93@windriver.com> Date: Wed, 3 Mar 2021 16:30:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210223082535.48730-2-zhe.he@windriver.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: BY3PR10CA0002.namprd10.prod.outlook.com (2603:10b6:a03:255::7) To MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [128.224.162.175] (60.247.85.82) by BY3PR10CA0002.namprd10.prod.outlook.com (2603:10b6:a03:255::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 08:30:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8089d87c-7a69-45af-4f9c-08d8de1e9dd9 X-MS-TrafficTypeDiagnostic: MWHPR11MB1680: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:639; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xkUvuEI+nDE2jUyVisMKKAP/ANHCSKnTXAte/QKlm6+o3mxFvIwoaR2ynBu6U62yy7x6/0jIu/oIubAzjiVLknGPjOx+CYooIuQdwOVd6I51BR8vCouFmLYvyFrUOXZaPE+tOgM9mZCu9zY4bn6BNjKcGXZEzSUZsU+ygg0ZGPaREu5e12+rMgP4lu5jqizSPg2dr/S1KUARhYVR9tGfuPFqsmeReR6j2ospMyH5Q7NgUf6lNU5/opww1j6YfClWexgfdXkY8HAbAuEAFIgix2QckbZW8O+bih7Y8M6CccGDPgIWq2BS/TEw1FFw0atKCXhG/svPzSe4a0rEU4SZLarNIQ9Wlo7TGeQ4PgaJjtHIW4IRms/o6MPDmz4FwYcJdJZqcAwMXvgDDOg/PSGG68AjISuK7BcB7XCxe5x3clg1HImPMwx81SOylB6bsz4XDsBe/K0apZ6NhsBSuLw7fEn/d+Q4VAHYX/lEU/GaXMdx6wLYc3atFd2GOTj45cQvWx8Cx4N5+y8rRfwn1+rlRPtkbH8yvBJ2+LqrxpCJWJ0olNj/TMzQ/I8aDZwOYHsLt8nCYvdT8XkzWT9Lp/xA/CzDJq/+2GRXhyF0XohOoO0f15KSKdTRJYuwu/TJJ1/YreJpftCnbxOE0giLBsy1pw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MWHPR1101MB2351.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(366004)(346002)(136003)(39830400003)(396003)(376002)(478600001)(66556008)(83380400001)(956004)(16526019)(66476007)(66946007)(52116002)(921005)(36756003)(53546011)(8676002)(6486002)(5660300002)(31686004)(31696002)(2906002)(6706004)(86362001)(7416002)(8936002)(316002)(6666004)(186003)(26005)(2616005)(16576012)(78286007)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TFRScWl6Q2FjWEJQSjZOUUtJVWV1c0dFWS9WSFdkODVsMG0wWW1VV2hSYkhr?= =?utf-8?B?Q21iRHprS1FEc1QzSWRySkxHTW16ZWpkcEtidlVCWmxONUNmbkNXaEEydHY2?= =?utf-8?B?Mk1UQW9sSnFmZXFhOGx2bE52SG9kT1RybzhDSng5enc2RTZmZklzZXc4Rk15?= =?utf-8?B?Vy9sOEpOWVpXMStjMGczZElPV2xERmVLWHkwazR5eHNIVk5ISm52QjNsN1lS?= =?utf-8?B?MmFlcHVta2U4czEwY2dXYlBKZnR3dE0yNUE0R3UwS3NBWE1VZTZDM0tmanFD?= =?utf-8?B?L0FGQUh1amJ2OStpUXZoNTBUc05sMFd0UkhxNzk1QmFLdExUdnhXM1FTRmtt?= =?utf-8?B?T3lFem5WY1JPWFp2akF3dmJPOTFod2NoOGpYNHdFRTRtNXEyU0gwSVdzMWR2?= =?utf-8?B?TVlVWVFUN3JRcmRoc0hpcGxtQ282eGRERC9keENWRGo0ZElqN3hBc3FGOXAr?= =?utf-8?B?RVlmRVI0dElpeDJlNkljWnEvRVhGR0JYRGs0YXAyamJLbEQrb25kc3J1RGJq?= =?utf-8?B?ZDdZbEZWSml3Skh0VzRVVW1EdExGRGhxRVRsWk1WWFBVOEFpMVZsZVcwekl5?= =?utf-8?B?dWRMTVRjem5PVW5uWWJ4Y3ZaSjVCNHpnWEp1dzlBZGNndmZEVXp0TFlhNWd3?= =?utf-8?B?VEw2MHRSZUZWR0R1RWdOUjFSQmJ3VkNhNUJZZ2RXaVlUbGVjYnA2WHRBZWp1?= =?utf-8?B?SWdody9XSExCM1NrSkRvOTNlUHdraCsyN3FGNkwwcUJtQncvRDJ4SW9YUisr?= =?utf-8?B?Q3hrS3hWQnlXSlIzL1BtSkJsVlFvZnFTT1NQYm1TTC9obFlxamRUb2RKZ3Bl?= =?utf-8?B?bzNVQVdjdU9LVnBOMmpYa3VRUjVpWGZqek9JVURLbG9Eb2x0dkRtY3c0OFMz?= =?utf-8?B?NDRDV2VodmZvTVk0QVowL2ZwcEZtVkYxVENHamFJeGFnVUVuL2FDa2JFc1Ix?= =?utf-8?B?M1BTV1RXY2pIakI2TDhjV2dvVzc1Smw0U2JLOHVIcEFlZ29zTEZsVDBndWJa?= =?utf-8?B?bkdCZk1GbWhYem9oWlYxT3FudjhEVE42WFUraUZQRW5sSnNYRXREcHZpcndM?= =?utf-8?B?TmprYm5RZ1hwSHVqOFNNdGltZU5JSjYzZmRWK2xvT2k4QW5UTFFXL2JJZEJq?= =?utf-8?B?cVpvQUZmZG1sSG1QdmpmZTBTTjFBb1pMcW5LRzBtY09NT0lNSW53Y05TZ1RX?= =?utf-8?B?Mi9ROVVEMnNlMzhXYjl2RWc4QVJIUkVEV3dUQTdSV3JlSjNmWk83amZlSUpS?= =?utf-8?B?RlBBaFRSRmhEV3FJUUhBbXd2T0ZGUjJYcU1HTXdHVXRDdEZGbVk4ZjBiUVI4?= =?utf-8?B?Y2pKQkRidzgzTFB5SW05ZW5GUGJVQTVFZ1pGQXFMWXlmbVdrSHJWejJlVUtR?= =?utf-8?B?TTY0d0FSUlR1c01ONmVUT0U5dlkvNHJKcnc2ZFhHS2ZKMEFHTUxxUW5vdmlo?= =?utf-8?B?M1JSWW9tcFNXcVI1TExNOVM1UlVCNGU1WFRSN3BCMUQ5Y0ZJcnZMcFBvcEVR?= =?utf-8?B?QzVSSUdqUDE3QkVzSENSb01nOGl6UjAwdFBMM3cwUGM2NVBMS2JkQ3ZBYlBn?= =?utf-8?B?WWs3ZE8yOHladGlqMDNGUDNGc2lPNy96L2lKcTZzaE1hSG91dzhQbk9uRG1R?= =?utf-8?B?dEkvTkozQjVoVUM5Nk9aNjVTNmV6VFNLSEh0cU94THpJalBRMFZ4cjdCclVI?= =?utf-8?B?NzZVMWlmQklWeE1pT0ZCY1NUV0d0aU1tKzVzSW5pRnpodHJka05RWUZQdXFW?= =?utf-8?Q?tlokfN9r4auPniZ6QxvLAW/eWkEyRXYUAySuxsD?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8089d87c-7a69-45af-4f9c-08d8de1e9dd9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2351.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:30:35.4483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /rpCczk8RPchqWWtE6iYDLWyo0H/5ZoPSz8N+wcQGeMUtZ+TRddP+XKy8ifhQ8qqK5qT7VkrnZpJYvbGIxNmDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1680 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oops, add some supporters from get_maintainer.pl Zhe On 2/23/21 4:25 PM, He Zhe wrote: > There may be multiple reasons for EOPNOTSUPP. Sometimes we cannot determine > which one it is. > > For example, when we set up uprobe with 32-bit perf and arm64 kernel on > some hardware that does not support sampling/overflow-interrupts, > $ perf probe -x /lib/libc.so.6 malloc > $ perf record -e probe_libc:malloc -a ls > > Before this patch: > probe_libc:malloc: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' > > After this patch: > probe_libc:malloc: PMU Hardware may not support sampling/overflow-interrupts. Try 'perf stat'. > Some 64-bit architectures may not support 32-bit instruction probing. > > Signed-off-by: He Zhe > --- > tools/perf/util/evsel.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 1bf76864c4f2..aa56511ddf60 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -2697,22 +2697,24 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target, > break; > case EOPNOTSUPP: > if (evsel->core.attr.aux_output) > - return scnprintf(msg, size, > - "%s: PMU Hardware doesn't support 'aux_output' feature", > + printed += scnprintf(msg + printed, size, > + "%s: PMU Hardware may not support 'aux_output' feature.\n", > evsel__name(evsel)); > if (evsel->core.attr.sample_period != 0) > - return scnprintf(msg, size, > - "%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'", > + printed += scnprintf(msg + printed, size, > + "%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'.\n", > evsel__name(evsel)); > if (evsel->core.attr.precise_ip) > - return scnprintf(msg, size, "%s", > - "\'precise\' request may not be supported. Try removing 'p' modifier."); > + printed += scnprintf(msg + printed, size, "%s", > + "\'precise\' request may not be supported. Try removing 'p' modifier.\n"); > #if defined(__i386__) || defined(__x86_64__) > if (evsel->core.attr.type == PERF_TYPE_HARDWARE) > - return scnprintf(msg, size, "%s", > + printed += scnprintf(msg + printed, size, "%s", > "No hardware sampling interrupt available.\n"); > #endif > - break; > + scnprintf(msg + printed, size, "%s", > + "Some 64-bit architectures may not support 32-bit instruction uprobe.\n"); > + return; > case EBUSY: > if (find_process("oprofiled")) > return scnprintf(msg, size, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68D12C433E0 for ; Wed, 3 Mar 2021 16:47:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E6CA64ECF for ; Wed, 3 Mar 2021 16:47:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E6CA64ECF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=windriver.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:References: To:From:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=M/ChdWNO91+bjROJIIK6LDhdi+12ZwJFHHPBgZrIXZM=; b=qWFFj+NrIuzqFoiVhwftQtD1I YZwP30IBRGaTo7JWXjWjq4M8h6tFO2x/9J+dIx93OO3BduElWEbF7tMHwXnQYLC6OXk6n9VojMTWk TOxGfrS57fm2YSk4srI000b04Fhn6oMLBlhmWomh4tpALFYSJG1Dnhia72PuJTe+qAt+fESN2a++I uMoHxd+BW2T28ySeajjo6jdE14noJEte4GZ9iABbStzCOnHSGl9JIfyOdMoZ3l22O532E1rUMwGu+ Dr1b+QJAomj+nkBSmY9mAPx+2Bgb2zP51wfK7anJJFmTMo5BDTJYC8x38KNaIB+gqRJgQZ5vqehdv 91wNVLh2A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHUbj-005eYn-Bc; Wed, 03 Mar 2021 16:44:19 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSqm-005EKJ-NT for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 14:51:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=MIME-Version:Content-Transfer-Encoding: Content-Type:In-Reply-To:Date:Message-ID:References:To:From:Subject:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=h90L60eBns+8UXaMe11qcdZ4w5DYYE5GY+wsWGOZLx0=; b=SwWU43SxL4ZanucRX6weniqM/j NVfyBTopr0lozspstojXU7M2BKWs615YtOsMZJlLrSEq+LMR74cVPzyKbLXZpH8hkHWV6ZXsXbUCH PSKAnHKHge9tWLu5GxbMD8pDV4MmkGWQSk6HGB8S/PeRq/2jgQQ/dUdMovue1pmUrbME7S+6ISRxA LdBez2LjeQnQD758MIUaQv0hLMMPinGiYXMwW+xUh2AhsAhR0OLaxDULwJqO7wbEltj49WYMimxqv zGW6fFMPAKM32ICzF6PGtt6HHOMek4fAhaYIUTYAUT8iMbxw25BvDZpXpU0bit6g3p2SfL2iVIaG7 7zehmEGw==; Received: from mail-dm6nam10on2051.outbound.protection.outlook.com ([40.107.93.51] helo=NAM10-DM6-obe.outbound.protection.outlook.com) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHMuX-001q6S-NI for linux-arm-kernel@lists.infradead.org; Wed, 03 Mar 2021 08:31:14 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=N4YUdLZtUmXO9WwFQSt9D62WdcKyRjooT6jGkHiB8rClxuaIpyh64zl44zmoFOLiRfxT2qB2j6/3jyJ+zukxFK6NTMyhwnOidNk84vDG/qPcGiQhgw0XLZIll91LQCR8iHni0xpYsoyhPUpiITmMAC5RvM7Fkp1DaAKd1SoTSr9H7vNRHj/xpmXLQRG2SAuzQb0usAQjIrXyiRLrw+F0N2VFdx5wvOaMT2GKHJTEcyeQybCBiHqRUTW4B5Mii7rQO3mvHckTzyW0Ct6FhHsRsb9V6dXtHX9Ap4QlBjLegoBQ/AH/5EcuOOKm3h88oYFL5zI+RuKmh+8CH0YoERBYRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h90L60eBns+8UXaMe11qcdZ4w5DYYE5GY+wsWGOZLx0=; b=JUfN6mjcnfBMYq//l5bBp0AJRlkMOnWa1JqTemFzLWp7w4fa1/iG9HYMzAO6XHFEx8qBVXKnKYUcy4n1jzGEHNin+XtSw3Xxf2mAYeegGAQABpP3+1WTjvKR3XvnQvAs/Sr2BUdNRbzEfcUOtLpqvEkNzBir6yq/Sjk8MSKEcy71x08SqxE0c1jbGlh5hFyD6quTQ/3Gb/SNpUe9tQJwwDY0PDe7XKAY8B2awNhDj56XqSid+8xK/EaD6rjnOVOZ4Evt+cNPB/REtB1nrrP4461fKNGob52ljvlxnnegjFtr3BwN2PU2AHgYhXKxGim//Ugt8uulQVd+3C4gdaJExg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=windriver.com; dmarc=pass action=none header.from=windriver.com; dkim=pass header.d=windriver.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=windriversystems.onmicrosoft.com; s=selector2-windriversystems-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=h90L60eBns+8UXaMe11qcdZ4w5DYYE5GY+wsWGOZLx0=; b=Y5OPB6gvsLQAv8yjC3joGklSWZV46La68gYnKNYukfo2jUJ1LumYbjeYHt2AWXQHqkoqlUCVfxmM0yvIe56JuLLQYjSXzHI60sAFPWE0KbNSULrzdAo5pyCRPZ17mQVqJVNZ3PufLLHmhD8GO1djLYZK4GSA/pvUU1ORjTPwPLg= Authentication-Results: kernel.org; dkim=none (message not signed) header.d=none;kernel.org; dmarc=none action=none header.from=windriver.com; Received: from MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) by MWHPR11MB1680.namprd11.prod.outlook.com (2603:10b6:301:d::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3890.22; Wed, 3 Mar 2021 08:30:35 +0000 Received: from MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::ad02:3dcf:d3e5:b27d]) by MWHPR1101MB2351.namprd11.prod.outlook.com ([fe80::ad02:3dcf:d3e5:b27d%10]) with mapi id 15.20.3890.030; Wed, 3 Mar 2021 08:30:35 +0000 Subject: Re: [PATCH 2/2] perf tools: Improve EOPNOTSUPP error reporting From: He Zhe To: catalin.marinas@arm.com, will@kernel.org, mark.rutland@arm.com, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peter Zijlstra , mingo@redhat.com, acme@kernel.org References: <20210223082535.48730-1-zhe.he@windriver.com> <20210223082535.48730-2-zhe.he@windriver.com> Message-ID: <0bf98239-8956-9d9b-64e1-dee31bf18d93@windriver.com> Date: Wed, 3 Mar 2021 16:30:25 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 In-Reply-To: <20210223082535.48730-2-zhe.he@windriver.com> Content-Language: en-US X-Originating-IP: [60.247.85.82] X-ClientProxiedBy: BY3PR10CA0002.namprd10.prod.outlook.com (2603:10b6:a03:255::7) To MWHPR1101MB2351.namprd11.prod.outlook.com (2603:10b6:300:74::18) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [128.224.162.175] (60.247.85.82) by BY3PR10CA0002.namprd10.prod.outlook.com (2603:10b6:a03:255::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3912.17 via Frontend Transport; Wed, 3 Mar 2021 08:30:32 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8089d87c-7a69-45af-4f9c-08d8de1e9dd9 X-MS-TrafficTypeDiagnostic: MWHPR11MB1680: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:639; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: xkUvuEI+nDE2jUyVisMKKAP/ANHCSKnTXAte/QKlm6+o3mxFvIwoaR2ynBu6U62yy7x6/0jIu/oIubAzjiVLknGPjOx+CYooIuQdwOVd6I51BR8vCouFmLYvyFrUOXZaPE+tOgM9mZCu9zY4bn6BNjKcGXZEzSUZsU+ygg0ZGPaREu5e12+rMgP4lu5jqizSPg2dr/S1KUARhYVR9tGfuPFqsmeReR6j2ospMyH5Q7NgUf6lNU5/opww1j6YfClWexgfdXkY8HAbAuEAFIgix2QckbZW8O+bih7Y8M6CccGDPgIWq2BS/TEw1FFw0atKCXhG/svPzSe4a0rEU4SZLarNIQ9Wlo7TGeQ4PgaJjtHIW4IRms/o6MPDmz4FwYcJdJZqcAwMXvgDDOg/PSGG68AjISuK7BcB7XCxe5x3clg1HImPMwx81SOylB6bsz4XDsBe/K0apZ6NhsBSuLw7fEn/d+Q4VAHYX/lEU/GaXMdx6wLYc3atFd2GOTj45cQvWx8Cx4N5+y8rRfwn1+rlRPtkbH8yvBJ2+LqrxpCJWJ0olNj/TMzQ/I8aDZwOYHsLt8nCYvdT8XkzWT9Lp/xA/CzDJq/+2GRXhyF0XohOoO0f15KSKdTRJYuwu/TJJ1/YreJpftCnbxOE0giLBsy1pw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MWHPR1101MB2351.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(346002)(136003)(39830400003)(396003)(376002)(478600001)(66556008)(83380400001)(956004)(16526019)(66476007)(66946007)(52116002)(921005)(36756003)(53546011)(8676002)(6486002)(5660300002)(31686004)(31696002)(2906002)(6706004)(86362001)(7416002)(8936002)(316002)(6666004)(186003)(26005)(2616005)(16576012)(78286007)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?TFRScWl6Q2FjWEJQSjZOUUtJVWV1c0dFWS9WSFdkODVsMG0wWW1VV2hSYkhr?= =?utf-8?B?Q21iRHprS1FEc1QzSWRySkxHTW16ZWpkcEtidlVCWmxONUNmbkNXaEEydHY2?= =?utf-8?B?Mk1UQW9sSnFmZXFhOGx2bE52SG9kT1RybzhDSng5enc2RTZmZklzZXc4Rk15?= =?utf-8?B?Vy9sOEpOWVpXMStjMGczZElPV2xERmVLWHkwazR5eHNIVk5ISm52QjNsN1lS?= =?utf-8?B?MmFlcHVta2U4czEwY2dXYlBKZnR3dE0yNUE0R3UwS3NBWE1VZTZDM0tmanFD?= =?utf-8?B?L0FGQUh1amJ2OStpUXZoNTBUc05sMFd0UkhxNzk1QmFLdExUdnhXM1FTRmtt?= =?utf-8?B?T3lFem5WY1JPWFp2akF3dmJPOTFod2NoOGpYNHdFRTRtNXEyU0gwSVdzMWR2?= =?utf-8?B?TVlVWVFUN3JRcmRoc0hpcGxtQ282eGRERC9keENWRGo0ZElqN3hBc3FGOXAr?= =?utf-8?B?RVlmRVI0dElpeDJlNkljWnEvRVhGR0JYRGs0YXAyamJLbEQrb25kc3J1RGJq?= =?utf-8?B?ZDdZbEZWSml3Skh0VzRVVW1EdExGRGhxRVRsWk1WWFBVOEFpMVZsZVcwekl5?= =?utf-8?B?dWRMTVRjem5PVW5uWWJ4Y3ZaSjVCNHpnWEp1dzlBZGNndmZEVXp0TFlhNWd3?= =?utf-8?B?VEw2MHRSZUZWR0R1RWdOUjFSQmJ3VkNhNUJZZ2RXaVlUbGVjYnA2WHRBZWp1?= =?utf-8?B?SWdody9XSExCM1NrSkRvOTNlUHdraCsyN3FGNkwwcUJtQncvRDJ4SW9YUisr?= =?utf-8?B?Q3hrS3hWQnlXSlIzL1BtSkJsVlFvZnFTT1NQYm1TTC9obFlxamRUb2RKZ3Bl?= =?utf-8?B?bzNVQVdjdU9LVnBOMmpYa3VRUjVpWGZqek9JVURLbG9Eb2x0dkRtY3c0OFMz?= =?utf-8?B?NDRDV2VodmZvTVk0QVowL2ZwcEZtVkYxVENHamFJeGFnVUVuL2FDa2JFc1Ix?= =?utf-8?B?M1BTV1RXY2pIakI2TDhjV2dvVzc1Smw0U2JLOHVIcEFlZ29zTEZsVDBndWJa?= =?utf-8?B?bkdCZk1GbWhYem9oWlYxT3FudjhEVE42WFUraUZQRW5sSnNYRXREcHZpcndM?= =?utf-8?B?TmprYm5RZ1hwSHVqOFNNdGltZU5JSjYzZmRWK2xvT2k4QW5UTFFXL2JJZEJq?= =?utf-8?B?cVpvQUZmZG1sSG1QdmpmZTBTTjFBb1pMcW5LRzBtY09NT0lNSW53Y05TZ1RX?= =?utf-8?B?Mi9ROVVEMnNlMzhXYjl2RWc4QVJIUkVEV3dUQTdSV3JlSjNmWk83amZlSUpS?= =?utf-8?B?RlBBaFRSRmhEV3FJUUhBbXd2T0ZGUjJYcU1HTXdHVXRDdEZGbVk4ZjBiUVI4?= =?utf-8?B?Y2pKQkRidzgzTFB5SW05ZW5GUGJVQTVFZ1pGQXFMWXlmbVdrSHJWejJlVUtR?= =?utf-8?B?TTY0d0FSUlR1c01ONmVUT0U5dlkvNHJKcnc2ZFhHS2ZKMEFHTUxxUW5vdmlo?= =?utf-8?B?M1JSWW9tcFNXcVI1TExNOVM1UlVCNGU1WFRSN3BCMUQ5Y0ZJcnZMcFBvcEVR?= =?utf-8?B?QzVSSUdqUDE3QkVzSENSb01nOGl6UjAwdFBMM3cwUGM2NVBMS2JkQ3ZBYlBn?= =?utf-8?B?WWs3ZE8yOHladGlqMDNGUDNGc2lPNy96L2lKcTZzaE1hSG91dzhQbk9uRG1R?= =?utf-8?B?dEkvTkozQjVoVUM5Nk9aNjVTNmV6VFNLSEh0cU94THpJalBRMFZ4cjdCclVI?= =?utf-8?B?NzZVMWlmQklWeE1pT0ZCY1NUV0d0aU1tKzVzSW5pRnpodHJka05RWUZQdXFW?= =?utf-8?Q?tlokfN9r4auPniZ6QxvLAW/eWkEyRXYUAySuxsD?= X-OriginatorOrg: windriver.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8089d87c-7a69-45af-4f9c-08d8de1e9dd9 X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2351.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2021 08:30:35.4483 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: /rpCczk8RPchqWWtE6iYDLWyo0H/5ZoPSz8N+wcQGeMUtZ+TRddP+XKy8ifhQ8qqK5qT7VkrnZpJYvbGIxNmDw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR11MB1680 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210303_083114_764552_C68379D7 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Oops, add some supporters from get_maintainer.pl Zhe On 2/23/21 4:25 PM, He Zhe wrote: > There may be multiple reasons for EOPNOTSUPP. Sometimes we cannot determine > which one it is. > > For example, when we set up uprobe with 32-bit perf and arm64 kernel on > some hardware that does not support sampling/overflow-interrupts, > $ perf probe -x /lib/libc.so.6 malloc > $ perf record -e probe_libc:malloc -a ls > > Before this patch: > probe_libc:malloc: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat' > > After this patch: > probe_libc:malloc: PMU Hardware may not support sampling/overflow-interrupts. Try 'perf stat'. > Some 64-bit architectures may not support 32-bit instruction probing. > > Signed-off-by: He Zhe > --- > tools/perf/util/evsel.c | 18 ++++++++++-------- > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c > index 1bf76864c4f2..aa56511ddf60 100644 > --- a/tools/perf/util/evsel.c > +++ b/tools/perf/util/evsel.c > @@ -2697,22 +2697,24 @@ int evsel__open_strerror(struct evsel *evsel, struct target *target, > break; > case EOPNOTSUPP: > if (evsel->core.attr.aux_output) > - return scnprintf(msg, size, > - "%s: PMU Hardware doesn't support 'aux_output' feature", > + printed += scnprintf(msg + printed, size, > + "%s: PMU Hardware may not support 'aux_output' feature.\n", > evsel__name(evsel)); > if (evsel->core.attr.sample_period != 0) > - return scnprintf(msg, size, > - "%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'", > + printed += scnprintf(msg + printed, size, > + "%s: PMU Hardware doesn't support sampling/overflow-interrupts. Try 'perf stat'.\n", > evsel__name(evsel)); > if (evsel->core.attr.precise_ip) > - return scnprintf(msg, size, "%s", > - "\'precise\' request may not be supported. Try removing 'p' modifier."); > + printed += scnprintf(msg + printed, size, "%s", > + "\'precise\' request may not be supported. Try removing 'p' modifier.\n"); > #if defined(__i386__) || defined(__x86_64__) > if (evsel->core.attr.type == PERF_TYPE_HARDWARE) > - return scnprintf(msg, size, "%s", > + printed += scnprintf(msg + printed, size, "%s", > "No hardware sampling interrupt available.\n"); > #endif > - break; > + scnprintf(msg + printed, size, "%s", > + "Some 64-bit architectures may not support 32-bit instruction uprobe.\n"); > + return; > case EBUSY: > if (find_process("oprofiled")) > return scnprintf(msg, size, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel