From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH 3/4] iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs Date: Sun, 15 Jan 2017 13:26:52 +0100 Message-ID: <0bfa97d1-2ee3-9dd9-dce3-593e93771f03@metafoo.de> References: <20170111174334.24343-1-martin.blumenstingl@googlemail.com> <20170111174334.24343-4-martin.blumenstingl@googlemail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170111174334.24343-4-martin.blumenstingl-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Martin Blumenstingl , jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 01/11/2017 06:43 PM, Martin Blumenstingl wrote: > + indio_dev->name = dev_name(&pdev->dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. meson-gxbb-saradc or meson-gxl-saradc in this case. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from www381.your-server.de ([78.46.137.84]:37657 "EHLO www381.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750860AbdAOM1D (ORCPT ); Sun, 15 Jan 2017 07:27:03 -0500 Subject: Re: [PATCH 3/4] iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs To: Martin Blumenstingl , jic23@kernel.org, knaack.h@gmx.de, pmeerw@pmeerw.net, robh+dt@kernel.org, mark.rutland@arm.com, khilman@baylibre.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org References: <20170111174334.24343-1-martin.blumenstingl@googlemail.com> <20170111174334.24343-4-martin.blumenstingl@googlemail.com> Cc: carlo@caione.org, catalin.marinas@arm.com, will.deacon@arm.com, mturquette@baylibre.com, sboyd@codeaurora.org, narmstrong@baylibre.com, linux-arm-kernel@lists.infradead.org From: Lars-Peter Clausen Message-ID: <0bfa97d1-2ee3-9dd9-dce3-593e93771f03@metafoo.de> Date: Sun, 15 Jan 2017 13:26:52 +0100 MIME-Version: 1.0 In-Reply-To: <20170111174334.24343-4-martin.blumenstingl@googlemail.com> Content-Type: text/plain; charset=windows-1252 Sender: linux-clk-owner@vger.kernel.org List-ID: On 01/11/2017 06:43 PM, Martin Blumenstingl wrote: > + indio_dev->name = dev_name(&pdev->dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. meson-gxbb-saradc or meson-gxl-saradc in this case. From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Sun, 15 Jan 2017 13:26:52 +0100 Subject: [PATCH 3/4] iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs In-Reply-To: <20170111174334.24343-4-martin.blumenstingl@googlemail.com> References: <20170111174334.24343-1-martin.blumenstingl@googlemail.com> <20170111174334.24343-4-martin.blumenstingl@googlemail.com> Message-ID: <0bfa97d1-2ee3-9dd9-dce3-593e93771f03@metafoo.de> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 01/11/2017 06:43 PM, Martin Blumenstingl wrote: > + indio_dev->name = dev_name(&pdev->dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. meson-gxbb-saradc or meson-gxl-saradc in this case. From mboxrd@z Thu Jan 1 00:00:00 1970 From: lars@metafoo.de (Lars-Peter Clausen) Date: Sun, 15 Jan 2017 13:26:52 +0100 Subject: [PATCH 3/4] iio: adc: add a driver for the SAR ADC found in Amlogic Meson SoCs In-Reply-To: <20170111174334.24343-4-martin.blumenstingl@googlemail.com> References: <20170111174334.24343-1-martin.blumenstingl@googlemail.com> <20170111174334.24343-4-martin.blumenstingl@googlemail.com> Message-ID: <0bfa97d1-2ee3-9dd9-dce3-593e93771f03@metafoo.de> To: linus-amlogic@lists.infradead.org List-Id: linus-amlogic.lists.infradead.org On 01/11/2017 06:43 PM, Martin Blumenstingl wrote: > + indio_dev->name = dev_name(&pdev->dev); The name is supposed to be the type of the device, e.g. part name, not the name of parent device instance. E.g. meson-gxbb-saradc or meson-gxl-saradc in this case.