From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764025AbdJQUFC (ORCPT ); Tue, 17 Oct 2017 16:05:02 -0400 Received: from mout.web.de ([212.227.15.4]:52722 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764008AbdJQUFA (ORCPT ); Tue, 17 Oct 2017 16:05:00 -0400 Subject: Re: char/tpm: Improve a size determination in nine functions To: Mimi Zohar , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jarkko Sakkinen , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <1508268493.4513.39.camel@linux.vnet.ibm.com> From: SF Markus Elfring Message-ID: <0c0adf54-ecaa-0a46-d4d0-1cd9718de913@users.sourceforge.net> Date: Tue, 17 Oct 2017 22:04:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <1508268493.4513.39.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:eo3nSIFa9JZhiyKvzB7oAUkbjcU6nkypscc6QSlibQnsLnvyHkm 6sXXSmEy+xDVOAu0U+VmjrAQF5txUQUlhBnSfN0YntYT9BTFt8F1BIMCU2Oty8JbAxQozEl i99zuUlZx4iB+Xt2xFi8sgTfVPCd+IBVNa9S8jfYc+dqhs4sWd1unHADpFsQf0G3faAAk48 3yBRCfKELGORsK2gp7zEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:EGtjrt1gn6w=:8zKIoT1riAEIumC6Y0zDxy vb0s8fT90uOOuMNIXPpi5rGstgVPqYQig0ZLYFp5we7+anX3MU2Ftfw8TG9JjmQEfiIWfYlWO b6qASWiX6v5koGo2/u8Oqfeq31F0xtqnyWzwONb1k2HIskPfFkJZYjuBe9qXuOyOxkQkDSafK E3mfTgYj4NNb5CKh5kiIVqZ5taad6UBGyUAV4tNrDL0IYfZSYCl2+v6BftI/n2/99EMcNqO9/ mMQhY7SOsKiwAzCi1f+Xnl0XwC4CvrZz+vws45pV/OawpEy97zmB6C5FWmgPZDaFeoa5QPtTv 4eq8+0H55MJNU7uHMNZK5MhlOZYYZPVx8m9wl/X1nY5g/RQp9gkyeKhnW9qja0uXB6JXlCW1q 51v4KRdD9vLy27UmsAU3Sl9OBWRBNTGq+jtDkeHqBHrX3GeaWxilvijcCtqUlir1hn0eGvw/4 siHP8zNteOFL5ftdeBlAwWytPx4QClGTSLFrWBMtssztgeryrELdJjMJVLYls9uB0T2ao+y0R aUudYuqVSktvC4w3Zp+jK/fsxl5UtWa8OybX3q6O9GzIjwBSW63KLcCaPzavyufYfw81ZJtmc JRjuD8Zf640V6Kvj0z9OwAEiL4znlbCqgQK4Z3mf3vFT0A1Ousdlc9f50n4aI5tFw71N2BHto N8yzhNAYB+I8XtsFGcg/qhxUMpskt6dUFAGPaSphUsE2/YLV96pL0MX1oflpAt/T96HzDPfCg xmxlpt+D5KJbsy6sfqjGSZLjfbysiPudUWI8TqmrgQd0IECPLbV1yujsc3Ez5YWjL+BZOzR06 vCJQ+IBZFGKc8uNLfdTtrvh3OpX03gON5hvrs3newdC3SNn0gg= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Do you find my wording “This issue was detected by using the >> Coccinelle software.” insufficient? > > The question is not whether it is insufficient, but whether it is appropriate. I am curious on how our corresponding discussion will evolve further. > Detecting Coccinelle issues is one step.  The next step is deciding > what to do with them. Will the clarification achieve any more useful results? > Up to now, these messages have been sent out as informational, not as patches. I sent some update suggestions as patches also in this series (as usual). > Before sending patches to change existing code, address the "problem" > so that it doesn't continue to happen. It might be very challenging to achieve such a goal. > Only afterwards is it appropriate to discuss what to do with existing code. I would prefer to get corresponding improvements in both areas in parallel (if it is generally possible). Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Tue, 17 Oct 2017 20:04:30 +0000 Subject: Re: char/tpm: Improve a size determination in nine functions Message-Id: <0c0adf54-ecaa-0a46-d4d0-1cd9718de913@users.sourceforge.net> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <1508268493.4513.39.camel@linux.vnet.ibm.com> In-Reply-To: <1508268493.4513.39.camel@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Mimi Zohar , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jarkko Sakkinen , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger >> Do you find my wording “This issue was detected by using the >> Coccinelle software.” insufficient? > > The question is not whether it is insufficient, but whether it is appropriate. I am curious on how our corresponding discussion will evolve further. > Detecting Coccinelle issues is one step.  The next step is deciding > what to do with them. Will the clarification achieve any more useful results? > Up to now, these messages have been sent out as informational, not as patches. I sent some update suggestions as patches also in this series (as usual). > Before sending patches to change existing code, address the "problem" > so that it doesn't continue to happen. It might be very challenging to achieve such a goal. > Only afterwards is it appropriate to discuss what to do with existing code. I would prefer to get corresponding improvements in both areas in parallel (if it is generally possible). Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de ([212.227.15.4]:52722 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764008AbdJQUFA (ORCPT ); Tue, 17 Oct 2017 16:05:00 -0400 Subject: Re: char/tpm: Improve a size determination in nine functions To: Mimi Zohar , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jarkko Sakkinen , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <1508268493.4513.39.camel@linux.vnet.ibm.com> From: SF Markus Elfring Message-ID: <0c0adf54-ecaa-0a46-d4d0-1cd9718de913@users.sourceforge.net> Date: Tue, 17 Oct 2017 22:04:30 +0200 MIME-Version: 1.0 In-Reply-To: <1508268493.4513.39.camel@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Sender: linux-integrity-owner@vger.kernel.org List-ID: >> Do you find my wording "This issue was detected by using the >> Coccinelle software." insufficient? > > The question is not whether it is insufficient, but whether it is appropriate. I am curious on how our corresponding discussion will evolve further. > Detecting Coccinelle issues is one step. The next step is deciding > what to do with them. Will the clarification achieve any more useful results? > Up to now, these messages have been sent out as informational, not as patches. I sent some update suggestions as patches also in this series (as usual). > Before sending patches to change existing code, address the "problem" > so that it doesn't continue to happen. It might be very challenging to achieve such a goal. > Only afterwards is it appropriate to discuss what to do with existing code. I would prefer to get corresponding improvements in both areas in parallel (if it is generally possible). Regards, Markus