From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-block@nongnu.org
Cc: mreitz@redhat.com, berto@igalia.com, qemu-devel@nongnu.org
Subject: Re: [PATCH v5 3/6] block: Acquire AioContexts during bdrv_reopen_multiple()
Date: Tue, 6 Jul 2021 18:17:23 +0300 [thread overview]
Message-ID: <0c1968ea-5a10-25c9-93ed-c0f0765c80f2@virtuozzo.com> (raw)
In-Reply-To: <20210706112340.223334-4-kwolf@redhat.com>
06.07.2021 14:23, Kevin Wolf wrote:
> As the BlockReopenQueue can contain nodes in multiple AioContexts, only
> one of which may be locked when AIO_WAIT_WHILE() can be called, we can't
> let the caller lock the right contexts. Instead, individually lock the
> AioContext of a single node when iterating the queue.
>
> Reintroduce bdrv_reopen() as a wrapper for reopening a single node that
> drains the node and temporarily drops the AioContext lock for
> bdrv_reopen_multiple().
>
> Signed-off-by: Kevin Wolf<kwolf@redhat.com>
I don't have the whole picture in mind. But looks clear:
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
--
Best regards,
Vladimir
next prev parent reply other threads:[~2021-07-06 15:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-06 11:23 [PATCH v5 0/6] Make blockdev-reopen stable Kevin Wolf
2021-07-06 11:23 ` [PATCH v5 1/6] qcow2: Fix dangling pointer after reopen for 'file' Kevin Wolf
2021-07-06 13:12 ` Vladimir Sementsov-Ogievskiy
2021-07-06 13:43 ` Kevin Wolf
2021-07-06 11:23 ` [PATCH v5 2/6] block: Add bdrv_reopen_queue_free() Kevin Wolf
2021-07-06 13:18 ` Vladimir Sementsov-Ogievskiy
2021-07-06 11:23 ` [PATCH v5 3/6] block: Acquire AioContexts during bdrv_reopen_multiple() Kevin Wolf
2021-07-06 15:17 ` Vladimir Sementsov-Ogievskiy [this message]
2021-07-06 11:23 ` [PATCH v5 4/6] block: Support multiple reopening with x-blockdev-reopen Kevin Wolf
2021-07-06 15:45 ` Vladimir Sementsov-Ogievskiy
2021-07-06 11:23 ` [PATCH v5 5/6] iotests: Test reopening multiple devices at the same time Kevin Wolf
2021-07-06 15:50 ` Vladimir Sementsov-Ogievskiy
2021-07-06 11:23 ` [PATCH v5 6/6] block: Make blockdev-reopen stable API Kevin Wolf
2021-07-06 15:51 ` Vladimir Sementsov-Ogievskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1968ea-5a10-25c9-93ed-c0f0765c80f2@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.