From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 1/3] x86emul: switch away from temporary 32-bit register names
Date: Tue, 7 Mar 2017 16:52:27 +0000 [thread overview]
Message-ID: <0c26902c-a242-4311-6fd3-80841a948a89@citrix.com> (raw)
In-Reply-To: <58BEF0E80200007800140ED7@prv-mh.provo.novell.com>
On 07/03/17 16:42, Jan Beulich wrote:
> @@ -3266,36 +3266,36 @@ x86_emulate(
> case 0x27: /* daa */
> case 0x2f: /* das */ {
> uint8_t al = _regs.al;
> - unsigned int eflags = _regs._eflags;
> + unsigned int eflags = _regs.eflags;
>
> - _regs._eflags &= ~(X86_EFLAGS_CF | X86_EFLAGS_AF | X86_EFLAGS_SF |
> + _regs.eflags &= ~(X86_EFLAGS_CF | X86_EFLAGS_AF | X86_EFLAGS_SF |
> X86_EFLAGS_ZF | X86_EFLAGS_PF);
This line needs indenting accordingly.
> @@ -6395,20 +6395,20 @@ x86_emulate(
> ((dst.orig_val << shift) |
> ((src.val >> (width - shift)) & ((1ull << shift) - 1))));
> dst.val = truncate_word(dst.val, dst.bytes);
> - _regs._eflags &= ~(X86_EFLAGS_OF | X86_EFLAGS_SF | X86_EFLAGS_ZF |
> + _regs.eflags &= ~(X86_EFLAGS_OF | X86_EFLAGS_SF | X86_EFLAGS_ZF |
> X86_EFLAGS_PF | X86_EFLAGS_CF);
And here.
Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-07 16:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-07 16:39 [PATCH 0/3] x86: finish 32-bit register renaming Jan Beulich
2017-03-07 16:42 ` [PATCH 1/3] x86emul: switch away from temporary 32-bit register names Jan Beulich
2017-03-07 16:52 ` Andrew Cooper [this message]
2017-03-07 16:42 ` [PATCH 2/3] x86/hypercall: " Jan Beulich
2017-03-07 16:53 ` Andrew Cooper
2017-03-07 16:43 ` [PATCH 3/3] x86: drop underscore prefixed " Jan Beulich
2017-03-07 16:53 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c26902c-a242-4311-6fd3-80841a948a89@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.