From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E38EECAAD8 for ; Wed, 21 Sep 2022 09:49:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229718AbiIUJtS (ORCPT ); Wed, 21 Sep 2022 05:49:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59168 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbiIUJsz (ORCPT ); Wed, 21 Sep 2022 05:48:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F65397D6B; Wed, 21 Sep 2022 02:46:39 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C7FAC660202C; Wed, 21 Sep 2022 10:45:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663753544; bh=9ji1SJvfdXYebHWHKsGj8bj+sMSEq74pzAp6Nbn4WWM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CQ13WHYIS9frO3QW4TLXbP+zllrNOekCNYslUt32DxeL8LgiWbziNNxXOHW40TnBO XQ8sMohQ/jRnrtvh234ZD1fLlLA+2pQ/3LI+46OCU4017X0ZpySHtGur4hjvy8+8Vk SUJbnwzxy4+xYsuMbFm6Z2nktJsxF3/RM2/0Qhzee7rGywwOeTlLDdPapCez7P0K8s cik6AH29MKZTU8r/gXBYI1/a+14po/EwWVQDGdIWR1Mh3EBODL19MxJz9YNZlF9Hvb PyTpUr4CaziU6zYnWI4ErS5dsPYzyWhwRMQ6gMmaGH7dW5Vra8kpWAoIJPlZGhd4xG JIz+KykszkSsw== Message-ID: <0c2ef56e-5dab-fb79-fead-adb4acef4cc6@collabora.com> Date: Wed, 21 Sep 2022 11:45:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs To: yassine.oudjana@gmail.com, Krzysztof Kozlowski Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220919170115.94873-1-y.oudjana@protonmail.com> <20220919170115.94873-2-y.oudjana@protonmail.com> <4c425cf8-f9ca-969c-f8ed-688410bfb922@collabora.com> <1860b0ff-5544-5e74-ccfc-beda18824927@linaro.org> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Il 21/09/22 11:30, yassine.oudjana@gmail.com ha scritto: > > > On Wed, Sep 21 2022 at 09:11:12 AM +0200, Krzysztof Kozlowski > wrote: >> On 20/09/2022 10:06, AngeloGioacchino Del Regno wrote: >>>  Il 19/09/22 19:01, Yassine Oudjana ha scritto: >>>>  From: Yassine Oudjana >>>> >>>>  Documents for MT6779, MT6795 and MT6797 that currently exist share >>>>  most properties, and each one has slightly differently worded >>>>  descriptions for those properties. Combine all three documents into >>>>  one common document for all MT67xx SoC pin controllers, picking a few >>>>  parts from each and accounting for differences such as items in reg >>>>  and reg-names properties. Also document the MT6765 pin controller >>>>  which currently has a driver but no DT binding documentation. It should >>>>  be possible to also include bindings for MT8183 and MT8188, but these >>>>  have some additional properties that might complicate things a bit, >>>>  so they are left alone for now. >>>> >>>>  Signed-off-by: Yassine Oudjana >>>>  --- >>>>    .../pinctrl/mediatek,mt6779-pinctrl.yaml      | 207 ------------------ >>>>    .../pinctrl/mediatek,mt6797-pinctrl.yaml      | 176 --------------- >>>>    ...6795.yaml => mediatek,mt67xx-pinctrl.yaml} | 181 +++++++++++---- >>> >>>  Hello Yassine, >>>  nice cleanup over here! >>> >>>  There's a catch though: as far as I know, wildcards are not permitted... so you >>>  should, at this point, merge all of these in mediatek,mt6779-pinctrl.yaml instead. >>> >>>  Before jumping to that, though... Krzysztof, can you please confirm (or deny)? >> >> Wildcards are not allowed in compatibles. In filename wildcards or >> family name could work if they are really going to match the devices. I >> have doubts here. 67xx is quite a lot of different devices, so I am not >> sure this will cover them all. >> >> I would prefer one name (oldest SoC or lowest number). > > Lowest number (and probably oldest too but not sure since mediatek naming > conventions are a bit weird) currently documented is mt6779, but mt6765 gets > documented in this patch and mt6735 (this one I know for sure is older than the > rest) in a following patch, so do I just stick with mt6779 or do I change it in the > following patches documenting mt6765 and mt6735? > I see the sequence as: 1. You merge mediatek,mt6797-pinctrl.yaml into mediatek,mt6779-pinctrl.yaml; then 2. Adding MT6765 documentation to mediatek,mt6779-pinctrl.yaml; then 3. Adding support for MT6735, documentation goes again to 6779-pinctrl. This means that you're working with mediatek,mt6779-pinctrl.yaml :-) P.S.: That was also a suggestion about how to split things per-commit! Cheers, Angelo > Thanks, > Yassine > >> >> Best regards, >> Krzysztof > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE46BECAAD8 for ; Wed, 21 Sep 2022 09:49:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x1YVfd1lvQAdDhqhpM/all82U6LK1Lc+Wj0OZeceRdA=; b=IFrMANz0YrH8r6 OfK0O5LWZIG4cxbkthVdI4TAijGu9N/PmC6XVQ1FglXuVkP5T9ybL8jkv4Arc1kWcyV4312W19zjw fEgeLMlXr8fEvuRSFmgKpHY6pP2CRJFQQPMxYPi94UywjDTbAktsgFXGUKX3Fv0UZLQb6dWDBvfBu Mpo+Wudm0fOAG6zD0tRuUyrlM/k0MuSCGF5PRG+TQEm9AH4WDNPkN4JUIaqjsRR8OzVBUfg2OddEt IpINjzdStaztO360UMfK0HEryMCCgwTknF9qt/W7sjLqx4h+ixv5VTu3x2TRUwgrAqeoDhCIC+u0Z UrEkLLkhUlFinAklPQ7g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oawL6-00AafJ-Vw; Wed, 21 Sep 2022 09:48:21 +0000 Received: from madras.collabora.co.uk ([46.235.227.172]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oawIc-00AYLS-Jc; Wed, 21 Sep 2022 09:45:48 +0000 Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id C7FAC660202C; Wed, 21 Sep 2022 10:45:43 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1663753544; bh=9ji1SJvfdXYebHWHKsGj8bj+sMSEq74pzAp6Nbn4WWM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CQ13WHYIS9frO3QW4TLXbP+zllrNOekCNYslUt32DxeL8LgiWbziNNxXOHW40TnBO XQ8sMohQ/jRnrtvh234ZD1fLlLA+2pQ/3LI+46OCU4017X0ZpySHtGur4hjvy8+8Vk SUJbnwzxy4+xYsuMbFm6Z2nktJsxF3/RM2/0Qhzee7rGywwOeTlLDdPapCez7P0K8s cik6AH29MKZTU8r/gXBYI1/a+14po/EwWVQDGdIWR1Mh3EBODL19MxJz9YNZlF9Hvb PyTpUr4CaziU6zYnWI4ErS5dsPYzyWhwRMQ6gMmaGH7dW5Vra8kpWAoIJPlZGhd4xG JIz+KykszkSsw== Message-ID: <0c2ef56e-5dab-fb79-fead-adb4acef4cc6@collabora.com> Date: Wed, 21 Sep 2022 11:45:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH 1/4] dt-bindings: pinctrl: Combine MediaTek MT67xx pinctrl binding docs To: yassine.oudjana@gmail.com, Krzysztof Kozlowski Cc: Linus Walleij , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Andy Teng , Yassine Oudjana , linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220919170115.94873-1-y.oudjana@protonmail.com> <20220919170115.94873-2-y.oudjana@protonmail.com> <4c425cf8-f9ca-969c-f8ed-688410bfb922@collabora.com> <1860b0ff-5544-5e74-ccfc-beda18824927@linaro.org> Content-Language: en-US From: AngeloGioacchino Del Regno In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220921_024546_813615_FF1C08CB X-CRM114-Status: GOOD ( 21.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SWwgMjEvMDkvMjIgMTE6MzAsIHlhc3NpbmUub3VkamFuYUBnbWFpbC5jb20gaGEgc2NyaXR0bzoK PiAKPiAKPiBPbiBXZWQsIFNlcCAyMSAyMDIyIGF0IDA5OjExOjEyIEFNICswMjAwLCBLcnp5c3p0 b2YgS296bG93c2tpIAo+IDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+IHdyb3RlOgo+ PiBPbiAyMC8wOS8yMDIyIDEwOjA2LCBBbmdlbG9HaW9hY2NoaW5vIERlbCBSZWdubyB3cm90ZToK Pj4+IMKgSWwgMTkvMDkvMjIgMTk6MDEsIFlhc3NpbmUgT3VkamFuYSBoYSBzY3JpdHRvOgo+Pj4+ IMKgRnJvbTogWWFzc2luZSBPdWRqYW5hIDx5Lm91ZGphbmFAcHJvdG9ubWFpbC5jb20+Cj4+Pj4K Pj4+PiDCoERvY3VtZW50cyBmb3IgTVQ2Nzc5LCBNVDY3OTUgYW5kIE1UNjc5NyB0aGF0IGN1cnJl bnRseSBleGlzdCBzaGFyZQo+Pj4+IMKgbW9zdCBwcm9wZXJ0aWVzLCBhbmQgZWFjaCBvbmUgaGFz IHNsaWdodGx5IGRpZmZlcmVudGx5IHdvcmRlZAo+Pj4+IMKgZGVzY3JpcHRpb25zIGZvciB0aG9z ZSBwcm9wZXJ0aWVzLiBDb21iaW5lIGFsbCB0aHJlZSBkb2N1bWVudHMgaW50bwo+Pj4+IMKgb25l IGNvbW1vbiBkb2N1bWVudCBmb3IgYWxsIE1UNjd4eCBTb0MgcGluIGNvbnRyb2xsZXJzLCBwaWNr aW5nIGEgZmV3Cj4+Pj4gwqBwYXJ0cyBmcm9tIGVhY2ggYW5kIGFjY291bnRpbmcgZm9yIGRpZmZl cmVuY2VzIHN1Y2ggYXMgaXRlbXMgaW4gcmVnCj4+Pj4gwqBhbmQgcmVnLW5hbWVzIHByb3BlcnRp ZXMuIEFsc28gZG9jdW1lbnQgdGhlIE1UNjc2NSBwaW4gY29udHJvbGxlcgo+Pj4+IMKgd2hpY2gg Y3VycmVudGx5IGhhcyBhIGRyaXZlciBidXQgbm8gRFQgYmluZGluZyBkb2N1bWVudGF0aW9uLiBJ dCBzaG91bGQKPj4+PiDCoGJlIHBvc3NpYmxlIHRvIGFsc28gaW5jbHVkZSBiaW5kaW5ncyBmb3Ig TVQ4MTgzIGFuZCBNVDgxODgsIGJ1dCB0aGVzZQo+Pj4+IMKgaGF2ZSBzb21lIGFkZGl0aW9uYWwg cHJvcGVydGllcyB0aGF0IG1pZ2h0IGNvbXBsaWNhdGUgdGhpbmdzIGEgYml0LAo+Pj4+IMKgc28g dGhleSBhcmUgbGVmdCBhbG9uZSBmb3Igbm93Lgo+Pj4+Cj4+Pj4gwqBTaWduZWQtb2ZmLWJ5OiBZ YXNzaW5lIE91ZGphbmEgPHkub3VkamFuYUBwcm90b25tYWlsLmNvbT4KPj4+PiDCoC0tLQo+Pj4+ IMKgwqAgLi4uL3BpbmN0cmwvbWVkaWF0ZWssbXQ2Nzc5LXBpbmN0cmwueWFtbMKgwqDCoMKgwqAg fCAyMDcgLS0tLS0tLS0tLS0tLS0tLS0tCj4+Pj4gwqDCoCAuLi4vcGluY3RybC9tZWRpYXRlayxt dDY3OTctcGluY3RybC55YW1swqDCoMKgwqDCoCB8IDE3NiAtLS0tLS0tLS0tLS0tLS0KPj4+PiDC oMKgIC4uLjY3OTUueWFtbCA9PiBtZWRpYXRlayxtdDY3eHgtcGluY3RybC55YW1sfSB8IDE4MSAr KysrKysrKysrKy0tLS0KPj4+Cj4+PiDCoEhlbGxvIFlhc3NpbmUsCj4+PiDCoG5pY2UgY2xlYW51 cCBvdmVyIGhlcmUhCj4+Pgo+Pj4gwqBUaGVyZSdzIGEgY2F0Y2ggdGhvdWdoOiBhcyBmYXIgYXMg SSBrbm93LCB3aWxkY2FyZHMgYXJlIG5vdCBwZXJtaXR0ZWQuLi4gc28geW91Cj4+PiDCoHNob3Vs ZCwgYXQgdGhpcyBwb2ludCwgbWVyZ2UgYWxsIG9mIHRoZXNlIGluIG1lZGlhdGVrLG10Njc3OS1w aW5jdHJsLnlhbWwgaW5zdGVhZC4KPj4+Cj4+PiDCoEJlZm9yZSBqdW1waW5nIHRvIHRoYXQsIHRo b3VnaC4uLiBLcnp5c3p0b2YsIGNhbiB5b3UgcGxlYXNlIGNvbmZpcm0gKG9yIGRlbnkpPwo+Pgo+ PiBXaWxkY2FyZHMgYXJlIG5vdCBhbGxvd2VkIGluIGNvbXBhdGlibGVzLiBJbiBmaWxlbmFtZSB3 aWxkY2FyZHMgb3IKPj4gZmFtaWx5IG5hbWUgY291bGQgd29yayBpZiB0aGV5IGFyZSByZWFsbHkg Z29pbmcgdG8gbWF0Y2ggdGhlIGRldmljZXMuIEkKPj4gaGF2ZSBkb3VidHMgaGVyZS4gNjd4eCBp cyBxdWl0ZSBhIGxvdCBvZiBkaWZmZXJlbnQgZGV2aWNlcywgc28gSSBhbSBub3QKPj4gc3VyZSB0 aGlzIHdpbGwgY292ZXIgdGhlbSBhbGwuCj4+Cj4+IEkgd291bGQgcHJlZmVyIG9uZSBuYW1lIChv bGRlc3QgU29DIG9yIGxvd2VzdCBudW1iZXIpLgo+IAo+IExvd2VzdCBudW1iZXIgKGFuZCBwcm9i YWJseSBvbGRlc3QgdG9vIGJ1dCBub3Qgc3VyZSBzaW5jZSBtZWRpYXRlayBuYW1pbmcgCj4gY29u dmVudGlvbnMgYXJlIGEgYml0IHdlaXJkKSBjdXJyZW50bHkgZG9jdW1lbnRlZCBpcyBtdDY3Nzks IGJ1dCBtdDY3NjUgZ2V0cyAKPiBkb2N1bWVudGVkIGluIHRoaXMgcGF0Y2ggYW5kIG10NjczNSAo dGhpcyBvbmUgSSBrbm93IGZvciBzdXJlIGlzIG9sZGVyIHRoYW4gdGhlIAo+IHJlc3QpIGluIGEg Zm9sbG93aW5nIHBhdGNoLCBzbyBkbyBJIGp1c3Qgc3RpY2sgd2l0aCBtdDY3Nzkgb3IgZG8gSSBj aGFuZ2UgaXQgaW4gdGhlIAo+IGZvbGxvd2luZyBwYXRjaGVzIGRvY3VtZW50aW5nIG10Njc2NSBh bmQgbXQ2NzM1Pwo+IAoKSSBzZWUgdGhlIHNlcXVlbmNlIGFzOgoKMS4gWW91IG1lcmdlIG1lZGlh dGVrLG10Njc5Ny1waW5jdHJsLnlhbWwgaW50byBtZWRpYXRlayxtdDY3NzktcGluY3RybC55YW1s OyB0aGVuCjIuIEFkZGluZyBNVDY3NjUgZG9jdW1lbnRhdGlvbiB0byBtZWRpYXRlayxtdDY3Nzkt cGluY3RybC55YW1sOyB0aGVuCjMuIEFkZGluZyBzdXBwb3J0IGZvciBNVDY3MzUsIGRvY3VtZW50 YXRpb24gZ29lcyBhZ2FpbiB0byA2Nzc5LXBpbmN0cmwuCgpUaGlzIG1lYW5zIHRoYXQgeW91J3Jl IHdvcmtpbmcgd2l0aCBtZWRpYXRlayxtdDY3NzktcGluY3RybC55YW1sIDotKQoKUC5TLjogVGhh dCB3YXMgYWxzbyBhIHN1Z2dlc3Rpb24gYWJvdXQgaG93IHRvIHNwbGl0IHRoaW5ncyBwZXItY29t bWl0IQoKQ2hlZXJzLApBbmdlbG8KCj4gVGhhbmtzLAo+IFlhc3NpbmUKPiAKPj4KPj4gQmVzdCBy ZWdhcmRzLAo+PiBLcnp5c3p0b2YKPiAKPiAKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1h cm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcv bWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg==