From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD400C636CA for ; Fri, 16 Jul 2021 16:01:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD2A061164 for ; Fri, 16 Jul 2021 16:01:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240955AbhGPQEY (ORCPT ); Fri, 16 Jul 2021 12:04:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35232 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235138AbhGPQEW (ORCPT ); Fri, 16 Jul 2021 12:04:22 -0400 Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F2886C06175F; Fri, 16 Jul 2021 09:01:26 -0700 (PDT) Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BD14C805DF; Fri, 16 Jul 2021 18:01:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626451283; bh=6i5JGXlL1V3GzRerBd5Yb5nT3I1ajEBH7myeU25jc8E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NGQromh6ScHrW/4NMwJm/TNJla7SDk/N6ofjCi6q4i2x2Yj0OWt3YHxBunD6Trfua 8gdS4Kbq+IPjxT4i6oSdMn4b1LuVIhR1Kzumef9H8RGCLF/bHtkGAs+gEtbWPXf4OK edeacIDNq4cgFJlAsU5nG/gAWwqfocQDNUXPIR9XJcuLMifDFQcqhTiqQQmvhx8LJV vTN64zlJIw8HtQp5Mvdhhm25nVr+LIR7yK0Lk/ZkO80bZ5cRGFZK/lo/hcIzWLyOew 47sI4mnql4dalYah60E0c531rS4IMDvfq6LlkVfKShX/CtTxwZ9/InuossyPVoEm2p 5DgvZBZlvgmQw== Subject: Re: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes. To: Michal Simek , Raviteja Narayanam , linux-i2c@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com, joe@perches.com References: <20210626102806.15402-1-raviteja.narayanam@xilinx.com> <95162fd0-10e6-2bc6-4079-899ac26f66ce@xilinx.com> From: Marek Vasut Message-ID: <0c51785f-9763-aebc-a9ea-04337ad1accc@denx.de> Date: Fri, 16 Jul 2021 18:01:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <95162fd0-10e6-2bc6-4079-899ac26f66ce@xilinx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/21 9:23 AM, Michal Simek wrote: > > > On 6/26/21 12:27 PM, Raviteja Narayanam wrote: >> -Add 'standard mode' feature for reads > 255 bytes. >> -Add 'smbus block read' functionality. >> -Add 'xlnx,axi-iic-2.1' new IP version support. >> -Switch to 'AXI I2C standard mode' for i2c reads in affected IP versions. >> -Remove 'local_irq_save/restore' calls as discussed here: https://www.spinics.net/lists/linux-i2c/msg46483.html. >> -Some trivial fixes. >> >> Changes in v2: >> -Grouped the commits as fixes first and then features. >> -The first 4 commits fix the dynamic mode broken feature. >> -Corrected the indentation in coding style issues. >> >> Michal Simek (1): >> i2c: xiic: Fix coding style issues >> >> Raviteja Narayanam (7): >> i2c: xiic: Fix Tx Interrupt path for grouped messages >> i2c: xiic: Add standard mode support for > 255 byte read transfers >> i2c: xiic: Switch to Xiic standard mode for i2c-read >> i2c: xiic: Remove interrupt enable/disable in Rx path >> dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible >> i2c: xiic: Update compatible with new IP version >> i2c: xiic: Add smbus_block_read functionality >> >> Shubhrajyoti Datta (2): >> i2c: xiic: Return value of xiic_reinit >> i2c: xiic: Fix the type check for xiic_wakeup >> >> .../bindings/i2c/xlnx,xps-iic-2.00.a.yaml | 4 +- >> drivers/i2c/busses/i2c-xiic.c | 593 ++++++++++++++---- >> 2 files changed, 487 insertions(+), 110 deletions(-) >> > > Acked-by: Michal Simek I just tested this patchset on next-20210716 and the XIIC failures are still present, see: xiic-i2c a0010000.i2c: mmio a0010000 irq 36 xiic-i2c a0120000.i2c: mmio a0120000 irq 38 atmel_mxt_ts 3-004a: supply vdda not found, using dummy regulator atmel_mxt_ts 3-004a: supply vdd not found, using dummy regulator xiic-i2c a0120000.i2c: Timeout waiting at Tx empty atmel_mxt_ts 3-004a: __mxt_read_reg: i2c transfer failed (-5) atmel_mxt_ts 3-004a: mxt_bootloader_read: i2c recv failed (-5) atmel_mxt_ts 3-004a: Trying alternate bootloader address atmel_mxt_ts 3-004a: mxt_bootloader_read: i2c recv failed (-5) atmel_mxt_ts: probe of 3-004a failed with error -5 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7589AC07E95 for ; Fri, 16 Jul 2021 16:03:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 33D3B61164 for ; Fri, 16 Jul 2021 16:03:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 33D3B61164 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=6X5+7qu63dwyeE3EiXFaquIh1SQWESetubatUhs2uTQ=; b=k0ttFXb6IInivjsJeT3ByFKM7C AiZfgXeizcwlvnJiOboMv9HQeIHxR0zQgTgXa3fFUrAL9/WM3lcdxmC1QyPBz3kKH+m9/kfyOTSxu P5ixVWeFn78QarHAt5waMpjkx2kqOOIdZL6MC+byCLvESOc+dJC6X5Y5wXsPLrzjyuI8kP9mjEsjW 5gMZ7btN9G8xL0RtXEtFVaZW8PoBOFFYjsDGjB1amQJ1qvvvA9GrdZgXM++V/U6F0LoIdmezZemJ3 3dc1t66kEtDGvvrXkyb1wUBLjI5bHNK/F5ivBmMY9iqY4im6JU/OTu+6JHSs/B6L5dx9ZWlcbftM7 JfmPaoSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4QHK-004nAd-66; Fri, 16 Jul 2021 16:01:30 +0000 Received: from phobos.denx.de ([85.214.62.61]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m4QHG-004n9q-G4 for linux-arm-kernel@lists.infradead.org; Fri, 16 Jul 2021 16:01:28 +0000 Received: from [IPv6:::1] (p578adb1c.dip0.t-ipconnect.de [87.138.219.28]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: marex@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id BD14C805DF; Fri, 16 Jul 2021 18:01:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1626451283; bh=6i5JGXlL1V3GzRerBd5Yb5nT3I1ajEBH7myeU25jc8E=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=NGQromh6ScHrW/4NMwJm/TNJla7SDk/N6ofjCi6q4i2x2Yj0OWt3YHxBunD6Trfua 8gdS4Kbq+IPjxT4i6oSdMn4b1LuVIhR1Kzumef9H8RGCLF/bHtkGAs+gEtbWPXf4OK edeacIDNq4cgFJlAsU5nG/gAWwqfocQDNUXPIR9XJcuLMifDFQcqhTiqQQmvhx8LJV vTN64zlJIw8HtQp5Mvdhhm25nVr+LIR7yK0Lk/ZkO80bZ5cRGFZK/lo/hcIzWLyOew 47sI4mnql4dalYah60E0c531rS4IMDvfq6LlkVfKShX/CtTxwZ9/InuossyPVoEm2p 5DgvZBZlvgmQw== Subject: Re: [PATCH v2 00/10] i2c: xiic: Add features, bug fixes. To: Michal Simek , Raviteja Narayanam , linux-i2c@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@xilinx.com, joe@perches.com References: <20210626102806.15402-1-raviteja.narayanam@xilinx.com> <95162fd0-10e6-2bc6-4079-899ac26f66ce@xilinx.com> From: Marek Vasut Message-ID: <0c51785f-9763-aebc-a9ea-04337ad1accc@denx.de> Date: Fri, 16 Jul 2021 18:01:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <95162fd0-10e6-2bc6-4079-899ac26f66ce@xilinx.com> Content-Language: en-US X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210716_090126_784395_E6A7CFA2 X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/28/21 9:23 AM, Michal Simek wrote: > > > On 6/26/21 12:27 PM, Raviteja Narayanam wrote: >> -Add 'standard mode' feature for reads > 255 bytes. >> -Add 'smbus block read' functionality. >> -Add 'xlnx,axi-iic-2.1' new IP version support. >> -Switch to 'AXI I2C standard mode' for i2c reads in affected IP versions. >> -Remove 'local_irq_save/restore' calls as discussed here: https://www.spinics.net/lists/linux-i2c/msg46483.html. >> -Some trivial fixes. >> >> Changes in v2: >> -Grouped the commits as fixes first and then features. >> -The first 4 commits fix the dynamic mode broken feature. >> -Corrected the indentation in coding style issues. >> >> Michal Simek (1): >> i2c: xiic: Fix coding style issues >> >> Raviteja Narayanam (7): >> i2c: xiic: Fix Tx Interrupt path for grouped messages >> i2c: xiic: Add standard mode support for > 255 byte read transfers >> i2c: xiic: Switch to Xiic standard mode for i2c-read >> i2c: xiic: Remove interrupt enable/disable in Rx path >> dt-bindings: i2c: xiic: Add 'xlnx,axi-iic-2.1' to compatible >> i2c: xiic: Update compatible with new IP version >> i2c: xiic: Add smbus_block_read functionality >> >> Shubhrajyoti Datta (2): >> i2c: xiic: Return value of xiic_reinit >> i2c: xiic: Fix the type check for xiic_wakeup >> >> .../bindings/i2c/xlnx,xps-iic-2.00.a.yaml | 4 +- >> drivers/i2c/busses/i2c-xiic.c | 593 ++++++++++++++---- >> 2 files changed, 487 insertions(+), 110 deletions(-) >> > > Acked-by: Michal Simek I just tested this patchset on next-20210716 and the XIIC failures are still present, see: xiic-i2c a0010000.i2c: mmio a0010000 irq 36 xiic-i2c a0120000.i2c: mmio a0120000 irq 38 atmel_mxt_ts 3-004a: supply vdda not found, using dummy regulator atmel_mxt_ts 3-004a: supply vdd not found, using dummy regulator xiic-i2c a0120000.i2c: Timeout waiting at Tx empty atmel_mxt_ts 3-004a: __mxt_read_reg: i2c transfer failed (-5) atmel_mxt_ts 3-004a: mxt_bootloader_read: i2c recv failed (-5) atmel_mxt_ts 3-004a: Trying alternate bootloader address atmel_mxt_ts 3-004a: mxt_bootloader_read: i2c recv failed (-5) atmel_mxt_ts: probe of 3-004a failed with error -5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel