Re: [PATCH 1/2] drm/vmwgfx: Remove unused hugepage support

["Thomas Hellström (Intel)" <thomas_os@shipmail.org>]

On 4/25/22 22:31, Zack Rusin wrote:
> From: Zack Rusin <zackr@vmware.com>
>
> There's no point in explicitly trying to align virtual memory to
> facilitate huge page table entries or huge page memory in buffer objects
> given that they're not being used.
>
> Transparent hugepages support for vram allocations has been gradually
> retired over the last two years making alignment of unmapped areas
> unneeded and pointless.
>
> Signed-off-by: Zack Rusin <zackr@vmware.com>

For the series:

Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>


> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 13 -------------
>   1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> index 5dc02fd806db..45028e25d490 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
> @@ -1423,18 +1423,6 @@ static void vmw_debugfs_resource_managers_init(struct vmw_private *vmw)
>   					    root, "system_mob_ttm");
>   }
>   
> -static unsigned long
> -vmw_get_unmapped_area(struct file *file, unsigned long uaddr,
> -		      unsigned long len, unsigned long pgoff,
> -		      unsigned long flags)
> -{
> -	struct drm_file *file_priv = file->private_data;
> -	struct vmw_private *dev_priv = vmw_priv(file_priv->minor->dev);
> -
> -	return drm_get_unmapped_area(file, uaddr, len, pgoff, flags,
> -				     dev_priv->drm.vma_offset_manager);
> -}
> -
>   static int vmwgfx_pm_notifier(struct notifier_block *nb, unsigned long val,
>   			      void *ptr)
>   {
> @@ -1601,7 +1589,6 @@ static const struct file_operations vmwgfx_driver_fops = {
>   	.compat_ioctl = vmw_compat_ioctl,
>   #endif
>   	.llseek = noop_llseek,
> -	.get_unmapped_area = vmw_get_unmapped_area,
>   };
>   
>   static const struct drm_driver driver = {