From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09701C47423 for ; Fri, 2 Oct 2020 14:50:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CA9F72074B for ; Fri, 2 Oct 2020 14:50:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUYEjVJX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388250AbgJBOuR (ORCPT ); Fri, 2 Oct 2020 10:50:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387939AbgJBOuM (ORCPT ); Fri, 2 Oct 2020 10:50:12 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080D5C0613E2; Fri, 2 Oct 2020 07:50:12 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id b19so1401133lji.11; Fri, 02 Oct 2020 07:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=icdFDe/cdsShYJe56p6ssMuQsoQOC58YVV62WDTMBW0=; b=YUYEjVJXtGilO0I8BpRRXsmf/EUah8NX57KAzvzCVZWt4cW/TYEg6cXA6MeepCZqa1 u7ArwvnsYG5IHazbc0HXlIRzqdMhLTSzQogC1xPoVqYONsYzIdv50SdeOARAqaSgqxCY Bynav+aQx+Ap1Ec+5VUTEgy22ZeTP2UKNaerL38fCN6owZ3/B/daCiGm8AYhvqo8ahAl lYmTCSeNUvUl06fQ/M6ehFLykpnGnCj+xlDd/0OPXO8BD7QVE4CGk0lB2YOlYVgb05vW uh5qxI0SpwVzr+pHGy+5BLCIb8NkLdlKsjVWYxrwPpwRKSaksBPIm0cCi1yCjMXrSJwh mcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=icdFDe/cdsShYJe56p6ssMuQsoQOC58YVV62WDTMBW0=; b=d1wWeeIBMglsL3Ij8jTCVAEmc9j/MTKGyLcmM5s87SsIveowaKkb8sYAnl7gY2seV6 hefU4s7/Bqke5c8VnAkcH1NPOrB9Zx9k7jWiWYXDpxIQpPpVQSZQHDTIWCKsgVG7GYbw XUVN1dgD7DFTGaMJiznvJ4Rh7hlVG6bHOnQhhwGR+9dOtqcefBnOuJEwulU+jNeu+k7k o126KZHor+2Y5kv5s6D04jFTCnWuMIjcJLjC44gDJbT9OPPwNc7vB/d4NS4A3apM9S1Z RKO0hypg5MAKPMWcKg7ZB34NpICje4vdnBHB3Gd0zDJVrlsAPJ9qPDAc/7zKQNUgpNk+ tl4w== X-Gm-Message-State: AOAM5314HMI7+TUYkMnacRwTyEwZoSHOq+PgwzYy7p/7p1BqgEL/kek6 7JYZ/wX1MlXfL+OnWtDQkHPyLJhXZIU= X-Google-Smtp-Source: ABdhPJzk76ag8TT9nnz/AUf2dbIh1ndd+Rk83HU3cBelCn557Nxb5dCa1QoNUEh8XhIU/rPZ77bbaA== X-Received: by 2002:a05:651c:1397:: with SMTP id k23mr907389ljb.263.1601650209915; Fri, 02 Oct 2020 07:50:09 -0700 (PDT) Received: from [192.168.2.145] (109-252-91-252.nat.spd-mgts.ru. [109.252.91.252]) by smtp.googlemail.com with ESMTPSA id u20sm326506lfo.156.2020.10.02.07.50.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 07:50:09 -0700 (PDT) Subject: Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() From: Dmitry Osipenko To: Nicolin Chen , thierry.reding@gmail.com, joro@8bytes.org Cc: vdumpa@nvidia.com, jonathanh@nvidia.com, linux-tegra@vger.kernel.org, iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20201002060807.32138-1-nicoleotsuka@gmail.com> <20201002060807.32138-3-nicoleotsuka@gmail.com> Message-ID: <0c66bab9-0132-d3fb-ea4e-de1278cf2b04@gmail.com> Date: Fri, 2 Oct 2020 17:50:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 02.10.2020 17:22, Dmitry Osipenko пишет: >> static int tegra_smmu_of_xlate(struct device *dev, >> struct of_phandle_args *args) >> { >> + struct platform_device *iommu_pdev = of_find_device_by_node(args->np); >> + struct tegra_mc *mc = platform_get_drvdata(iommu_pdev); >> u32 id = args->args[0]; >> >> + of_node_put(args->np); >> + >> + if (!mc || !mc->smmu) >> + return -EPROBE_DEFER; > platform_get_drvdata(NULL) will crash. > Actually, platform_get_drvdata(NULL) can't happen. I overlooked this. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18FBEC4363D for ; Fri, 2 Oct 2020 14:50:28 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB2412065D for ; Fri, 2 Oct 2020 14:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YUYEjVJX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB2412065D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 64E3386CCC; Fri, 2 Oct 2020 14:50:27 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sOHdqKazhhFb; Fri, 2 Oct 2020 14:50:26 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 2935D86CCD; Fri, 2 Oct 2020 14:50:26 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0E520C016F; Fri, 2 Oct 2020 14:50:26 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id ED5BEC0051 for ; Fri, 2 Oct 2020 14:50:24 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 3EF2287392 for ; Fri, 2 Oct 2020 14:50:24 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4A7qU87OlFMO for ; Fri, 2 Oct 2020 14:50:13 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) by hemlock.osuosl.org (Postfix) with ESMTPS id A2FE487390 for ; Fri, 2 Oct 2020 14:50:11 +0000 (UTC) Received: by mail-lj1-f196.google.com with SMTP id c2so1396153ljj.12 for ; Fri, 02 Oct 2020 07:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=icdFDe/cdsShYJe56p6ssMuQsoQOC58YVV62WDTMBW0=; b=YUYEjVJXtGilO0I8BpRRXsmf/EUah8NX57KAzvzCVZWt4cW/TYEg6cXA6MeepCZqa1 u7ArwvnsYG5IHazbc0HXlIRzqdMhLTSzQogC1xPoVqYONsYzIdv50SdeOARAqaSgqxCY Bynav+aQx+Ap1Ec+5VUTEgy22ZeTP2UKNaerL38fCN6owZ3/B/daCiGm8AYhvqo8ahAl lYmTCSeNUvUl06fQ/M6ehFLykpnGnCj+xlDd/0OPXO8BD7QVE4CGk0lB2YOlYVgb05vW uh5qxI0SpwVzr+pHGy+5BLCIb8NkLdlKsjVWYxrwPpwRKSaksBPIm0cCi1yCjMXrSJwh mcbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=icdFDe/cdsShYJe56p6ssMuQsoQOC58YVV62WDTMBW0=; b=ZrCMd0DknrivPevQtsx5afKnw4cg+svIOnuw5o+tfyscRKX8rcaf8KwguQUFh1jOjo sb1WKGoItiGdM2ldESmkcdbJXw4rsw9cO9DQJ8ULLV2LK4sg54NnTCdeq/UpXUsl3jqh s/qf2ciQv5n5c3FkPXie00kn2n4y/IABRJWEUbgc+LEDZPuv5teeic12RthM7SnBlupK RaDaDRhZL92CkkXaErsX44muJ5P1UR3kAgjNgIReMvDNfGG6GZKZBAak8FzYE7hLD/E4 wRAw4DB6bFW+J+Q905gaQQfWf8CXUYL44JHfHaJSTwnWRLAfHraZjod22cB3EkSIapkV lwfA== X-Gm-Message-State: AOAM531r/xOTBVzvcZsk5NpfwjMxgnWlJTso4bK1VRpea3CNkDF6Qk5R wuZg/JStfyVY2G7c9MXymNU= X-Google-Smtp-Source: ABdhPJzk76ag8TT9nnz/AUf2dbIh1ndd+Rk83HU3cBelCn557Nxb5dCa1QoNUEh8XhIU/rPZ77bbaA== X-Received: by 2002:a05:651c:1397:: with SMTP id k23mr907389ljb.263.1601650209915; Fri, 02 Oct 2020 07:50:09 -0700 (PDT) Received: from [192.168.2.145] (109-252-91-252.nat.spd-mgts.ru. [109.252.91.252]) by smtp.googlemail.com with ESMTPSA id u20sm326506lfo.156.2020.10.02.07.50.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 07:50:09 -0700 (PDT) Subject: Re: [PATCH v4 2/3] iommu/tegra-smmu: Rework tegra_smmu_probe_device() From: Dmitry Osipenko To: Nicolin Chen , thierry.reding@gmail.com, joro@8bytes.org References: <20201002060807.32138-1-nicoleotsuka@gmail.com> <20201002060807.32138-3-nicoleotsuka@gmail.com> Message-ID: <0c66bab9-0132-d3fb-ea4e-de1278cf2b04@gmail.com> Date: Fri, 2 Oct 2020 17:50:08 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org, jonathanh@nvidia.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" MDIuMTAuMjAyMCAxNzoyMiwgRG1pdHJ5IE9zaXBlbmtvINC/0LjRiNC10YI6Cj4+ICBzdGF0aWMg aW50IHRlZ3JhX3NtbXVfb2ZfeGxhdGUoc3RydWN0IGRldmljZSAqZGV2LAo+PiAgCQkJICAgICAg IHN0cnVjdCBvZl9waGFuZGxlX2FyZ3MgKmFyZ3MpCj4+ICB7Cj4+ICsJc3RydWN0IHBsYXRmb3Jt X2RldmljZSAqaW9tbXVfcGRldiA9IG9mX2ZpbmRfZGV2aWNlX2J5X25vZGUoYXJncy0+bnApOwo+ PiArCXN0cnVjdCB0ZWdyYV9tYyAqbWMgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShpb21tdV9wZGV2 KTsKPj4gIAl1MzIgaWQgPSBhcmdzLT5hcmdzWzBdOwo+PiAgCj4+ICsJb2Zfbm9kZV9wdXQoYXJn cy0+bnApOwo+PiArCj4+ICsJaWYgKCFtYyB8fCAhbWMtPnNtbXUpCj4+ICsJCXJldHVybiAtRVBS T0JFX0RFRkVSOwo+IHBsYXRmb3JtX2dldF9kcnZkYXRhKE5VTEwpIHdpbGwgY3Jhc2guCj4gCgpB Y3R1YWxseSwgcGxhdGZvcm1fZ2V0X2RydmRhdGEoTlVMTCkgY2FuJ3QgaGFwcGVuLiBJIG92ZXJs b29rZWQgdGhpcy4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0 dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11