All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, pbonzini@redhat.com,
	rth@twiddle.net, Laine Stump <laine@redhat.com>,
	Alexander Bezzubikov <zuban32s@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port
Date: Fri, 8 Sep 2017 14:39:04 +0300	[thread overview]
Message-ID: <0c764f20-16ed-5bbc-f792-e410f56f1c93@redhat.com> (raw)
In-Reply-To: <20170906144958.GA7570@localhost.localdomain>

On 06/09/2017 17:49, Eduardo Habkost wrote:
> On Wed, Sep 06, 2017 at 05:26:58PM +0300, Marcel Apfelbaum wrote:
>> For most cases the devices attached to PCIe Root Ports
>> do not need IO ports range, add an 'enable-io-fwd' property
>> making it false by default, but keeping it true for older machines.
>>
>> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> [...]
>> @@ -78,6 +111,7 @@ static const VMStateDescription vmstate_rp_dev = {
>>   
>>   static Property gen_rp_props[] = {
>>       DEFINE_PROP_BOOL("x-migrate-msix", GenPCIERootPort, migrate_msix, true),
>> +    DEFINE_PROP_BOOL("enable-io-fwd", GenPCIERootPort, enable_io_fwd, false),
> 

Hi Eduardo,

> There's no "x-" prefix, so I guess we really need to let the user
> or management software to set enable-io-fwd=on explicitly on some
> cases?
> 

Definitely. Specifically 2 cases:
  - attach PCIe-PCI bridge to start a legacy PCI hierarchy.
  - assign a device requiring IO ports range.

Thanks,
Marcel

  reply	other threads:[~2017-09-08 11:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-06 14:26 [Qemu-devel] [PATCH 0/2] hw/pcie: disable IO port fwd by default for pcie-root-port Marcel Apfelbaum
2017-09-06 14:26 ` [Qemu-devel] [PATCH 1/2] pc: add 2.11 machine types Marcel Apfelbaum
2017-09-06 14:26 ` [Qemu-devel] [PATCH 2/2] hw/pcie: disable IO port fwd by default for pcie-root-port Marcel Apfelbaum
2017-09-06 14:49   ` Eduardo Habkost
2017-09-08 11:39     ` Marcel Apfelbaum [this message]
2017-09-19 22:15   ` Laszlo Ersek
2017-09-20  7:42     ` Marcel Apfelbaum
2017-09-20 11:01       ` Laszlo Ersek
2017-09-20 11:16         ` Marcel Apfelbaum
2017-09-20 11:35           ` Laszlo Ersek
2017-09-27 10:06         ` Marcel Apfelbaum
2017-09-28  7:48           ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c764f20-16ed-5bbc-f792-e410f56f1c93@redhat.com \
    --to=marcel@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=laine@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=zuban32s@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.