All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Tianling Shen <cnsztl@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	linux-kernel@vger.kernel.org, Sumit Gupta <sumitg@nvidia.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESENT PATCH] arm64: cpuinfo: Add "model name" in /proc/cpuinfo for 64bit tasks also
Date: Tue, 2 Feb 2021 13:09:02 +0000	[thread overview]
Message-ID: <0c7bfb19-c6ca-1700-8203-fb54e8c1ffae@arm.com> (raw)
In-Reply-To: <20210201235809.401-1-cnsztl@gmail.com>

On 2021-02-01 23:58, Tianling Shen wrote:
> From: Sumit Gupta <sumitg@nvidia.com>
> 
> Removed restriction of displaying model name for 32 bit tasks only.
> This can be used for 64 bit tasks as well, and it's useful for some
> tools that already parse this, such as coreutils `uname -p`, Ubuntu
> model name display etc.

How exactly is it useful? It clearly isn't necessary for compatibility, 
since AArch64 userspace has apparently been running quite happily for 8 
years without it. It also doesn't convey anything meaningful to the 
user, since they already know they're on an Armv8-compatible processor 
by the fact that they're running AArch64 userspace at all.

Robin.

> It should be like this:
> ```
> $ cat '/proc/cpuinfo' | grep 'model name' | head -n 1
> model name : ARMv8 Processor rev X (v8l)
> ```
> 
> Link: https://lore.kernel.org/lkml/1472461345-28219-1-git-send-email-sumitg@nvidia.com/
> 
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>   arch/arm64/kernel/cpuinfo.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 77605aec25fe..d69b4e486098 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -148,8 +148,7 @@ static int c_show(struct seq_file *m, void *v)
>   		 * "processor".  Give glibc what it expects.
>   		 */
>   		seq_printf(m, "processor\t: %d\n", i);
> -		if (compat)
> -			seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
> +		seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
>   				   MIDR_REVISION(midr), COMPAT_ELF_PLATFORM);
>   
>   		seq_printf(m, "BogoMIPS\t: %lu.%02lu\n",
> 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Tianling Shen <cnsztl@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	linux-kernel@vger.kernel.org,
	"Gustavo A. R. Silva" <gustavoars@kernel.org>,
	Sumit Gupta <sumitg@nvidia.com>,
	Vincenzo Frascino <vincenzo.frascino@arm.com>,
	Will Deacon <will@kernel.org>, Dave Martin <Dave.Martin@arm.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [RESENT PATCH] arm64: cpuinfo: Add "model name" in /proc/cpuinfo for 64bit tasks also
Date: Tue, 2 Feb 2021 13:09:02 +0000	[thread overview]
Message-ID: <0c7bfb19-c6ca-1700-8203-fb54e8c1ffae@arm.com> (raw)
In-Reply-To: <20210201235809.401-1-cnsztl@gmail.com>

On 2021-02-01 23:58, Tianling Shen wrote:
> From: Sumit Gupta <sumitg@nvidia.com>
> 
> Removed restriction of displaying model name for 32 bit tasks only.
> This can be used for 64 bit tasks as well, and it's useful for some
> tools that already parse this, such as coreutils `uname -p`, Ubuntu
> model name display etc.

How exactly is it useful? It clearly isn't necessary for compatibility, 
since AArch64 userspace has apparently been running quite happily for 8 
years without it. It also doesn't convey anything meaningful to the 
user, since they already know they're on an Armv8-compatible processor 
by the fact that they're running AArch64 userspace at all.

Robin.

> It should be like this:
> ```
> $ cat '/proc/cpuinfo' | grep 'model name' | head -n 1
> model name : ARMv8 Processor rev X (v8l)
> ```
> 
> Link: https://lore.kernel.org/lkml/1472461345-28219-1-git-send-email-sumitg@nvidia.com/
> 
> Signed-off-by: Sumit Gupta <sumitg@nvidia.com>
> Signed-off-by: Tianling Shen <cnsztl@gmail.com>
> ---
>   arch/arm64/kernel/cpuinfo.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
> index 77605aec25fe..d69b4e486098 100644
> --- a/arch/arm64/kernel/cpuinfo.c
> +++ b/arch/arm64/kernel/cpuinfo.c
> @@ -148,8 +148,7 @@ static int c_show(struct seq_file *m, void *v)
>   		 * "processor".  Give glibc what it expects.
>   		 */
>   		seq_printf(m, "processor\t: %d\n", i);
> -		if (compat)
> -			seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
> +		seq_printf(m, "model name\t: ARMv8 Processor rev %d (%s)\n",
>   				   MIDR_REVISION(midr), COMPAT_ELF_PLATFORM);
>   
>   		seq_printf(m, "BogoMIPS\t: %lu.%02lu\n",
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-02-02 13:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-01 23:58 [RESENT PATCH] arm64: cpuinfo: Add "model name" in /proc/cpuinfo for 64bit tasks also Tianling Shen
2021-02-01 23:58 ` Tianling Shen
2021-02-02 11:39 ` Catalin Marinas
2021-02-02 11:39   ` Catalin Marinas
2021-02-02 13:06   ` CN_SZTL
2021-02-02 13:06     ` CN_SZTL
2021-02-02 13:09 ` Robin Murphy [this message]
2021-02-02 13:09   ` Robin Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c7bfb19-c6ca-1700-8203-fb54e8c1ffae@arm.com \
    --to=robin.murphy@arm.com \
    --cc=Dave.Martin@arm.com \
    --cc=anshuman.khandual@arm.com \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=cnsztl@gmail.com \
    --cc=gustavoars@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sumitg@nvidia.com \
    --cc=suzuki.poulose@arm.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.