From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5E7CC32789 for ; Sat, 20 Aug 2022 19:34:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229812AbiHTTeI (ORCPT ); Sat, 20 Aug 2022 15:34:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229809AbiHTTeG (ORCPT ); Sat, 20 Aug 2022 15:34:06 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B847A5FEA; Sat, 20 Aug 2022 12:34:03 -0700 (PDT) Received: from [192.168.1.103] (178.176.79.13) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Sat, 20 Aug 2022 22:33:45 +0300 Subject: Re: [net-next 11/14] ptp: ravb: convert to .adjfine and adjust_by_scaled_ppm To: Jacob Keller , CC: "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Tom Lendacky , Shyam Sundar S K , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Siva Reddy Kallam , Prashant Sreedharan , Michael Chan , Yisen Zhuang , Salil Mehta , Jesse Brandeburg , Tony Nguyen , Tariq Toukan , Saeed Mahameed , Leon Romanovsky , Bryan Whitehead , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Richard Cochran , Vivek Thampi , VMware PV-Drivers Reviewers , Jie Wang , Guangbin Huang , Eran Ben Elisha , Aya Levin , Cai Huoqing , Biju Das , Lad Prabhakar , Phil Edworthy , Jiasheng Jiang , "Gustavo A. R. Silva" , Linus Walleij , Wan Jiabing , Lv Ruyi , Arnd Bergmann , References: <20220818222742.1070935-1-jacob.e.keller@intel.com> <20220818222742.1070935-12-jacob.e.keller@intel.com> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: <0c7fdf31-3c81-2253-ef45-106ca099cac7@omp.ru> Date: Sat, 20 Aug 2022 22:33:44 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20220818222742.1070935-12-jacob.e.keller@intel.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [178.176.79.13] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.20, Database issued on: 08/20/2022 19:17:08 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 172304 [Aug 20 2022] X-KSE-AntiSpam-Info: Version: 5.9.20.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 495 495 bb4e71e2e9e23696ab912b286436360a94c9b107 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.79.13 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;127.0.0.199:7.1.2;omp.ru:7.1.1 X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.79.13 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 08/20/2022 19:19:00 X-KSE-AttachmentFiltering-Interceptor-Info: protection disabled X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 8/20/2022 3:12:00 PM X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hello! On 8/19/22 1:27 AM, Jacob Keller wrote: > The ravb implementation of .adjfreq is implemented in terms of a > straight forward "base * ppb / 1 billion" calculation. > > Convert this driver to .adjfine and use the adjust_by_scaled_ppm helper > function to calculate the new addend. > > Signed-off-by: Jacob Keller > Cc: Sergey Shtylyov > Cc: Biju Das > Cc: Phil Edworthy > Cc: Lad Prabhakar > Cc: linux-renesas-soc@vger.kernel.org > --- > > I do not have this hardware, and have only compile tested the change. > > drivers/net/ethernet/renesas/ravb_ptp.c | 16 +++++----------- > 1 file changed, 5 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c > index 87c4306d66ec..941aa3b0e8a0 100644 > --- a/drivers/net/ethernet/renesas/ravb_ptp.c > +++ b/drivers/net/ethernet/renesas/ravb_ptp.c > @@ -88,24 +88,18 @@ static int ravb_ptp_update_compare(struct ravb_private *priv, u32 ns) > } > > /* PTP clock operations */ > -static int ravb_ptp_adjfreq(struct ptp_clock_info *ptp, s32 ppb) > +static int ravb_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm) > { > struct ravb_private *priv = container_of(ptp, struct ravb_private, > ptp.info); > struct net_device *ndev = priv->ndev; > unsigned long flags; > - u32 diff, addend; > - bool neg_adj = false; > + u32 addend; > u32 gccr; > > - if (ppb < 0) { > - neg_adj = true; > - ppb = -ppb; > - } > addend = priv->ptp.default_addend; I don't think we should keep this line -- it has no effect now... > - diff = div_u64((u64)addend * ppb, NSEC_PER_SEC); > - > - addend = neg_adj ? addend - diff : addend + diff; > + addend = (u32)adjust_by_scaled_ppm(priv->ptp.default_addend, > + scaled_ppm); > > spin_lock_irqsave(&priv->lock, flags); > [...] MBR, Sergey