From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D71FFC4338F for ; Fri, 13 Aug 2021 05:54:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC33160241 for ; Fri, 13 Aug 2021 05:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238687AbhHMFyX (ORCPT ); Fri, 13 Aug 2021 01:54:23 -0400 Received: from mail-wm1-f44.google.com ([209.85.128.44]:41583 "EHLO mail-wm1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238753AbhHMFyV (ORCPT ); Fri, 13 Aug 2021 01:54:21 -0400 Received: by mail-wm1-f44.google.com with SMTP id c129-20020a1c35870000b02902e6b6135279so4692334wma.0 for ; Thu, 12 Aug 2021 22:53:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kDicGygeeiPHvZ/oC8eypBw+MyBw86cziX0DHpCxNAc=; b=LeF2J1D+ZhGE0+6mPR8WrDr7dxgIwkxAfb7WNPaHK9BmUIavbEXr6L5SxDJNYAuDcy fDiy3QTNhJoqytFScaUM5dOtDk39pTiSb4zsKjv+3nJ8ZgEf0G6mdI2FjKKO38vK+wyN fcUJWXI0gQGNyfj8QhcoO/aUJgMCyN6v1FFftJz18Q5XAsAwFdh/BrI84shjcMk9VAoo FBocbW4TWfRaXUxERt9/Nw3R4j91ikPHmpx1TcwRXw1Rh8iAeKiefWu9sXBPnKhVHOb8 IojXGgIy6I/TA6FSakGNb5YLmkp8Cx/2hRKeF9FuyYIW/1Fy9wy8lbC/bosLYk0N92uS 5/zA== X-Gm-Message-State: AOAM533DFtqTIfUMU+ulV7SVUOyaKHXoH+Zi8Bj+bi1hLL+m7MFvRanN g68t1mCbqaGu7xu8u8iajMniH2qonwar6Q== X-Google-Smtp-Source: ABdhPJy8wAfKyM+oLt0Q9y4Hp5Drbt085CfMeHVfhn6+xq33iBgJferYKQ07teGjmNfJzUb9YyPx7g== X-Received: by 2002:a7b:c399:: with SMTP id s25mr917659wmj.180.1628834033697; Thu, 12 Aug 2021 22:53:53 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id l7sm388877wmj.9.2021.08.12.22.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 22:53:52 -0700 (PDT) Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars() To: kernel test robot , Xianting Tian , gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de, osandov@fb.com Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linuxppc-dev@lists.ozlabs.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org References: <20210812094532.145497-2-xianting.tian@linux.alibaba.com> <202108122040.lBf24DNp-lkp@intel.com> From: Jiri Slaby Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> Date: Fri, 13 Aug 2021 07:53:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 12. 08. 21, 14:26, kernel test robot wrote: >>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized] > spin_unlock_irqrestore(&hp->c_lock, flags); > ^~ > drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning > struct hvc_struct *hp; > ^ > = NULL So you clearly didn't test your change as it would crash quite instantly. I wonder, where do you intend to get hp from in the console::print() hook? thanks, -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE485C4338F for ; Fri, 13 Aug 2021 05:54:28 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 902496104F for ; Fri, 13 Aug 2021 05:54:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 902496104F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GmCS30PZtz3cPF for ; Fri, 13 Aug 2021 15:54:27 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.128.50; helo=mail-wm1-f50.google.com; envelope-from=jirislaby@gmail.com; receiver=) Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4GmCRX5gVwz2yXf for ; Fri, 13 Aug 2021 15:53:58 +1000 (AEST) Received: by mail-wm1-f50.google.com with SMTP id k5-20020a05600c1c85b02902e699a4d20cso6155984wms.2 for ; Thu, 12 Aug 2021 22:53:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kDicGygeeiPHvZ/oC8eypBw+MyBw86cziX0DHpCxNAc=; b=FU2y2j/FoAR5wpYs3EfLf5vz341S2R9qT8f0+zTm5Dw8w7Ia6ZX4RCEb4Gw6ecXUit q4tcH+hWviPPF9/zNU+/+ObKGBgQvf4eJPnSl9usT9s4fgQd03i8o0V1XTS4Q5Rr7eEG 9+9Tda57D3WWJr1CuEWUjN4F/hYxWMqEyw72gGf5+wsYGpfgrVKnbsk1PIgS1h/Qs5WJ Qfc4bKWzYXxW6VThNGeWYwPZ8W7lXHu8h8dVLCmMwcT2kShVKJDE0gKgI67Aof/ntI78 nZlaz+KzbW8SYo00S9fmzzBiACs9rFNhVnED+9MiDqlBBBtsjO5k2Tz5RP/u3738ADU2 kcow== X-Gm-Message-State: AOAM53163yvnm41ft4c/JZMpg+WAaSwDbCf0u3GQwm/7bAS9PWyOw4DP YPmWhDuVTP7sSySRyI7xClA= X-Google-Smtp-Source: ABdhPJy8wAfKyM+oLt0Q9y4Hp5Drbt085CfMeHVfhn6+xq33iBgJferYKQ07teGjmNfJzUb9YyPx7g== X-Received: by 2002:a7b:c399:: with SMTP id s25mr917659wmj.180.1628834033697; Thu, 12 Aug 2021 22:53:53 -0700 (PDT) Received: from ?IPv6:2a0b:e7c0:0:107::49? ([2a0b:e7c0:0:107::49]) by smtp.gmail.com with ESMTPSA id l7sm388877wmj.9.2021.08.12.22.53.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Aug 2021 22:53:52 -0700 (PDT) Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars() To: kernel test robot , Xianting Tian , gregkh@linuxfoundation.org, amit@kernel.org, arnd@arndb.de, osandov@fb.com References: <20210812094532.145497-2-xianting.tian@linux.alibaba.com> <202108122040.lBf24DNp-lkp@intel.com> From: Jiri Slaby Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> Date: Fri, 13 Aug 2021 07:53:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clang-built-linux@googlegroups.com, kbuild-all@lists.01.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi, On 12. 08. 21, 14:26, kernel test robot wrote: >>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uninitialized when used here [-Wuninitialized] > spin_unlock_irqrestore(&hp->c_lock, flags); > ^~ > drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable 'hp' to silence this warning > struct hvc_struct *hp; > ^ > = NULL So you clearly didn't test your change as it would crash quite instantly. I wonder, where do you intend to get hp from in the console::print() hook? thanks, -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============5211487886699824658==" MIME-Version: 1.0 From: Jiri Slaby To: kbuild-all@lists.01.org Subject: Re: [PATCH v6 1/2] tty: hvc: pass DMA capable memory to put_chars() Date: Fri, 13 Aug 2021 07:53:51 +0200 Message-ID: <0c808001-7643-fdcf-66ba-738654ec0c21@kernel.org> In-Reply-To: <202108122040.lBf24DNp-lkp@intel.com> List-Id: --===============5211487886699824658== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Hi, On 12. 08. 21, 14:26, kernel test robot wrote: >>> drivers/tty/hvc/hvc_console.c:190:26: warning: variable 'hp' is uniniti= alized when used here [-Wuninitialized] > spin_unlock_irqrestore(&hp->c_lock, flags); > ^~ > drivers/tty/hvc/hvc_console.c:149:23: note: initialize the variable '= hp' to silence this warning > struct hvc_struct *hp; > ^ > =3D NULL So you clearly didn't test your change as it would crash quite = instantly. I wonder, where do you intend to get hp from in the = console::print() hook? thanks, -- = js suse labs --===============5211487886699824658==--