From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEC96320A for ; Fri, 12 Aug 2022 22:44:54 +0000 (UTC) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D03EB32002F9; Fri, 12 Aug 2022 18:44:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Aug 2022 18:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=y xGydJ/BYVM5H/koF87d7C9Z6FJyYx7A96ssH3pivfZ9XoWPiQPjW8OYYrVaeVAkf wio5bxYolsXU2N+bsNOo/qzLv/tzSahaJ55+v82HG7KtzW7zkn+kIzuDvLqrKV/c fSZpdBaJ8VTY9mfu9h8KVEKnzwGT3YwwmN0kYtxlb598qs6J1XrX8Rxxko7Rbzl0 XlwmpHew1oR1kZYGIwMh9W/v13rv7pAjlO3yHaFH3fY0HqNImaoFhP1Xt8xb5LUT 5ZhLKD3RI0oNnrT+CygCvbSHziC3vkA0o4Ayj4W2JGXXne9ZO8UiunPd0HiLNBJu jrW2n5r0nPi4tIYUvvt3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=k uGXKzjuDEhMYgepOUZhdL5FNXZuwtlu1HhKJOdN5HE9syykiE0jlOFAtRJTArANU gQPgO/syw6ZdIZmhOpZw5/QgxrqFghvviGquJIWN+EoNRY+ZODjiPN567wuz5hAM D2uEDOSmGV7GqmtPgdGeoo5Fe0VwSYJnOGgfwaxxDnSSdTiAMzBtDnpGjZFn8x7d wccuZao/2V1jE28uVVAZ6xxUzZR7u6MTuNC8/YoQLjlH4hK5PNBd+1H1vT4/qtEW zYQnnlJ9ojdO3Bmz1cNvFrG90Rib0byj7c7pXaqh728tw0vVCNT/RLfSggv2T0Tc tSl8M0g1oh/cS1Wdq/5IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvvehfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpefftdevkedvgeekueeutefgteffieelvedukeeuhfehledvhfei tdehudfhudehhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:44:51 -0400 (EDT) Subject: Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property To: Paul Kocialkowski Cc: Kishon Vijay Abraham I , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Jagan Teki , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20220812075603.59375-1-samuel@sholland.org> <20220812075603.59375-2-samuel@sholland.org> From: Samuel Holland Message-ID: <0c82fb9e-60cd-70d5-96d6-ee06c56eeb85@sholland.org> Date: Fri, 12 Aug 2022 17:44:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Paul, On 8/12/22 7:22 AM, Paul Kocialkowski wrote: > On Fri 12 Aug 22, 02:55, Samuel Holland wrote: >> The sun6i DPHY can generate several interrupts, mostly for reporting >> error conditions, but also for detecting BTA and UPLS sequences. >> Document this capability in order to accurately describe the hardware. >> >> The DPHY has no interrupt number provided in the vendor documentation >> because its interrupt line is shared with the DSI controller. > > Interesting! I do see DPHY_INT_EN*/PD* in the Allwinner BSP's > drivers/media/video/sunxi-vfe/mipi_csi/dphy/dphy_reg_i.h You can also find some bit of documentation in the T7 User Manual. > Maybe it would be useful to import the fields in the driver so that the > next person who'll try to debug DSI can use them directly? > > You might also want to submit a patch as [PATCH NOT FOR MERGE] that > adds an interrupt routine and some useful debugging. I think this would be more interesting to someone who knew more about MIPI CSI/DSI and understood what those errors meant. :) I'm mostly concerned with bringing up the D1 SoC at the moment. > Do you think this is also available without a DSI controller? > I could just give it a try on V3/A83t here and find out :) I would assume so. It could possibly be shared with the MIPI CSI interrupt (SPI 90) or keep its position at SPI 89. Regards, Samuel >> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") >> Signed-off-by: Samuel Holland >> --- >> >> .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> index 22636c9fdab8..cf49bd99b3e2 100644 >> --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> @@ -24,6 +24,9 @@ properties: >> reg: >> maxItems: 1 >> >> + interrupts: >> + maxItems: 1 >> + >> clocks: >> items: >> - description: Bus Clock >> @@ -53,6 +56,7 @@ required: >> - "#phy-cells" >> - compatible >> - reg >> + - interrupts >> - clocks >> - clock-names >> - resets >> -- >> 2.35.1 >> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 691D5C00140 for ; Fri, 12 Aug 2022 22:45:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=PJ7VrFoys2G/djNGNe1lBzMvr2z2tNQflEnU0s5j+Oc=; b=I7hHR4BqoWEEmfmHyihidO/bTR 9sQFwjt379OAKj/jFpM4PxADLTZvVnTHYlqXINGTyGiMUnA1u6T+Wd3L4YETDt6+k5ix8aWVDGuer +lp6fTfqeECMUWDKtt1+vlX3A/la3C7GLesDeaybp4sR1PmfwJQD32T8idBRctCZm9sdPhBpeVeVN uQcmn73oQD3aJRzAtI+LDDJsONK71Z4P5PjSk9r+Lx2sj6UNwfronM8MhnO0fobxxhXEORQf13Oj1 Y3WCF9GJ+xAO0KVj5QRPDHQDR+6fiywXudt73Y56d/3/Bh+8HafJdz6Z2QA+erkO0KPOVKz1NXqjj ba/ZrsTA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMdOs-000EOD-SH; Fri, 12 Aug 2022 22:45:06 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMdOh-000EHU-A9; Fri, 12 Aug 2022 22:44:56 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D03EB32002F9; Fri, 12 Aug 2022 18:44:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Aug 2022 18:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=y xGydJ/BYVM5H/koF87d7C9Z6FJyYx7A96ssH3pivfZ9XoWPiQPjW8OYYrVaeVAkf wio5bxYolsXU2N+bsNOo/qzLv/tzSahaJ55+v82HG7KtzW7zkn+kIzuDvLqrKV/c fSZpdBaJ8VTY9mfu9h8KVEKnzwGT3YwwmN0kYtxlb598qs6J1XrX8Rxxko7Rbzl0 XlwmpHew1oR1kZYGIwMh9W/v13rv7pAjlO3yHaFH3fY0HqNImaoFhP1Xt8xb5LUT 5ZhLKD3RI0oNnrT+CygCvbSHziC3vkA0o4Ayj4W2JGXXne9ZO8UiunPd0HiLNBJu jrW2n5r0nPi4tIYUvvt3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=k uGXKzjuDEhMYgepOUZhdL5FNXZuwtlu1HhKJOdN5HE9syykiE0jlOFAtRJTArANU gQPgO/syw6ZdIZmhOpZw5/QgxrqFghvviGquJIWN+EoNRY+ZODjiPN567wuz5hAM D2uEDOSmGV7GqmtPgdGeoo5Fe0VwSYJnOGgfwaxxDnSSdTiAMzBtDnpGjZFn8x7d wccuZao/2V1jE28uVVAZ6xxUzZR7u6MTuNC8/YoQLjlH4hK5PNBd+1H1vT4/qtEW zYQnnlJ9ojdO3Bmz1cNvFrG90Rib0byj7c7pXaqh728tw0vVCNT/RLfSggv2T0Tc tSl8M0g1oh/cS1Wdq/5IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvvehfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpefftdevkedvgeekueeutefgteffieelvedukeeuhfehledvhfei tdehudfhudehhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:44:51 -0400 (EDT) Subject: Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property To: Paul Kocialkowski Cc: Kishon Vijay Abraham I , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Jagan Teki , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20220812075603.59375-1-samuel@sholland.org> <20220812075603.59375-2-samuel@sholland.org> From: Samuel Holland Message-ID: <0c82fb9e-60cd-70d5-96d6-ee06c56eeb85@sholland.org> Date: Fri, 12 Aug 2022 17:44:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_154455_414303_977CC1E6 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org Hi Paul, On 8/12/22 7:22 AM, Paul Kocialkowski wrote: > On Fri 12 Aug 22, 02:55, Samuel Holland wrote: >> The sun6i DPHY can generate several interrupts, mostly for reporting >> error conditions, but also for detecting BTA and UPLS sequences. >> Document this capability in order to accurately describe the hardware. >> >> The DPHY has no interrupt number provided in the vendor documentation >> because its interrupt line is shared with the DSI controller. > > Interesting! I do see DPHY_INT_EN*/PD* in the Allwinner BSP's > drivers/media/video/sunxi-vfe/mipi_csi/dphy/dphy_reg_i.h You can also find some bit of documentation in the T7 User Manual. > Maybe it would be useful to import the fields in the driver so that the > next person who'll try to debug DSI can use them directly? > > You might also want to submit a patch as [PATCH NOT FOR MERGE] that > adds an interrupt routine and some useful debugging. I think this would be more interesting to someone who knew more about MIPI CSI/DSI and understood what those errors meant. :) I'm mostly concerned with bringing up the D1 SoC at the moment. > Do you think this is also available without a DSI controller? > I could just give it a try on V3/A83t here and find out :) I would assume so. It could possibly be shared with the MIPI CSI interrupt (SPI 90) or keep its position at SPI 89. Regards, Samuel >> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") >> Signed-off-by: Samuel Holland >> --- >> >> .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> index 22636c9fdab8..cf49bd99b3e2 100644 >> --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> @@ -24,6 +24,9 @@ properties: >> reg: >> maxItems: 1 >> >> + interrupts: >> + maxItems: 1 >> + >> clocks: >> items: >> - description: Bus Clock >> @@ -53,6 +56,7 @@ required: >> - "#phy-cells" >> - compatible >> - reg >> + - interrupts >> - clocks >> - clock-names >> - resets >> -- >> 2.35.1 >> > -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6DAA1C00140 for ; Fri, 12 Aug 2022 22:46:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=W4GwaNV1mBuFMiTfszpbeMdAe1erW583y4zpjIC4Zzk=; b=Yb2pdYqGSBbrrv1pN3oOvSuvgn 2oeFDta634oUvHp32QNxklzLFPY2NWxImTAHpt9QVHLehSvInuwjgNlD6vgclrGZ3yCMltcp3q1aq ZawR/SHvD0y+VPSn/USIr4e7NDxrkNMSBDUDgpDATXOE1EcWNZuH1V9IHFfLR3gtskvhLWkn7ALot j9TqnH8DlL47YP9O+nOhQbesNefHcvfQsTuDVegOxaEqEvJLlJO1k5P6EAUe9EAxDK+tWyrw9BHt2 IbhLsEP6OPmUYC+8mDndAujPcziEfvZ2xOqgpIYKHtoW2Dd6R/C/AIGIQ/59qFCT0Qw7oAvqMrpnY zksIGPmg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMdOk-000ELe-QD; Fri, 12 Aug 2022 22:44:58 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oMdOh-000EHU-A9; Fri, 12 Aug 2022 22:44:56 +0000 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D03EB32002F9; Fri, 12 Aug 2022 18:44:52 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 12 Aug 2022 18:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sholland.org; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=y xGydJ/BYVM5H/koF87d7C9Z6FJyYx7A96ssH3pivfZ9XoWPiQPjW8OYYrVaeVAkf wio5bxYolsXU2N+bsNOo/qzLv/tzSahaJ55+v82HG7KtzW7zkn+kIzuDvLqrKV/c fSZpdBaJ8VTY9mfu9h8KVEKnzwGT3YwwmN0kYtxlb598qs6J1XrX8Rxxko7Rbzl0 XlwmpHew1oR1kZYGIwMh9W/v13rv7pAjlO3yHaFH3fY0HqNImaoFhP1Xt8xb5LUT 5ZhLKD3RI0oNnrT+CygCvbSHziC3vkA0o4Ayj4W2JGXXne9ZO8UiunPd0HiLNBJu jrW2n5r0nPi4tIYUvvt3Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1660344292; x= 1660430692; bh=eHaYN+aY4bW7BBAcwDPtlT5DUdMR3lZc1lanNKf+X2E=; b=k uGXKzjuDEhMYgepOUZhdL5FNXZuwtlu1HhKJOdN5HE9syykiE0jlOFAtRJTArANU gQPgO/syw6ZdIZmhOpZw5/QgxrqFghvviGquJIWN+EoNRY+ZODjiPN567wuz5hAM D2uEDOSmGV7GqmtPgdGeoo5Fe0VwSYJnOGgfwaxxDnSSdTiAMzBtDnpGjZFn8x7d wccuZao/2V1jE28uVVAZ6xxUzZR7u6MTuNC8/YoQLjlH4hK5PNBd+1H1vT4/qtEW zYQnnlJ9ojdO3Bmz1cNvFrG90Rib0byj7c7pXaqh728tw0vVCNT/RLfSggv2T0Tc tSl8M0g1oh/cS1Wdq/5IA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdegjedgudefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepuffvvehfhffkffgfgggjtgfgsehtjeertddtfeejnecuhfhrohhmpefurghm uhgvlhcujfholhhlrghnugcuoehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhgqeenuc ggtffrrghtthgvrhhnpefftdevkedvgeekueeutefgteffieelvedukeeuhfehledvhfei tdehudfhudehhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehsrghmuhgvlhesshhhohhllhgrnhgurdhorhhg X-ME-Proxy: Feedback-ID: i0ad843c9:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 12 Aug 2022 18:44:51 -0400 (EDT) Subject: Re: [PATCH 1/8] dt-bindings: sun6i-a31-mipi-dphy: Add the interrupts property To: Paul Kocialkowski Cc: Kishon Vijay Abraham I , Vinod Koul , Chen-Yu Tsai , Jernej Skrabec , Maxime Ripard , Jagan Teki , Krzysztof Kozlowski , Maxime Ripard , Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-sunxi@lists.linux.dev References: <20220812075603.59375-1-samuel@sholland.org> <20220812075603.59375-2-samuel@sholland.org> From: Samuel Holland Message-ID: <0c82fb9e-60cd-70d5-96d6-ee06c56eeb85@sholland.org> Date: Fri, 12 Aug 2022 17:44:50 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220812_154455_414303_977CC1E6 X-CRM114-Status: GOOD ( 23.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On 8/12/22 7:22 AM, Paul Kocialkowski wrote: > On Fri 12 Aug 22, 02:55, Samuel Holland wrote: >> The sun6i DPHY can generate several interrupts, mostly for reporting >> error conditions, but also for detecting BTA and UPLS sequences. >> Document this capability in order to accurately describe the hardware. >> >> The DPHY has no interrupt number provided in the vendor documentation >> because its interrupt line is shared with the DSI controller. > > Interesting! I do see DPHY_INT_EN*/PD* in the Allwinner BSP's > drivers/media/video/sunxi-vfe/mipi_csi/dphy/dphy_reg_i.h You can also find some bit of documentation in the T7 User Manual. > Maybe it would be useful to import the fields in the driver so that the > next person who'll try to debug DSI can use them directly? > > You might also want to submit a patch as [PATCH NOT FOR MERGE] that > adds an interrupt routine and some useful debugging. I think this would be more interesting to someone who knew more about MIPI CSI/DSI and understood what those errors meant. :) I'm mostly concerned with bringing up the D1 SoC at the moment. > Do you think this is also available without a DSI controller? > I could just give it a try on V3/A83t here and find out :) I would assume so. It could possibly be shared with the MIPI CSI interrupt (SPI 90) or keep its position at SPI 89. Regards, Samuel >> Fixes: c25b84c00826 ("dt-bindings: display: Convert Allwinner DSI to a schema") >> Signed-off-by: Samuel Holland >> --- >> >> .../bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> index 22636c9fdab8..cf49bd99b3e2 100644 >> --- a/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/allwinner,sun6i-a31-mipi-dphy.yaml >> @@ -24,6 +24,9 @@ properties: >> reg: >> maxItems: 1 >> >> + interrupts: >> + maxItems: 1 >> + >> clocks: >> items: >> - description: Bus Clock >> @@ -53,6 +56,7 @@ required: >> - "#phy-cells" >> - compatible >> - reg >> + - interrupts >> - clocks >> - clock-names >> - resets >> -- >> 2.35.1 >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel