From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764364AbcJaJw6 (ORCPT ); Mon, 31 Oct 2016 05:52:58 -0400 Received: from arroyo.ext.ti.com ([198.47.19.12]:58986 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764263AbcJaJw4 (ORCPT ); Mon, 31 Oct 2016 05:52:56 -0400 Subject: Re: [PATCH 2/2] ARM: bus: da8xx-mstpri: new driver To: Bartosz Golaszewski , Rob Herring References: <1477503355-2600-1-git-send-email-bgolaszewski@baylibre.com> <1477503355-2600-3-git-send-email-bgolaszewski@baylibre.com> <20161031043015.74ppaship5nqfaqt@rob-hp-laptop> CC: Kevin Hilman , Michael Turquette , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie , Laurent Pinchart From: Sekhar Nori Message-ID: <0cac724d-1aee-dfa7-9b78-8366fd6fceff@ti.com> Date: Mon, 31 Oct 2016 15:22:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Bartosz, On Monday 31 October 2016 03:10 PM, Bartosz Golaszewski wrote: > 2016-10-31 5:30 GMT+01:00 Rob Herring : >> On Wed, Oct 26, 2016 at 07:35:55PM +0200, Bartosz Golaszewski wrote: >>> Create the driver for the da8xx master peripheral priority >>> configuration and implement support for writing to the three >>> Master Priority registers on da850 SoCs. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> .../devicetree/bindings/bus/ti,da850-mstpri.txt | 20 ++ >>> drivers/bus/Kconfig | 9 + >>> drivers/bus/Makefile | 2 + >>> drivers/bus/da8xx-mstpri.c | 266 +++++++++++++++++++++ >>> 4 files changed, 297 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> create mode 100644 drivers/bus/da8xx-mstpri.c >>> >>> diff --git a/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> new file mode 100644 >>> index 0000000..225af09 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> @@ -0,0 +1,20 @@ >>> +* Device tree bindings for Texas Instruments da8xx master peripheral >>> + priority driver >>> + >>> +DA8XX SoCs feature a set of registers allowing to change the priority of all >>> +peripherals classified as masters. >>> + >>> +Documentation: >>> +OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf >>> + >>> +Required properties: >>> + >>> +- compatible: "ti,da850-mstpri", "syscon" - for da850 based boards >> >> Drop syscon. Doesn't look like it is needed and the example doesn't >> match. > > Hi Rob, > > it is needed: syscon_regmap_lookup_by_compatible() fails without it. I > fixed the example instead. Why are master priority registers under syscon? This driver should be the only entity touching them. So do we need an MFD driver? Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [PATCH 2/2] ARM: bus: da8xx-mstpri: new driver Date: Mon, 31 Oct 2016 15:22:03 +0530 Message-ID: <0cac724d-1aee-dfa7-9b78-8366fd6fceff@ti.com> References: <1477503355-2600-1-git-send-email-bgolaszewski@baylibre.com> <1477503355-2600-3-git-send-email-bgolaszewski@baylibre.com> <20161031043015.74ppaship5nqfaqt@rob-hp-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bartosz Golaszewski , Rob Herring Cc: Kevin Hilman , Michael Turquette , Frank Rowand , Mark Rutland , Peter Ujfalusi , Russell King , LKML , arm-soc , linux-drm , linux-devicetree , Jyri Sarha , Tomi Valkeinen , David Airlie , Laurent Pinchart List-Id: devicetree@vger.kernel.org Hi Bartosz, On Monday 31 October 2016 03:10 PM, Bartosz Golaszewski wrote: > 2016-10-31 5:30 GMT+01:00 Rob Herring : >> On Wed, Oct 26, 2016 at 07:35:55PM +0200, Bartosz Golaszewski wrote: >>> Create the driver for the da8xx master peripheral priority >>> configuration and implement support for writing to the three >>> Master Priority registers on da850 SoCs. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> .../devicetree/bindings/bus/ti,da850-mstpri.txt | 20 ++ >>> drivers/bus/Kconfig | 9 + >>> drivers/bus/Makefile | 2 + >>> drivers/bus/da8xx-mstpri.c | 266 +++++++++++++++++++++ >>> 4 files changed, 297 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> create mode 100644 drivers/bus/da8xx-mstpri.c >>> >>> diff --git a/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> new file mode 100644 >>> index 0000000..225af09 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> @@ -0,0 +1,20 @@ >>> +* Device tree bindings for Texas Instruments da8xx master peripheral >>> + priority driver >>> + >>> +DA8XX SoCs feature a set of registers allowing to change the priority of all >>> +peripherals classified as masters. >>> + >>> +Documentation: >>> +OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf >>> + >>> +Required properties: >>> + >>> +- compatible: "ti,da850-mstpri", "syscon" - for da850 based boards >> >> Drop syscon. Doesn't look like it is needed and the example doesn't >> match. > > Hi Rob, > > it is needed: syscon_regmap_lookup_by_compatible() fails without it. I > fixed the example instead. Why are master priority registers under syscon? This driver should be the only entity touching them. So do we need an MFD driver? Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Mon, 31 Oct 2016 15:22:03 +0530 Subject: [PATCH 2/2] ARM: bus: da8xx-mstpri: new driver In-Reply-To: References: <1477503355-2600-1-git-send-email-bgolaszewski@baylibre.com> <1477503355-2600-3-git-send-email-bgolaszewski@baylibre.com> <20161031043015.74ppaship5nqfaqt@rob-hp-laptop> Message-ID: <0cac724d-1aee-dfa7-9b78-8366fd6fceff@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Bartosz, On Monday 31 October 2016 03:10 PM, Bartosz Golaszewski wrote: > 2016-10-31 5:30 GMT+01:00 Rob Herring : >> On Wed, Oct 26, 2016 at 07:35:55PM +0200, Bartosz Golaszewski wrote: >>> Create the driver for the da8xx master peripheral priority >>> configuration and implement support for writing to the three >>> Master Priority registers on da850 SoCs. >>> >>> Signed-off-by: Bartosz Golaszewski >>> --- >>> .../devicetree/bindings/bus/ti,da850-mstpri.txt | 20 ++ >>> drivers/bus/Kconfig | 9 + >>> drivers/bus/Makefile | 2 + >>> drivers/bus/da8xx-mstpri.c | 266 +++++++++++++++++++++ >>> 4 files changed, 297 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> create mode 100644 drivers/bus/da8xx-mstpri.c >>> >>> diff --git a/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> new file mode 100644 >>> index 0000000..225af09 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/bus/ti,da850-mstpri.txt >>> @@ -0,0 +1,20 @@ >>> +* Device tree bindings for Texas Instruments da8xx master peripheral >>> + priority driver >>> + >>> +DA8XX SoCs feature a set of registers allowing to change the priority of all >>> +peripherals classified as masters. >>> + >>> +Documentation: >>> +OMAP-L138 (DA850) - http://www.ti.com/lit/ug/spruh82c/spruh82c.pdf >>> + >>> +Required properties: >>> + >>> +- compatible: "ti,da850-mstpri", "syscon" - for da850 based boards >> >> Drop syscon. Doesn't look like it is needed and the example doesn't >> match. > > Hi Rob, > > it is needed: syscon_regmap_lookup_by_compatible() fails without it. I > fixed the example instead. Why are master priority registers under syscon? This driver should be the only entity touching them. So do we need an MFD driver? Thanks, Sekhar