All of lore.kernel.org
 help / color / mirror / Atom feed
From: Willem Jan Withagen <wjw@digiware.nl>
To: Haomai Wang <haomai@xsky.com>
Cc: Ceph Development <ceph-devel@vger.kernel.org>
Subject: Re: Not matching event states in ./msg/async/AsyncConnection.cc
Date: Thu, 23 Jun 2016 09:22:29 +0200	[thread overview]
Message-ID: <0cb2f18c-a7e1-7a20-fab6-c4206e8a4aec@digiware.nl> (raw)
In-Reply-To: <1fef436f-c122-e66d-59c9-257bc2360722@digiware.nl>

On 23-6-2016 00:16, Willem Jan Withagen wrote:
> On 22-6-2016 16:36, Haomai Wang wrote:
>> Oh, sorry. I still realize you are testing on kqueue event backend.
>>
>> I submit a pr to fix this. plz help to verify whether it works for you
>> since I don't have bsd handy...
>>
>> https://github.com/ceph/ceph/pull/9869
> 
> I think add_event needs about the same treatment.
> Trying, Testing ATM....

errgh, not quite...

It also generates errors when trying to delete EVFILT_READ (mask=2) from
an eventfilter that has both READ and WRITE set (mask=3).
Next to that the ms_async_messenger threads seem to be busy_waiting
looping and loading a full CPU core per thread.

So I think I need some testing code to see what the requirements of
kqueue actually are, compared to what async_messenger does.

Could be that if we want to go from (READ|WRITE) to either READ or WRITE
the event needs to be deleted first and than added anew.

--WjW


  reply	other threads:[~2016-06-23  7:22 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <0a8a87d5-777c-7e78-0400-cf1978217928@digiware.nl>
2016-06-22 13:47 ` Not matching event states in ./msg/async/AsyncConnection.cc Willem Jan Withagen
2016-06-22 14:36   ` Haomai Wang
2016-06-22 15:25     ` Willem Jan Withagen
2016-06-22 22:09       ` Willem Jan Withagen
2016-06-22 22:16     ` Willem Jan Withagen
2016-06-23  7:22       ` Willem Jan Withagen [this message]
2016-06-23  7:44         ` Haomai Wang
2016-06-23  9:40           ` Willem Jan Withagen
2016-06-23 12:28             ` Haomai Wang
2016-06-23 13:16               ` Willem Jan Withagen
2016-06-23 15:16                 ` Willem Jan Withagen
2016-06-19 21:28 Willem Jan Withagen
2016-06-20  2:40 ` Haomai Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cb2f18c-a7e1-7a20-fab6-c4206e8a4aec@digiware.nl \
    --to=wjw@digiware.nl \
    --cc=ceph-devel@vger.kernel.org \
    --cc=haomai@xsky.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.