From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4326DC4338F for ; Wed, 4 Aug 2021 19:48:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 16F8960F58 for ; Wed, 4 Aug 2021 19:48:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229807AbhHDTsK (ORCPT ); Wed, 4 Aug 2021 15:48:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238128AbhHDTsJ (ORCPT ); Wed, 4 Aug 2021 15:48:09 -0400 Received: from relay08.th.seeweb.it (relay08.th.seeweb.it [IPv6:2001:4b7a:2000:18::169]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D7F9C0613D5 for ; Wed, 4 Aug 2021 12:47:56 -0700 (PDT) Received: from [192.168.1.101] (83.6.167.155.neoplus.adsl.tpnet.pl [83.6.167.155]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id A8BAC3F3FD; Wed, 4 Aug 2021 21:47:53 +0200 (CEST) Subject: Re: [PATCH v2 2/2] arm64: dts: qcom: sc7280-idp: Add device tree files for IDP2 To: Rajendra Nayak , agross@kernel.org, bjorn.andersson@linaro.org, robh+dt@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, skakit@codeaurora.org, swboyd@chromium.org, dianders@chromium.org, mka@chromium.org References: <1628082199-17002-1-git-send-email-rnayak@codeaurora.org> <1628082199-17002-3-git-send-email-rnayak@codeaurora.org> From: Konrad Dybcio Message-ID: <0cb8bf79-697c-ff16-e37e-d1c783f8a207@somainline.org> Date: Wed, 4 Aug 2021 21:47:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <1628082199-17002-3-git-send-email-rnayak@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 04.08.2021 15:03, Rajendra Nayak wrote: > Move all the common device tree bits for both sc7280 IDPs into a > sc7280-idp.dtsi and create 2 different dts files (sc7280-idp.dts > and sc7280-idp2.dts) in order to manage differences across the > IDP SKU1 and SKU2 Boards. > PMR735A is present on IDP board only and is not present on IDP2. > > Signed-off-by: Rajendra Nayak > --- > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sc7280-idp.dts | 328 +-------------------- I'm still for calling this sc7280-idp-sku1/2.dts, but other than that it looks good. Reviewed-by: Konrad Dybcio