From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3A9CC433FE for ; Thu, 21 Oct 2021 15:15:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB35A610A2 for ; Thu, 21 Oct 2021 15:15:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232057AbhJUPR5 (ORCPT ); Thu, 21 Oct 2021 11:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232138AbhJUPRj (ORCPT ); Thu, 21 Oct 2021 11:17:39 -0400 Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84CE0C061220; Thu, 21 Oct 2021 08:15:15 -0700 (PDT) Received: by mail-pg1-x52e.google.com with SMTP id h193so628802pgc.1; Thu, 21 Oct 2021 08:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bkdxL0wzVfK6U81ANaTN69N6MiyeE9mp/1NIRDs2HTI=; b=WDYFIyQjaIWLi9EqqahPeaZ3g9XaGJpJTvl7aIlSxv4+T2iLxZk6ihh0EcYRyY3Zv9 KXonk4/f0cn1/TUNjAeZRwXlkun5SEm/pNPx1JurtUgfoG1hcrA7Vbf+y3SZcwNAhs27 oyf2CEsoODVA2zAo/uaNQnMTxyGsyBkk6nqldQj8XvPEFv1FloLWaZsMhdRV5xSR3qQI BpLIKnaIy9a21t50pc8L7IGcPA6B9cN0riVUPf78VVm5ooHaUNsSW0Xh6unJ6RnCsqGz qOy6mK14quI9OCgP5LyUaUT9ZjyU+M7knF5DJTSkLQsJBk6xYSkKZpbV/uD8jtyZiw6U p4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bkdxL0wzVfK6U81ANaTN69N6MiyeE9mp/1NIRDs2HTI=; b=S5jyZ0FRI1ov6OhiVkk3bfA0pzM6C4HpuwexwBcmEzBv/DbhOtQyIbY3urQbFD7Dhy /EcO3wpURj6RUPqQ8WQu47/YekZIl/RU3UNntAF7WabbcPG6onemoXzd/Y5x606QC7Y8 MUwu9RzwJlyfy5B3xZjVvHDqQUEm5Ymg15BrgdpHYtUy819gUF0sXKcN1i9FahdcOM/G sdjsDWYnwdvyhwbprI/i93NM23N0adSn4K+pzOK8/24KsVZLQMmPxZxZlIYZ8qVO7mcF zflcyl4mIO7B9CCDCaC3JGdXB1DfvXY2oL5tTTB1KFUCRKlF9MgkvtZ3aMX/r7/6lDVs aE9w== X-Gm-Message-State: AOAM533SnIOg9niEdDSEMyGgubmVNp6Xo3EjLSnJHLZ/ImMtJZkMy0oj A+ZDBD8EHKCzs3Nw4p4Cua0= X-Google-Smtp-Source: ABdhPJxWSg5WrH6K/IpSe2kzM6dJ/L3POzUlC9k52ws51b3rAzBHEtnS6HtA7ZVCDbXya2+WK5dIKw== X-Received: by 2002:a63:2c91:: with SMTP id s139mr4832521pgs.116.1634829315039; Thu, 21 Oct 2021 08:15:15 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:29a4:d874:a949:6890:f95f]) by smtp.gmail.com with ESMTPSA id c9sm5508027pgq.58.2021.10.21.08.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 08:15:14 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com Cc: Naveen Naidu , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, skhan@linuxfoundation.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Lorenzo Pieralisi , Rob Herring , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-hyperv@vger.kernel.org (open list:Hyper-V/Azure CORE AND DRIVERS) Subject: [PATCH v3 24/25] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Date: Thu, 21 Oct 2021 20:37:49 +0530 Message-Id: <0cbcf03e6a66aa1092862d3cde22e487855b9c2d.1634825082.git.naveennaidu479@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Include PCI_ERROR_RESPONSE along with 0xFFFFFFFF in the comment to specify a hardware error. This makes MMIO read errors easier to find. Signed-off-by: Naveen Naidu --- drivers/pci/controller/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index 67c46e52c0dc..7e1102e3d7c6 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -1774,7 +1774,7 @@ static void prepopulate_bars(struct hv_pcibus_device *hbus) * If the memory enable bit is already set, Hyper-V silently ignores * the below BAR updates, and the related PCI device driver can not * work, because reading from the device register(s) always returns - * 0xFFFFFFFF. + * 0xFFFFFFFF (PCI_ERROR_RESPONSE). */ list_for_each_entry(hpdev, &hbus->children, list_entry) { _hv_pcifront_read_config(hpdev, PCI_COMMAND, 2, &command); -- 2.25.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF4BAC433F5 for ; Thu, 21 Oct 2021 15:15:18 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 799D260F46 for ; Thu, 21 Oct 2021 15:15:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 799D260F46 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 4A06F80D3B; Thu, 21 Oct 2021 15:15:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id erGNtqzirOx6; Thu, 21 Oct 2021 15:15:17 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp1.osuosl.org (Postfix) with ESMTPS id 7CCA18100C; Thu, 21 Oct 2021 15:15:17 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 5CE61C001C; Thu, 21 Oct 2021 15:15:17 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 4CE56C0011 for ; Thu, 21 Oct 2021 15:15:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 2EFF1401BD for ; Thu, 21 Oct 2021 15:15:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id KZ4MJ8xuBwjN for ; Thu, 21 Oct 2021 15:15:15 +0000 (UTC) X-Greylist: whitelisted by SQLgrey-1.8.0 Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) by smtp4.osuosl.org (Postfix) with ESMTPS id 94204400C8 for ; Thu, 21 Oct 2021 15:15:15 +0000 (UTC) Received: by mail-pg1-x533.google.com with SMTP id q5so596923pgr.7 for ; Thu, 21 Oct 2021 08:15:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bkdxL0wzVfK6U81ANaTN69N6MiyeE9mp/1NIRDs2HTI=; b=WDYFIyQjaIWLi9EqqahPeaZ3g9XaGJpJTvl7aIlSxv4+T2iLxZk6ihh0EcYRyY3Zv9 KXonk4/f0cn1/TUNjAeZRwXlkun5SEm/pNPx1JurtUgfoG1hcrA7Vbf+y3SZcwNAhs27 oyf2CEsoODVA2zAo/uaNQnMTxyGsyBkk6nqldQj8XvPEFv1FloLWaZsMhdRV5xSR3qQI BpLIKnaIy9a21t50pc8L7IGcPA6B9cN0riVUPf78VVm5ooHaUNsSW0Xh6unJ6RnCsqGz qOy6mK14quI9OCgP5LyUaUT9ZjyU+M7knF5DJTSkLQsJBk6xYSkKZpbV/uD8jtyZiw6U p4Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bkdxL0wzVfK6U81ANaTN69N6MiyeE9mp/1NIRDs2HTI=; b=1Jy3MPsHJ4tOu3FeU0F8qsyAjxWOx+HgaQlKYTTIHFtYoYWtQAjAinzcKEqtLyZXDZ +yXt3RGH4pgxni7mGI4musF+NVKkcd9iBxtpkrtfcdOOBXNON7gyMgaDGCE5dfDBEuri XW+pUY6vQpKQymoFCZisTMul6crMOfaEOVAiUaJSKJlgfpMKnyKh/qlQGCFDOExurmTZ CPyUyt2boEVX9+lkfY0A41MOu2Lsk0h7ExejjJNzYvRO7MwStTarh7WskhzLIDeCkx7L m3JDXQOPTO50nOmC6RTW7p5G5IVNxvdJuF8PqNGD9TnH0eu4b8Qh91ZTeTIoIQFQdZuL fcyQ== X-Gm-Message-State: AOAM533yR5uuVumcL5Ck3xNiaGfNKjNWXS/eI0154FwaJvNPyTCe6bFT VCLuuhQLVQgibbZj3cw+gSM= X-Google-Smtp-Source: ABdhPJxWSg5WrH6K/IpSe2kzM6dJ/L3POzUlC9k52ws51b3rAzBHEtnS6HtA7ZVCDbXya2+WK5dIKw== X-Received: by 2002:a63:2c91:: with SMTP id s139mr4832521pgs.116.1634829315039; Thu, 21 Oct 2021 08:15:15 -0700 (PDT) Received: from localhost.localdomain ([2406:7400:63:29a4:d874:a949:6890:f95f]) by smtp.gmail.com with ESMTPSA id c9sm5508027pgq.58.2021.10.21.08.15.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Oct 2021 08:15:14 -0700 (PDT) From: Naveen Naidu To: bhelgaas@google.com Subject: [PATCH v3 24/25] PCI: hv: Use PCI_ERROR_RESPONSE to specify hardware read error Date: Thu, 21 Oct 2021 20:37:49 +0530 Message-Id: <0cbcf03e6a66aa1092862d3cde22e487855b9c2d.1634825082.git.naveennaidu479@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 Cc: Rob Herring , Wei Liu , Lorenzo Pieralisi , Stephen Hemminger , "open list:Hyper-V/Azure CORE AND DRIVERS" , =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= , linux-pci@vger.kernel.org, Haiyang Zhang , Dexuan Cui , linux-kernel@vger.kernel.org, "K. Y. Srinivasan" , linux-kernel-mentees@lists.linuxfoundation.org X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" Include PCI_ERROR_RESPONSE along with 0xFFFFFFFF in the comment to specify a hardware error. This makes MMIO read errors easier to find. Signed-off-by: Naveen Naidu --- drivers/pci/controller/pci-hyperv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/controller/pci-hyperv.c b/drivers/pci/controller/pci-hyperv.c index 67c46e52c0dc..7e1102e3d7c6 100644 --- a/drivers/pci/controller/pci-hyperv.c +++ b/drivers/pci/controller/pci-hyperv.c @@ -1774,7 +1774,7 @@ static void prepopulate_bars(struct hv_pcibus_device *hbus) * If the memory enable bit is already set, Hyper-V silently ignores * the below BAR updates, and the related PCI device driver can not * work, because reading from the device register(s) always returns - * 0xFFFFFFFF. + * 0xFFFFFFFF (PCI_ERROR_RESPONSE). */ list_for_each_entry(hpdev, &hbus->children, list_entry) { _hv_pcifront_read_config(hpdev, PCI_COMMAND, 2, &command); -- 2.25.1 _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees