From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3877BC433F5 for ; Wed, 16 Mar 2022 19:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348068AbiCPTjf (ORCPT ); Wed, 16 Mar 2022 15:39:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239955AbiCPTje (ORCPT ); Wed, 16 Mar 2022 15:39:34 -0400 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B34F2983E for ; Wed, 16 Mar 2022 12:38:19 -0700 (PDT) Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 1CBC03F1E5 for ; Wed, 16 Mar 2022 19:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647459493; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qsZipiORv/nFk23zk3TB6ijV+rP1RnwVvsblAxN7JTa7UKNvcIIpSQZeStEwJRTNf EtYuJqzoGq8sLvWf5DDEd3THm1iEA/ryQaqR1AmmRcpvqyHHNfZLkkvkL41ExUXecG Wtz1tcFBdnOxadFd2DCXVuH2TFC7/m7d+vlVCGNpY8PUcycZloZw3U7dSe40gsOuBp OWbvjWSYqF99PqGONGin62JK0xf/LyFYf8F3stWMw6/EUSwf7jZcRxKN2Jjj0S/PZx lskY7xlovtPVUo3Jkzu++rCS2OfQ25H2UCHTw5cYcyqpLD6GRhvyLGxj8zidm0EA3K UDk2pXdpdxunA== Received: by mail-wm1-f72.google.com with SMTP id c19-20020a05600c0ad300b00385bb3db625so3207193wmr.4 for ; Wed, 16 Mar 2022 12:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; b=TSt/giJUTRicerSVGBhOTZIrgh/86RcBbGidDvJLRkN63QZbiQOo3DyVnNRpXBV93f ngQkbjITKrv9+177vSieozZjYbaaCGYnRGC5y/FBK8/cEkXA5fA8wXB4b/wfE5YhsBoY gToxy8tZ2TESYp8LFUJ5pvzcqPPLl78WZ+cCXITIlKZV+AmxP5//44WQF/2Gr9g7sTOD mAbeM8rv4/DucuPKRao0RiY0X87AeWpUBfFAeMGuQBVa+QoKs7+EIY59VE0i32e094S7 ZH3CQ8eiBxvI7I3o7WFZWDNHNAaE1IVR5eyGNgfj184ATLHNSTPFOze9o0vSMJXuRNPR Dptw== X-Gm-Message-State: AOAM530olcl6L0eh1rPnu1NUnvEeo7AZurNc/l0wWQzKGaRaDeRnTRwt RpkO76UnnrH19UpQke3ro8zC9sMAqSZp6m7RR92zTB64j4pJswvJ+WQp14gdFgedgc855/uEiRM Gxxc33McFU0ym1sOOCcGZR7ofP8W+whJNXGhfM6EMft5QCB8= X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045825wmo.104.1647459492727; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz2q+ZfMVNL/xv6DCH0VHKA2cCReGbKqid/bgaItjng219g1bFLER3WRAwMzoyrwOoAn1bTw== X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045789wmo.104.1647459492463; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id c7-20020a5d4f07000000b00203db8f13c6sm2300253wru.75.2022.03.16.12.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 12:38:11 -0700 (PDT) Message-ID: <0cc4e90d-c5e5-e6a3-6cc6-23d3058b9731@canonical.com> Date: Wed, 16 Mar 2022 20:38:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 11/11] rpmsg: Fix kfree() of static memory on setting driver_override Content-Language: en-US To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Andy Shevchenko , stable@vger.kernel.org References: <20220316150533.421349-1-krzysztof.kozlowski@canonical.com> <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On 16/03/2022 16:08, Krzysztof Kozlowski wrote: > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. > > Use dedicated helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Cc: > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Bjorn Andersson > --- > drivers/rpmsg/rpmsg_core.c | 3 ++- > drivers/rpmsg/rpmsg_internal.h | 11 +++++++++-- > drivers/rpmsg/rpmsg_ns.c | 14 ++++++++++++-- > include/linux/rpmsg.h | 6 ++++-- > 4 files changed, 27 insertions(+), 7 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 79368a957d89..95fc283f6af7 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -400,7 +400,8 @@ field##_store(struct device *dev, struct device_attribute *attr, \ > const char *buf, size_t sz) \ > { \ > struct rpmsg_device *rpdev = to_rpmsg_device(dev); \ > - char *new, *old; \ > + const char *old; \ > + char *new; \ > \ > new = kstrndup(buf, sz, GFP_KERNEL); \ > if (!new) \ > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index d4b23fd019a8..dd1f4ed616b6 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -95,9 +95,16 @@ int rpmsg_release_channel(struct rpmsg_device *rpdev, > static inline int rpmsg_ctrldev_register_device(struct rpmsg_device *rpdev) > { > strcpy(rpdev->id.name, "rpmsg_ctrl"); > - rpdev->driver_override = "rpmsg_ctrl"; > + ret = driver_set_override(&rpdev->dev, &rpdev->driver_override, > + "rpmsg_ctrl", strlen("rpmsg_ctrl")); I made here a mistake while rebasing. This will need a v6. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5254C433EF for ; Wed, 16 Mar 2022 19:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OZi5xf9wU3P1K/ebOcLjFzig3V4sWcPXNk1LJ4iuWd0=; b=zt7iAoIMpoWYRx MTBXjYL7ZFOHMx86Lnhy/P5DFqE58Vpdh4j2Y+lEyLTe6eg9DRffPpZ/p3DSEwanlJDbV16UzyJHL CKTqkFCyHcnkdDXZiRYAuGnW4wB6wvYzJef4ICnavlegCti7NZcx0vIAE9F9ABOTbgXcheNrCGlJB nm/woLdqDMRkNpidMPM9qmL6MlTWeJVrTqclSwW764WTQrE0Bm4yGbkAuPWp7lONtXFt8uI82H585 YcmmS+jJ3PlHpukrlgCHpCR00voTeLhAazAXk3VPq5F+DkpNPLxWipME8ZqCWVxD39OoNUe+E2YZT njFnssIXEsjTfJLKHdRA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZTU-00ECaA-FP; Wed, 16 Mar 2022 19:38:24 +0000 Received: from smtp-relay-internal-1.canonical.com ([185.125.188.123]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nUZTR-00ECZn-1k for linux-arm-kernel@lists.infradead.org; Wed, 16 Mar 2022 19:38:22 +0000 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 92BD73F798 for ; Wed, 16 Mar 2022 19:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647459493; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qsZipiORv/nFk23zk3TB6ijV+rP1RnwVvsblAxN7JTa7UKNvcIIpSQZeStEwJRTNf EtYuJqzoGq8sLvWf5DDEd3THm1iEA/ryQaqR1AmmRcpvqyHHNfZLkkvkL41ExUXecG Wtz1tcFBdnOxadFd2DCXVuH2TFC7/m7d+vlVCGNpY8PUcycZloZw3U7dSe40gsOuBp OWbvjWSYqF99PqGONGin62JK0xf/LyFYf8F3stWMw6/EUSwf7jZcRxKN2Jjj0S/PZx lskY7xlovtPVUo3Jkzu++rCS2OfQ25H2UCHTw5cYcyqpLD6GRhvyLGxj8zidm0EA3K UDk2pXdpdxunA== Received: by mail-wr1-f69.google.com with SMTP id k20-20020adfc714000000b001e305cd1597so879739wrg.19 for ; Wed, 16 Mar 2022 12:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; b=hWEJ5gDoGueoHEA5XPYhgoxocuvoKxtOaMX24AvGgMCZN2rZ2ki87Rg+jumJyDe6jA /IYR6iyohUEoBE0xpuocc4ju06JsMzjG3d4xbP4DgILMVkgF2Z/2siQF8m68+LxCWEEH DpZK2BoDaw+bZ3NhiQftRz9EmTBvsRVFgKxweGjFr/TH/PptliS/8EmikQoTmcyAsKW2 uRY69Qiz3HYK4pgAtHAFgZXy9H0LGPQtZtvEQkQi+Tn5cKgajCgpven7yFoFUG/wBOG4 UYe6AMGnDnLEefC05vQl1tz89k1y/0V/pfQtTKvvWbDpOY3VAYTLq5PjzHW9Qio/+ETq XGaA== X-Gm-Message-State: AOAM5329UShBiiXPFI3velLzT4CT2YOkf5LerkGxzOwnmmC0JGsg/4aD +mRoMPSkoFVsIfYayu6kXXGcuhFRwrF1FKvIs4IMpzQX/maxL8a3DMV8z4jDT3YUPRz+rKJAcck 9FSoc9sEAyyLBNRQXQWk8Onf5+/DzqHEYL4inWe6mTXZi8F5Hh5S3 X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045808wmo.104.1647459492725; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz2q+ZfMVNL/xv6DCH0VHKA2cCReGbKqid/bgaItjng219g1bFLER3WRAwMzoyrwOoAn1bTw== X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045789wmo.104.1647459492463; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id c7-20020a5d4f07000000b00203db8f13c6sm2300253wru.75.2022.03.16.12.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 12:38:11 -0700 (PDT) Message-ID: <0cc4e90d-c5e5-e6a3-6cc6-23d3058b9731@canonical.com> Date: Wed, 16 Mar 2022 20:38:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 11/11] rpmsg: Fix kfree() of static memory on setting driver_override Content-Language: en-US To: Greg Kroah-Hartman , "Rafael J. Wysocki" Cc: Stuart Yoder , "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Wei Liu , Dexuan Cui , Bjorn Helgaas , Bjorn Andersson , Mathieu Poirier , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Andy Gross , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-hyperv@vger.kernel.org, linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-spi@vger.kernel.org, virtualization@lists.linux-foundation.org, Linus Torvalds , Rasmus Villemoes , Andy Shevchenko , stable@vger.kernel.org References: <20220316150533.421349-1-krzysztof.kozlowski@canonical.com> <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220316_123821_330131_E5193A93 X-CRM114-Status: GOOD ( 19.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/03/2022 16:08, Krzysztof Kozlowski wrote: > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. > > Use dedicated helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Cc: > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Bjorn Andersson > --- > drivers/rpmsg/rpmsg_core.c | 3 ++- > drivers/rpmsg/rpmsg_internal.h | 11 +++++++++-- > drivers/rpmsg/rpmsg_ns.c | 14 ++++++++++++-- > include/linux/rpmsg.h | 6 ++++-- > 4 files changed, 27 insertions(+), 7 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 79368a957d89..95fc283f6af7 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -400,7 +400,8 @@ field##_store(struct device *dev, struct device_attribute *attr, \ > const char *buf, size_t sz) \ > { \ > struct rpmsg_device *rpdev = to_rpmsg_device(dev); \ > - char *new, *old; \ > + const char *old; \ > + char *new; \ > \ > new = kstrndup(buf, sz, GFP_KERNEL); \ > if (!new) \ > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index d4b23fd019a8..dd1f4ed616b6 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -95,9 +95,16 @@ int rpmsg_release_channel(struct rpmsg_device *rpdev, > static inline int rpmsg_ctrldev_register_device(struct rpmsg_device *rpdev) > { > strcpy(rpdev->id.name, "rpmsg_ctrl"); > - rpdev->driver_override = "rpmsg_ctrl"; > + ret = driver_set_override(&rpdev->dev, &rpdev->driver_override, > + "rpmsg_ctrl", strlen("rpmsg_ctrl")); I made here a mistake while rebasing. This will need a v6. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33BEAC433F5 for ; Thu, 17 Mar 2022 07:04:44 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7B5951900; Thu, 17 Mar 2022 08:03:52 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7B5951900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1647500682; bh=MgO0bpb5ZIiUeLRkUv23h3XJ5Lr/GWqrOxnl60QHGIU=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=f/S742C7nHeVBtDhQON5QvtBFpwS3v5gf5yI21hYuOxJADbXRUDo17jA9Q/Me2bPX nmsTLWHGCBOj1ENrLLk+mzR1SxO7/tbT+HN6VbbKauID1lrRtPcshzY5rk290a1haV mM08Sse+lP6ZG8BbI10U33RGxmiuCPp3snva9raY= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 56B85F805F5; Thu, 17 Mar 2022 07:55:35 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F126F80095; Wed, 16 Mar 2022 20:38:29 +0100 (CET) Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7E83BF80095 for ; Wed, 16 Mar 2022 20:38:20 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7E83BF80095 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=canonical.com header.i=@canonical.com header.b="qsZipiOR" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 6B05E3F5F3 for ; Wed, 16 Mar 2022 19:38:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1647459493; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qsZipiORv/nFk23zk3TB6ijV+rP1RnwVvsblAxN7JTa7UKNvcIIpSQZeStEwJRTNf EtYuJqzoGq8sLvWf5DDEd3THm1iEA/ryQaqR1AmmRcpvqyHHNfZLkkvkL41ExUXecG Wtz1tcFBdnOxadFd2DCXVuH2TFC7/m7d+vlVCGNpY8PUcycZloZw3U7dSe40gsOuBp OWbvjWSYqF99PqGONGin62JK0xf/LyFYf8F3stWMw6/EUSwf7jZcRxKN2Jjj0S/PZx lskY7xlovtPVUo3Jkzu++rCS2OfQ25H2UCHTw5cYcyqpLD6GRhvyLGxj8zidm0EA3K UDk2pXdpdxunA== Received: by mail-wr1-f71.google.com with SMTP id o9-20020adfca09000000b001ea79f7edf8so880898wrh.16 for ; Wed, 16 Mar 2022 12:38:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=6+h9BeibtnFt0Fy4V0bEz+bagkoBJTSRfdm71NC24xs=; b=znoyihkmpxqZ/OvExVz/LLRPdiaeaPgSHZDXtQjgv3lotNo22w7cQS69m7COSLCc0s V3VPPAW8b/U3wqCKE8dn3vRrzdBK1nzuZ0CdQbqc6cDX/RQWwhF7auvKLo4VFnsPdDPI RKgd0TwKD0o73fVIapzh3jxHWbabXqVnCIDtyntNSKgZTV+DDNJMCFNnbLdnNXK8ZpUh KOaTdgrk5x68Xt13doMUkaKVVwDF9/qjFEph234jlcWM0vzH4OCvlgAIZvbxcDIoJVcU o6TWIGIKM3WA86farY3bM7ljNJejS3yXLtvAaJ2HaouA22e8Okno+R34VCRkJ8IeYeEU wfxQ== X-Gm-Message-State: AOAM531vboao95uwxTy9gvgZzA51KPrmAXEXxsijWz+v18VKfM2QaSHI 9DXfiuToq33fhrmczIV+abnZNcXKuB/aqAormL4Lzg4KT49aXC42nsJJGkDs8IhJZz/mmjQTqSB l+PF6b1GjPqRMhA1wgGAkDDqzFBb63oZ1RQ4RzvGt X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045831wmo.104.1647459492728; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwz2q+ZfMVNL/xv6DCH0VHKA2cCReGbKqid/bgaItjng219g1bFLER3WRAwMzoyrwOoAn1bTw== X-Received: by 2002:a05:600c:4796:b0:386:45aa:667b with SMTP id k22-20020a05600c479600b0038645aa667bmr1045789wmo.104.1647459492463; Wed, 16 Mar 2022 12:38:12 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.googlemail.com with ESMTPSA id c7-20020a5d4f07000000b00203db8f13c6sm2300253wru.75.2022.03.16.12.38.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Mar 2022 12:38:11 -0700 (PDT) Message-ID: <0cc4e90d-c5e5-e6a3-6cc6-23d3058b9731@canonical.com> Date: Wed, 16 Mar 2022 20:38:09 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v5 11/11] rpmsg: Fix kfree() of static memory on setting driver_override Content-Language: en-US To: Greg Kroah-Hartman , "Rafael J. Wysocki" References: <20220316150533.421349-1-krzysztof.kozlowski@canonical.com> <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> From: Krzysztof Kozlowski In-Reply-To: <20220316150803.421897-5-krzysztof.kozlowski@canonical.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Thu, 17 Mar 2022 07:55:05 +0100 Cc: linux-hyperv@vger.kernel.org, Stuart Yoder , linux-pci@vger.kernel.org, linux-remoteproc@vger.kernel.org, alsa-devel@alsa-project.org, Peter Oberparleiter , Vineeth Vijayan , Alexander Gordeev , "K. Y. Srinivasan" , linux-clk@vger.kernel.org, linux-s390@vger.kernel.org, Wei Liu , Stephen Hemminger , Dexuan Cui , Andy Shevchenko , Andy Gross , NXP Linux Team , Christian Borntraeger , virtualization@lists.linux-foundation.org, Heiko Carstens , Vasily Gorbik , linux-arm-msm@vger.kernel.org, Haiyang Zhang , Rasmus Villemoes , Bjorn Helgaas , Bjorn Andersson , linux-arm-kernel@lists.infradead.org, Mathieu Poirier , linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-spi@vger.kernel.org, Sven Schnelle , Linus Torvalds X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 16/03/2022 16:08, Krzysztof Kozlowski wrote: > The driver_override field from platform driver should not be initialized > from static memory (string literal) because the core later kfree() it, > for example when driver_override is set via sysfs. > > Use dedicated helper to set driver_override properly. > > Fixes: 950a7388f02b ("rpmsg: Turn name service into a stand alone driver") > Fixes: c0cdc19f84a4 ("rpmsg: Driver for user space endpoint interface") > Cc: > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Bjorn Andersson > --- > drivers/rpmsg/rpmsg_core.c | 3 ++- > drivers/rpmsg/rpmsg_internal.h | 11 +++++++++-- > drivers/rpmsg/rpmsg_ns.c | 14 ++++++++++++-- > include/linux/rpmsg.h | 6 ++++-- > 4 files changed, 27 insertions(+), 7 deletions(-) > > diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c > index 79368a957d89..95fc283f6af7 100644 > --- a/drivers/rpmsg/rpmsg_core.c > +++ b/drivers/rpmsg/rpmsg_core.c > @@ -400,7 +400,8 @@ field##_store(struct device *dev, struct device_attribute *attr, \ > const char *buf, size_t sz) \ > { \ > struct rpmsg_device *rpdev = to_rpmsg_device(dev); \ > - char *new, *old; \ > + const char *old; \ > + char *new; \ > \ > new = kstrndup(buf, sz, GFP_KERNEL); \ > if (!new) \ > diff --git a/drivers/rpmsg/rpmsg_internal.h b/drivers/rpmsg/rpmsg_internal.h > index d4b23fd019a8..dd1f4ed616b6 100644 > --- a/drivers/rpmsg/rpmsg_internal.h > +++ b/drivers/rpmsg/rpmsg_internal.h > @@ -95,9 +95,16 @@ int rpmsg_release_channel(struct rpmsg_device *rpdev, > static inline int rpmsg_ctrldev_register_device(struct rpmsg_device *rpdev) > { > strcpy(rpdev->id.name, "rpmsg_ctrl"); > - rpdev->driver_override = "rpmsg_ctrl"; > + ret = driver_set_override(&rpdev->dev, &rpdev->driver_override, > + "rpmsg_ctrl", strlen("rpmsg_ctrl")); I made here a mistake while rebasing. This will need a v6. Best regards, Krzysztof