From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] package/android-tools: drop musl-compatibility cdefs patching out
Date: Sun, 14 Aug 2016 23:34:08 +0200 [thread overview]
Message-ID: <0cc766e7-d59b-3e2c-bf9e-abba7f6cb94b@mind.be> (raw)
In-Reply-To: <bf528a01457458785591880406b964fcce771ca7.1471033837.git.yann.morin.1998@free.fr>
On 12-08-16 22:49, Yann E. MORIN wrote:
> We now always have a sys/cdefs.h, so we no longer need to patch it out.
>
> Simplify the patch by removing any hunk removing cdefs.h or the use of
> __BEGIN_DECLS/__END_DECLS. However, it must be included when macros it
> defines are being used.
>
> Also, renumber patches to guarantee ordering.
You actually changed the ordering...
0005-fix-big-endian-build.patch
0005-fix-static-link-zlib.patch
->
0005-fix-static-link-zlib.patch
0006-fix-big-endian-build.patch
so I guess the order doesn't matter.
But anyway, after careful review of the patch-in-patch changes:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> .../0004-Fix-build-issue-with-musl.patch | 181 +--------------------
> ...build.patch => 0006-fix-big-endian-build.patch} | 0
> .../0007-include-cdefs-h-when-needed.patch | 41 +++++
> 3 files changed, 43 insertions(+), 179 deletions(-)
> rename package/android-tools/{0005-fix-big-endian-build.patch => 0006-fix-big-endian-build.patch} (100%)
> create mode 100644 package/android-tools/0007-include-cdefs-h-when-needed.patch
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2016-08-14 21:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-12 20:49 [Buildroot] [PATCH 0/8] musl: add compatibility cdefs.h header (branch yem/cdefs) Yann E. MORIN
2016-08-12 20:49 ` [Buildroot] [PATCH 1/8] package/netbsd-compat-headers: provide compatibility headers not in musl Yann E. MORIN
2016-08-12 21:30 ` Khem Raj
2016-08-12 21:39 ` Yann E. MORIN
2016-08-13 2:35 ` Khem Raj
2016-08-14 10:41 ` Baruch Siach
2016-08-14 21:20 ` Arnout Vandecappelle
2016-08-14 21:56 ` Yann E. MORIN
2016-08-12 20:49 ` [Buildroot] [PATCH 2/8] package/rpcbind: include cdefs.h where needed Yann E. MORIN
2016-08-14 21:21 ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 3/8] package/aircrack-ng: drop a musl-compatibility patch Yann E. MORIN
2016-08-14 21:22 ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 4/8] package/android-tools: drop musl-compatibility cdefs patching out Yann E. MORIN
2016-08-14 21:34 ` Arnout Vandecappelle [this message]
2016-08-14 21:57 ` Yann E. MORIN
2016-08-12 20:49 ` [Buildroot] [PATCH 5/8] package/bcusdk: drop a musl-compatibility patch Yann E. MORIN
2016-08-14 21:41 ` Arnout Vandecappelle
2016-08-12 20:49 ` [Buildroot] [PATCH 6/8] package/libsepol: " Yann E. MORIN
2016-08-14 21:48 ` Arnout Vandecappelle
2016-08-12 20:50 ` [Buildroot] [PATCH 7/8] package/linknx: " Yann E. MORIN
2016-08-14 21:49 ` Arnout Vandecappelle
2016-08-12 20:50 ` [Buildroot] [PATCH 8/8] package/qlibc: " Yann E. MORIN
2016-08-14 21:50 ` Arnout Vandecappelle
2016-08-14 21:59 ` [Buildroot] [PATCH 0/8] musl: add compatibility cdefs.h header (branch yem/cdefs) Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc766e7-d59b-3e2c-bf9e-abba7f6cb94b@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.