From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F287C47247 for ; Tue, 5 May 2020 18:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06F63206FA for ; Tue, 5 May 2020 18:32:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="eMfypgiG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728584AbgEEScr (ORCPT ); Tue, 5 May 2020 14:32:47 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:24358 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728292AbgEEScr (ORCPT ); Tue, 5 May 2020 14:32:47 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1588703567; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=kqcch0uCot+4dXsdXDL01hE7tWa5z9rZFO4hj6Mt8EQ=; b=eMfypgiGVUqaMOuDzX8ssGrCeYFVSXL0xiT3QB1UzPJmvteSLeCQYQfyqTDQSAIbQDaRy6sO lck3DaV07S4FzNlV7p7iLDmsur3JmP7Llkp9hS72dDkrKpqvL1FMfjmi5kjkHMuGHAf/iNMr OxGCs4nFCZB58hCKxlin6H3pJBY= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5eb1b14e.7f2b7a552260-smtp-out-n04; Tue, 05 May 2020 18:32:46 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 33B75C432C2; Tue, 5 May 2020 18:32:45 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: rmanohar) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5241C433F2; Tue, 5 May 2020 18:32:44 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 05 May 2020 11:32:44 -0700 From: Rajkumar Manoharan To: Markus Theil Cc: Sven Eckelmann , ath11k@lists.infradead.org, linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> <2335594.cnkAv9Vaq7@bentobox> <1845755.pTfhzBy2qg@bentobox> <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> Message-ID: <0cd75c16a8557a44e9b2c086847941a1@codeaurora.org> X-Sender: rmanohar@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2020-05-05 08:37, Markus Theil wrote: > On 5/5/20 9:49 AM, Sven Eckelmann wrote: >> On Tuesday, 5 May 2020 09:01:34 CEST Sven Eckelmann wrote: >>> On Tuesday, 5 May 2020 01:46:12 CEST Rajkumar Manoharan wrote: >>> [...] >>>> IIRC this was fixed a while ago by below patch. Somehow it never >>>> landed >>>> in ath.git. >>>> Simple one line change is enough. >>>> >>>> https://patchwork.kernel.org/patch/10550707/ >>> Because it doesn't work for everything. Remember that 10.2.4.x >>> overflows all >>> the time (14-30s) because it used only 31 bit for the counters. >>> >>> But feel free to point me to the firmware version which fixed this. >> See also https://patchwork.kernel.org/patch/9701459/ >> >> Kind regards, >> Sven > > This patch already fixes the problem for me. I tested it on QCA988X hw > with firmware 10.2.4. > > [   10.350919] ath10k_pci 0000:04:00.0: qca988x hw2.0 target 0x4100016c > chip_id 0x043222ff sub 0000:0000 > [   10.350930] ath10k_pci 0000:04:00.0: kconfig debug 1 debugfs 1 > tracing 1 dfs 0 testmode 0 > [   10.351803] ath10k_pci 0000:04:00.0: firmware ver 10.2.4-1.0-00047 > api 5 features no-p2p,raw-mode,mfp,allows-mesh-bcast crc32 35bd9258 > [   10.385617] ath10k_pci 0000:04:00.0: board_file api 1 bmi_id N/A > crc32 bebc7c08 > [   11.536818] ath10k_pci 0000:04:00.0: htt-ver 2.1 wmi-op 5 htt-op 2 > cal otp max-sta 128 raw 0 hwcrypto 1 > > I also did not see the 31 bit overflow after a small amount of seconds. > > Survey data from wlp4s0 >     frequency:            2412 MHz [in use] >     noise:                -65 dBm >     channel active time:        5370225 ms >     channel busy time:        924199 ms >     channel receive time:        140 ms >     channel transmit time:        0 ms > Great. Thanks for validating the patch. Venkat will post the patch on ToT. -Rajkumar From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW2N5-000621-Ee for ath11k@lists.infradead.org; Tue, 05 May 2020 18:32:49 +0000 MIME-Version: 1.0 Date: Tue, 05 May 2020 11:32:44 -0700 From: Rajkumar Manoharan Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> <2335594.cnkAv9Vaq7@bentobox> <1845755.pTfhzBy2qg@bentobox> <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> Message-ID: <0cd75c16a8557a44e9b2c086847941a1@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath11k" Errors-To: ath11k-bounces+kvalo=adurom.com@lists.infradead.org To: Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org, Sven Eckelmann T24gMjAyMC0wNS0wNSAwODozNywgTWFya3VzIFRoZWlsIHdyb3RlOgo+IE9uIDUvNS8yMCA5OjQ5 IEFNLCBTdmVuIEVja2VsbWFubiB3cm90ZToKPj4gT24gVHVlc2RheSwgNSBNYXkgMjAyMCAwOTow MTozNCBDRVNUIFN2ZW4gRWNrZWxtYW5uIHdyb3RlOgo+Pj4gT24gVHVlc2RheSwgNSBNYXkgMjAy MCAwMTo0NjoxMiBDRVNUIFJhamt1bWFyIE1hbm9oYXJhbiB3cm90ZToKPj4+IFsuLi5dCj4+Pj4g SUlSQyB0aGlzIHdhcyBmaXhlZCBhIHdoaWxlIGFnbyBieSBiZWxvdyBwYXRjaC4gU29tZWhvdyBp dCBuZXZlciAKPj4+PiBsYW5kZWQKPj4+PiBpbiBhdGguZ2l0Lgo+Pj4+IFNpbXBsZSBvbmUgbGlu ZSBjaGFuZ2UgaXMgZW5vdWdoLgo+Pj4+IAo+Pj4+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5v cmcvcGF0Y2gvMTA1NTA3MDcvCj4+PiBCZWNhdXNlIGl0IGRvZXNuJ3Qgd29yayBmb3IgZXZlcnl0 aGluZy4gUmVtZW1iZXIgdGhhdCAxMC4yLjQueCAKPj4+IG92ZXJmbG93cyBhbGwKPj4+IHRoZSB0 aW1lICgxNC0zMHMpIGJlY2F1c2UgaXQgdXNlZCBvbmx5IDMxIGJpdCBmb3IgdGhlIGNvdW50ZXJz Lgo+Pj4gCj4+PiBCdXQgZmVlbCBmcmVlIHRvIHBvaW50IG1lIHRvIHRoZSBmaXJtd2FyZSB2ZXJz aW9uIHdoaWNoIGZpeGVkIHRoaXMuCj4+IFNlZSBhbHNvIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvOTcwMTQ1OS8KPj4gCj4+IEtpbmQgcmVnYXJkcywKPj4gCVN2ZW4KPiAKPiBU aGlzIHBhdGNoIGFscmVhZHkgZml4ZXMgdGhlIHByb2JsZW0gZm9yIG1lLiBJIHRlc3RlZCBpdCBv biBRQ0E5ODhYIGh3Cj4gd2l0aCBmaXJtd2FyZSAxMC4yLjQuCj4gCj4gW8KgwqAgMTAuMzUwOTE5 XSBhdGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDogcWNhOTg4eCBodzIuMCB0YXJnZXQgMHg0MTAwMDE2 Ywo+IGNoaXBfaWQgMHgwNDMyMjJmZiBzdWIgMDAwMDowMDAwCj4gW8KgwqAgMTAuMzUwOTMwXSBh dGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDoga2NvbmZpZyBkZWJ1ZyAxIGRlYnVnZnMgMQo+IHRyYWNp bmcgMSBkZnMgMCB0ZXN0bW9kZSAwCj4gW8KgwqAgMTAuMzUxODAzXSBhdGgxMGtfcGNpIDAwMDA6 MDQ6MDAuMDogZmlybXdhcmUgdmVyIDEwLjIuNC0xLjAtMDAwNDcKPiBhcGkgNSBmZWF0dXJlcyBu by1wMnAscmF3LW1vZGUsbWZwLGFsbG93cy1tZXNoLWJjYXN0IGNyYzMyIDM1YmQ5MjU4Cj4gW8Kg wqAgMTAuMzg1NjE3XSBhdGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDogYm9hcmRfZmlsZSBhcGkgMSBi bWlfaWQgTi9BCj4gY3JjMzIgYmViYzdjMDgKPiBbwqDCoCAxMS41MzY4MThdIGF0aDEwa19wY2kg MDAwMDowNDowMC4wOiBodHQtdmVyIDIuMSB3bWktb3AgNSBodHQtb3AgMgo+IGNhbCBvdHAgbWF4 LXN0YSAxMjggcmF3IDAgaHdjcnlwdG8gMQo+IAo+IEkgYWxzbyBkaWQgbm90IHNlZSB0aGUgMzEg Yml0IG92ZXJmbG93IGFmdGVyIGEgc21hbGwgYW1vdW50IG9mIHNlY29uZHMuCj4gCj4gU3VydmV5 IGRhdGEgZnJvbSB3bHA0czAKPiDCoMKgwqAgZnJlcXVlbmN5OsKgwqDCoCDCoMKgwqAgwqDCoMKg IDI0MTIgTUh6IFtpbiB1c2VdCj4gwqDCoMKgIG5vaXNlOsKgwqDCoCDCoMKgwqAgwqDCoMKgIMKg wqDCoCAtNjUgZEJtCj4gwqDCoMKgIGNoYW5uZWwgYWN0aXZlIHRpbWU6wqDCoMKgIMKgwqDCoCA1 MzcwMjI1IG1zCj4gwqDCoMKgIGNoYW5uZWwgYnVzeSB0aW1lOsKgwqDCoCDCoMKgwqAgOTI0MTk5 IG1zCj4gwqDCoMKgIGNoYW5uZWwgcmVjZWl2ZSB0aW1lOsKgwqDCoCDCoMKgwqAgMTQwIG1zCj4g wqDCoMKgIGNoYW5uZWwgdHJhbnNtaXQgdGltZTrCoMKgwqAgwqDCoMKgIDAgbXMKPiAKR3JlYXQu IFRoYW5rcyBmb3IgdmFsaWRhdGluZyB0aGUgcGF0Y2guIFZlbmthdCB3aWxsIHBvc3QgdGhlIHBh dGNoIG9uIApUb1QuCgotUmFqa3VtYXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDExayBtYWlsaW5nIGxpc3QKYXRoMTFrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMWsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail27.static.mailgun.info ([104.130.122.27]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jW2N5-00062B-Ef for ath10k@lists.infradead.org; Tue, 05 May 2020 18:32:49 +0000 MIME-Version: 1.0 Date: Tue, 05 May 2020 11:32:44 -0700 From: Rajkumar Manoharan Subject: Re: [PATCH 1/2] ath10k: use cumulative survey statistics In-Reply-To: <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> References: <20200504154122.91862-1-markus.theil@tu-ilmenau.de> <2335594.cnkAv9Vaq7@bentobox> <1845755.pTfhzBy2qg@bentobox> <46ab4ffd-b512-de43-40bb-f35989d228b9@tu-ilmenau.de> Message-ID: <0cd75c16a8557a44e9b2c086847941a1@codeaurora.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Markus Theil Cc: linux-wireless-owner@vger.kernel.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, kvalo@codeaurora.org, ath11k@lists.infradead.org, Sven Eckelmann T24gMjAyMC0wNS0wNSAwODozNywgTWFya3VzIFRoZWlsIHdyb3RlOgo+IE9uIDUvNS8yMCA5OjQ5 IEFNLCBTdmVuIEVja2VsbWFubiB3cm90ZToKPj4gT24gVHVlc2RheSwgNSBNYXkgMjAyMCAwOTow MTozNCBDRVNUIFN2ZW4gRWNrZWxtYW5uIHdyb3RlOgo+Pj4gT24gVHVlc2RheSwgNSBNYXkgMjAy MCAwMTo0NjoxMiBDRVNUIFJhamt1bWFyIE1hbm9oYXJhbiB3cm90ZToKPj4+IFsuLi5dCj4+Pj4g SUlSQyB0aGlzIHdhcyBmaXhlZCBhIHdoaWxlIGFnbyBieSBiZWxvdyBwYXRjaC4gU29tZWhvdyBp dCBuZXZlciAKPj4+PiBsYW5kZWQKPj4+PiBpbiBhdGguZ2l0Lgo+Pj4+IFNpbXBsZSBvbmUgbGlu ZSBjaGFuZ2UgaXMgZW5vdWdoLgo+Pj4+IAo+Pj4+IGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5v cmcvcGF0Y2gvMTA1NTA3MDcvCj4+PiBCZWNhdXNlIGl0IGRvZXNuJ3Qgd29yayBmb3IgZXZlcnl0 aGluZy4gUmVtZW1iZXIgdGhhdCAxMC4yLjQueCAKPj4+IG92ZXJmbG93cyBhbGwKPj4+IHRoZSB0 aW1lICgxNC0zMHMpIGJlY2F1c2UgaXQgdXNlZCBvbmx5IDMxIGJpdCBmb3IgdGhlIGNvdW50ZXJz Lgo+Pj4gCj4+PiBCdXQgZmVlbCBmcmVlIHRvIHBvaW50IG1lIHRvIHRoZSBmaXJtd2FyZSB2ZXJz aW9uIHdoaWNoIGZpeGVkIHRoaXMuCj4+IFNlZSBhbHNvIGh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5l bC5vcmcvcGF0Y2gvOTcwMTQ1OS8KPj4gCj4+IEtpbmQgcmVnYXJkcywKPj4gCVN2ZW4KPiAKPiBU aGlzIHBhdGNoIGFscmVhZHkgZml4ZXMgdGhlIHByb2JsZW0gZm9yIG1lLiBJIHRlc3RlZCBpdCBv biBRQ0E5ODhYIGh3Cj4gd2l0aCBmaXJtd2FyZSAxMC4yLjQuCj4gCj4gW8KgwqAgMTAuMzUwOTE5 XSBhdGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDogcWNhOTg4eCBodzIuMCB0YXJnZXQgMHg0MTAwMDE2 Ywo+IGNoaXBfaWQgMHgwNDMyMjJmZiBzdWIgMDAwMDowMDAwCj4gW8KgwqAgMTAuMzUwOTMwXSBh dGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDoga2NvbmZpZyBkZWJ1ZyAxIGRlYnVnZnMgMQo+IHRyYWNp bmcgMSBkZnMgMCB0ZXN0bW9kZSAwCj4gW8KgwqAgMTAuMzUxODAzXSBhdGgxMGtfcGNpIDAwMDA6 MDQ6MDAuMDogZmlybXdhcmUgdmVyIDEwLjIuNC0xLjAtMDAwNDcKPiBhcGkgNSBmZWF0dXJlcyBu by1wMnAscmF3LW1vZGUsbWZwLGFsbG93cy1tZXNoLWJjYXN0IGNyYzMyIDM1YmQ5MjU4Cj4gW8Kg wqAgMTAuMzg1NjE3XSBhdGgxMGtfcGNpIDAwMDA6MDQ6MDAuMDogYm9hcmRfZmlsZSBhcGkgMSBi bWlfaWQgTi9BCj4gY3JjMzIgYmViYzdjMDgKPiBbwqDCoCAxMS41MzY4MThdIGF0aDEwa19wY2kg MDAwMDowNDowMC4wOiBodHQtdmVyIDIuMSB3bWktb3AgNSBodHQtb3AgMgo+IGNhbCBvdHAgbWF4 LXN0YSAxMjggcmF3IDAgaHdjcnlwdG8gMQo+IAo+IEkgYWxzbyBkaWQgbm90IHNlZSB0aGUgMzEg Yml0IG92ZXJmbG93IGFmdGVyIGEgc21hbGwgYW1vdW50IG9mIHNlY29uZHMuCj4gCj4gU3VydmV5 IGRhdGEgZnJvbSB3bHA0czAKPiDCoMKgwqAgZnJlcXVlbmN5OsKgwqDCoCDCoMKgwqAgwqDCoMKg IDI0MTIgTUh6IFtpbiB1c2VdCj4gwqDCoMKgIG5vaXNlOsKgwqDCoCDCoMKgwqAgwqDCoMKgIMKg wqDCoCAtNjUgZEJtCj4gwqDCoMKgIGNoYW5uZWwgYWN0aXZlIHRpbWU6wqDCoMKgIMKgwqDCoCA1 MzcwMjI1IG1zCj4gwqDCoMKgIGNoYW5uZWwgYnVzeSB0aW1lOsKgwqDCoCDCoMKgwqAgOTI0MTk5 IG1zCj4gwqDCoMKgIGNoYW5uZWwgcmVjZWl2ZSB0aW1lOsKgwqDCoCDCoMKgwqAgMTQwIG1zCj4g wqDCoMKgIGNoYW5uZWwgdHJhbnNtaXQgdGltZTrCoMKgwqAgwqDCoMKgIDAgbXMKPiAKR3JlYXQu IFRoYW5rcyBmb3IgdmFsaWRhdGluZyB0aGUgcGF0Y2guIFZlbmthdCB3aWxsIHBvc3QgdGhlIHBh dGNoIG9uIApUb1QuCgotUmFqa3VtYXIKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBrQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9hdGgxMGsK