From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH 6/6] ASoC: samsung: tm2_wm5510: remove shadowing variable
Date: Mon, 22 Feb 2021 09:36:51 -0600 [thread overview]
Message-ID: <0ce00def-ed9e-3d49-55f2-7abfa3a77e29@linux.intel.com> (raw)
In-Reply-To: <20210221111250.pkklcu26tt5ini2m@kozik-lap>
>> diff --git a/sound/soc/samsung/tm2_wm5110.c b/sound/soc/samsung/tm2_wm5110.c
>> index da6204248f82..b9c17fdd168d 100644
>> --- a/sound/soc/samsung/tm2_wm5110.c
>> +++ b/sound/soc/samsung/tm2_wm5110.c
>> @@ -549,7 +549,6 @@ static int tm2_probe(struct platform_device *pdev)
>> }
>>
>> for (i = 0; i < num_codecs; i++) {
>> - struct of_phandle_args args;
>
> I would prefer to have them more local, so:
> 1. Remove args in tm2_probe() scope.
> 2. Add args around line 588 in "if (num_codecs > 1) {" block.
Will change this in a v2.
next prev parent reply other threads:[~2021-02-22 16:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-19 23:09 [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Pierre-Louis Bossart
2021-02-19 23:09 ` [PATCH 1/6] ASoC: samsung: i2s: remove unassigned variable Pierre-Louis Bossart
2021-02-21 10:53 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 2/6] ASoC: samsung: s3c24xx_simtec: add missing error check Pierre-Louis Bossart
2021-02-21 10:55 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 3/6] ASoC: samsung: smdk_wm8994: add missing return Pierre-Louis Bossart
2021-02-21 10:59 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 4/6] ASoC: samsung: snow: remove useless test Pierre-Louis Bossart
2021-02-21 11:04 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 5/6] ASoC: samsung: tm2_wm5110: check of_parse return value Pierre-Louis Bossart
2021-02-21 11:10 ` Krzysztof Kozlowski
2021-02-22 15:35 ` Pierre-Louis Bossart
2021-02-22 17:28 ` Krzysztof Kozlowski
2021-02-19 23:09 ` [PATCH 6/6] ASoC: samsung: tm2_wm5510: remove shadowing variable Pierre-Louis Bossart
2021-02-21 11:12 ` Krzysztof Kozlowski
2021-02-22 15:36 ` Pierre-Louis Bossart [this message]
2021-02-23 11:30 ` Sylwester Nawrocki
2021-02-22 16:07 ` (subset) [PATCH 0/6] ASoC: samsung: remove cppcheck warnings Mark Brown
2021-02-22 17:31 ` Krzysztof Kozlowski
2021-02-22 20:19 ` Mark Brown
2021-02-22 20:39 ` Pierre-Louis Bossart
2021-03-01 23:34 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ce00def-ed9e-3d49-55f2-7abfa3a77e29@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=krzk@kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.