From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FD29C433F5 for ; Sat, 1 Jan 2022 23:58:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232802AbiAAX6K (ORCPT ); Sat, 1 Jan 2022 18:58:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232731AbiAAX6K (ORCPT ); Sat, 1 Jan 2022 18:58:10 -0500 Received: from mail-lf1-x135.google.com (mail-lf1-x135.google.com [IPv6:2a00:1450:4864:20::135]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5635C061574 for ; Sat, 1 Jan 2022 15:58:09 -0800 (PST) Received: by mail-lf1-x135.google.com with SMTP id h7so22732499lfu.4 for ; Sat, 01 Jan 2022 15:58:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=1xfSrao1qqheTJwJwU9aUGlBlvtY13o85ITWyfdgess=; b=IPXEJ426bgkxPzfMKKwysB+bpS5jWN/DNyoV20IqlpvKflB9CwvDa2sAUd4++Q5jja u3p94gHorUEv3XfpzIlPKrNyCmrJalTKKfHHitueXijQKZSo+ygNgNA3wEA4rkmdrkxr z3aah7Ll/eW8uJpMEpBD1HCIAIeyEnFfuSEvDW8fXuqxAIh1PZzrvtNDo38f3X6GDAMS Lwbp5XJnP/Z4sxDfuJbxvaGOFI31xZFTch+EAfutHvxdJ5NHJPfYEmJjGKFjB4FWaWic Y/7NDz522Kh3F41u+2Tpma6SxJ8sx/44D92QvG6YvmHavqgf8NVj9OmdR4tHIYHnZrK/ 3Gig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=1xfSrao1qqheTJwJwU9aUGlBlvtY13o85ITWyfdgess=; b=d1uk/u67siKUIunfgkgbbyfyCXM1aVcy10Bqr3KvE3KpmUmSmc0TAywKy81lnRn6L8 lUuXZem8AkHt0dIOJj9NLDvMI5P1lTkOlb2CKrki8VEUK6BUkP/M6mM7h1VRgjxSQZcO jJDJlRChSsfq/XgaB8GJpIUWIxw7PtlUJUjlRnIx/q10489JOgTiABJf9TRI7eaECKIL nm4BzJFaeUinFRQEOzPUrSqGvctR1/Xw7yG1OMtGB26Z7+k1BpAca3YMLLjwjdDlFgD/ oVVrdENkoxX5yY1HOJEbDr5UpvPjCEhaD9LCHpQRXaHcmnfWJaZ4mSEFIunk0ZjILnId eaRA== X-Gm-Message-State: AOAM533PYT5q+sDJITvm60DQgAtshXANMlMSqVHeO3VUZ9B/JVTbOfz1 4lhpmo3ks4LDSmBvaANkLHc= X-Google-Smtp-Source: ABdhPJw1lm6nEcdlRHeccYW4UdcB5KvuGKEUsO94lWuM+ImaEhaYJ69RtKxeJevjvldJWQINr+4SaA== X-Received: by 2002:a19:c217:: with SMTP id l23mr35516648lfc.599.1641081487547; Sat, 01 Jan 2022 15:58:07 -0800 (PST) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id p14sm3174365ljj.12.2022.01.01.15.58.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jan 2022 15:58:07 -0800 (PST) Message-ID: <0ce1b7cb-ae08-65fc-0e2e-1f58ebac7937@gmail.com> Date: Sun, 2 Jan 2022 00:58:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const To: Marcel Ziswiler , "abel.vesa@nxp.com" , "linus.walleij@linaro.org" Cc: "stefan@agner.ch" , "kernel@pengutronix.de" , "linux-imx@nxp.com" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-gpio@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lakshmi.sowjanya.d@intel.com" , "aisheng.dong@nxp.com" , "rafal@milecki.pl" References: <20211216162206.8027-1-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On 2.01.2022 00:55, Marcel Ziswiler wrote: > On Wed, 2021-12-22 at 22:24 +0200, Abel Vesa wrote: >>> @@ -663,14 +664,16 @@ static int imx_pinctrl_parse_functions(struct device_node *np, >>>                 dev_err(ipctl->dev, "no groups defined in %pOF\n", np); >>>                 return -EINVAL; >>>         } >>> -       func->group_names = devm_kcalloc(ipctl->dev, func->num_group_names, >>> -                                        sizeof(char *), GFP_KERNEL); >>> + >>> +       group_names = devm_kcalloc(ipctl->dev, func->num_group_names, >>> +                                  sizeof(char *), GFP_KERNEL); >>>         if (!func->group_names) >> This line needs to be: >>         if (!group_names) >> >> Otherwise, the driver never probes successufully. > > After my i.MX 8M Mini target running latest -next just hang early boot I bisected it to this commit. > > I can confirm that this fixes it. Thanks! Please note there is one more pending fix. Please apply both: [PATCH] pinctrl: imx: fix allocation result check [PATCH] pinctrl: imx: fix assigning groups names From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 97C15C433EF for ; Sat, 1 Jan 2022 23:59:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RigLhIGcx/OSCHdOp48iYngmJlZKnpQ/505EbCjaK4s=; b=G3dFG2FCHF3vxG WTfWsiteIAUs9TCjD3QK1G860ppwQgNwmvTgPBjFlH2SwAYJGtHQD4joicieXaS2pOwUaTGnQm5Ly CNgMbcUAuE2RDnVQEn5JEzXF7Wat0fVbZFlwPLgJychAGzLONE5p53aN+H6kuhaTPNbUgY1IJ6Lxx rBxy/6AZVscFcmQa+Cra1MAIpYSzBB52I56Y7kOAhoe6SXQOi68xm3qbHBWtjmrPaOAKpQRA9TEcu +R/ec5o0oJl8tPs9kNpDzTHQDMm+myNjdHPZ6VkeWNKAyO2jCUmXN7gR04PYZzsePQx44Fsoq4Tl7 J2bpzbYvnafegD0gkkEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3oGL-007Rtd-B6; Sat, 01 Jan 2022 23:58:13 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1n3oGI-007Rt6-2I for linux-arm-kernel@lists.infradead.org; Sat, 01 Jan 2022 23:58:11 +0000 Received: by mail-lf1-x12f.google.com with SMTP id p13so31013938lfh.13 for ; Sat, 01 Jan 2022 15:58:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:to:cc:references :from:in-reply-to:content-transfer-encoding; bh=1xfSrao1qqheTJwJwU9aUGlBlvtY13o85ITWyfdgess=; b=IPXEJ426bgkxPzfMKKwysB+bpS5jWN/DNyoV20IqlpvKflB9CwvDa2sAUd4++Q5jja u3p94gHorUEv3XfpzIlPKrNyCmrJalTKKfHHitueXijQKZSo+ygNgNA3wEA4rkmdrkxr z3aah7Ll/eW8uJpMEpBD1HCIAIeyEnFfuSEvDW8fXuqxAIh1PZzrvtNDo38f3X6GDAMS Lwbp5XJnP/Z4sxDfuJbxvaGOFI31xZFTch+EAfutHvxdJ5NHJPfYEmJjGKFjB4FWaWic Y/7NDz522Kh3F41u+2Tpma6SxJ8sx/44D92QvG6YvmHavqgf8NVj9OmdR4tHIYHnZrK/ 3Gig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :to:cc:references:from:in-reply-to:content-transfer-encoding; bh=1xfSrao1qqheTJwJwU9aUGlBlvtY13o85ITWyfdgess=; b=W+cAiSyQza7jvCLU6VcUC930jt82HPCCYBOKGoneXjB9rjrcwFZBf3ctxweCTlCVnQ J0cvspXu25ZiuERsiy7opwD/jOFZlf7IvsWBhwW5FsCTwQ1RAtbnkCDkRRIu86UjWKMV BNsrgSiYEqcV0go/RtnsxjrvL34vuIsHBxRHGEisr1p3OEH0bnMRJw27druZYlCkN0N6 cJ42IcA24lZ/AYZSBub9dSypGcnnyw3KsyebQpnmMPcmPlAM4UyGZ8EX4KE+rg7RNyCF xouarwSlbxZjme+yVkSEiH5yttAaOiFu3/hMFAy34OosbFiS9abjzjiXLe8LFlu+PEB3 wHCA== X-Gm-Message-State: AOAM530m8vM+FFmwkE/D9a6jYQe6F77iz4QmtqArvvBEQ0nQl0CS6QA0 D/6mzyFVBSYZ+8Ybp6lqYZM= X-Google-Smtp-Source: ABdhPJw1lm6nEcdlRHeccYW4UdcB5KvuGKEUsO94lWuM+ImaEhaYJ69RtKxeJevjvldJWQINr+4SaA== X-Received: by 2002:a19:c217:: with SMTP id l23mr35516648lfc.599.1641081487547; Sat, 01 Jan 2022 15:58:07 -0800 (PST) Received: from [192.168.26.149] (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id p14sm3174365ljj.12.2022.01.01.15.58.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Jan 2022 15:58:07 -0800 (PST) Message-ID: <0ce1b7cb-ae08-65fc-0e2e-1f58ebac7937@gmail.com> Date: Sun, 2 Jan 2022 00:58:06 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:96.0) Gecko/20100101 Thunderbird/96.0 Subject: Re: [PATCH V2 1/4] pinctrl: imx: prepare for making "group_names" in "function_desc" const To: Marcel Ziswiler , "abel.vesa@nxp.com" , "linus.walleij@linaro.org" Cc: "stefan@agner.ch" , "kernel@pengutronix.de" , "linux-imx@nxp.com" , "festevam@gmail.com" , "s.hauer@pengutronix.de" , "linux-gpio@vger.kernel.org" , "shawnguo@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "lakshmi.sowjanya.d@intel.com" , "aisheng.dong@nxp.com" , "rafal@milecki.pl" References: <20211216162206.8027-1-zajec5@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220101_155810_148470_94BDBC67 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMi4wMS4yMDIyIDAwOjU1LCBNYXJjZWwgWmlzd2lsZXIgd3JvdGU6Cj4gT24gV2VkLCAyMDIx LTEyLTIyIGF0IDIyOjI0ICswMjAwLCBBYmVsIFZlc2Egd3JvdGU6Cj4+PiBAQCAtNjYzLDE0ICs2 NjQsMTYgQEAgc3RhdGljIGludCBpbXhfcGluY3RybF9wYXJzZV9mdW5jdGlvbnMoc3RydWN0IGRl dmljZV9ub2RlICpucCwKPj4+ICDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGRldl9l cnIoaXBjdGwtPmRldiwgIm5vIGdyb3VwcyBkZWZpbmVkIGluICVwT0ZcbiIsIG5wKTsKPj4+ICDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHJldHVybiAtRUlOVkFMOwo+Pj4gIMKgwqDC oMKgwqDCoMKgwqB9Cj4+PiAtwqDCoMKgwqDCoMKgwqBmdW5jLT5ncm91cF9uYW1lcyA9IGRldm1f a2NhbGxvYyhpcGN0bC0+ZGV2LCBmdW5jLT5udW1fZ3JvdXBfbmFtZXMsCj4+PiAtwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIHNpemVvZihjaGFyICopLCBHRlBfS0VSTkVMKTsKPj4+ICsKPj4+ICvCoMKg wqDCoMKgwqDCoGdyb3VwX25hbWVzID0gZGV2bV9rY2FsbG9jKGlwY3RsLT5kZXYsIGZ1bmMtPm51 bV9ncm91cF9uYW1lcywKPj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc2l6ZW9mKGNoYXIgKiksIEdGUF9LRVJORUwp Owo+Pj4gIMKgwqDCoMKgwqDCoMKgwqBpZiAoIWZ1bmMtPmdyb3VwX25hbWVzKQo+PiBUaGlzIGxp bmUgbmVlZHMgdG8gYmU6Cj4+ICDCoMKgwqDCoMKgwqDCoMKgaWYgKCFncm91cF9uYW1lcykKPj4K Pj4gT3RoZXJ3aXNlLCB0aGUgZHJpdmVyIG5ldmVyIHByb2JlcyBzdWNjZXNzdWZ1bGx5Lgo+IAo+ IEFmdGVyIG15IGkuTVggOE0gTWluaSB0YXJnZXQgcnVubmluZyBsYXRlc3QgLW5leHQganVzdCBo YW5nIGVhcmx5IGJvb3QgSSBiaXNlY3RlZCBpdCB0byB0aGlzIGNvbW1pdC4KPiAKPiBJIGNhbiBj b25maXJtIHRoYXQgdGhpcyBmaXhlcyBpdC4gVGhhbmtzIQoKUGxlYXNlIG5vdGUgdGhlcmUgaXMg b25lIG1vcmUgcGVuZGluZyBmaXguIFBsZWFzZSBhcHBseSBib3RoOgpbUEFUQ0hdIHBpbmN0cmw6 IGlteDogZml4IGFsbG9jYXRpb24gcmVzdWx0IGNoZWNrCltQQVRDSF0gcGluY3RybDogaW14OiBm aXggYXNzaWduaW5nIGdyb3VwcyBuYW1lcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJt LWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21h aWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=