From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758262AbcJYBNE (ORCPT ); Mon, 24 Oct 2016 21:13:04 -0400 Received: from vern.gendns.com ([206.190.152.46]:48415 "EHLO vern.gendns.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756439AbcJYBNC (ORCPT ); Mon, 24 Oct 2016 21:13:02 -0400 Subject: Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals To: ahaslam@baylibre.com, gregkh@linuxfoundation.org, johan@kernel.org, robh+dt@kernel.org, nsekhar@ti.com, stern@rowland.harvard.edu, khilman@baylibre.com, sshtylyov@ru.mvista.com, broonie@kernel.org, abailon@baylibre.com References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-14-ahaslam@baylibre.com> Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: David Lechner Message-ID: <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> Date: Mon, 24 Oct 2016 20:12:59 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161024164634.4330-14-ahaslam@baylibre.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vern.gendns.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lechnology.com X-Get-Message-Sender-Via: vern.gendns.com: authenticated_id: davidmain+lechnology.com/only user confirmed/virtual account not confirmed X-Authenticated-Sender: vern.gendns.com: davidmain@lechnology.com X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2016 11:46 AM, ahaslam@baylibre.com wrote: > From: Axel Haslam > > static const struct ohci_driver_overrides da8xx_overrides __initconst = { > - .reset = ohci_da8xx_reset > + .reset = ohci_da8xx_reset, > + .extra_priv_size = sizeof(struct da8xx_ohci_hcd), nit: since you are changing both lines anyway, you might as well make the ='s line up. > }; > > /* > From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Lechner Subject: Re: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals Date: Mon, 24 Oct 2016 20:12:59 -0500 Message-ID: <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-14-ahaslam@baylibre.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20161024164634.4330-14-ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org, stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, sshtylyov-hkdhdckH98+B+jHODAdFcQ@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org Cc: linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 10/24/2016 11:46 AM, ahaslam-rdvid1DuHRBWk0Htik3J/w@public.gmane.org wrote: > From: Axel Haslam > > static const struct ohci_driver_overrides da8xx_overrides __initconst = { > - .reset = ohci_da8xx_reset > + .reset = ohci_da8xx_reset, > + .extra_priv_size = sizeof(struct da8xx_ohci_hcd), nit: since you are changing both lines anyway, you might as well make the ='s line up. > }; > > /* > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: david@lechnology.com (David Lechner) Date: Mon, 24 Oct 2016 20:12:59 -0500 Subject: [PATCH/RFT v2 13/17] USB: da8xx: use ohci priv data instead of globals In-Reply-To: <20161024164634.4330-14-ahaslam@baylibre.com> References: <20161024164634.4330-1-ahaslam@baylibre.com> <20161024164634.4330-14-ahaslam@baylibre.com> Message-ID: <0cf6f211-90ba-2f7b-978f-f1cfa1b11554@lechnology.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/24/2016 11:46 AM, ahaslam at baylibre.com wrote: > From: Axel Haslam > > static const struct ohci_driver_overrides da8xx_overrides __initconst = { > - .reset = ohci_da8xx_reset > + .reset = ohci_da8xx_reset, > + .extra_priv_size = sizeof(struct da8xx_ohci_hcd), nit: since you are changing both lines anyway, you might as well make the ='s line up. > }; > > /* >