From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 815D7C54FD0 for ; Mon, 20 Apr 2020 17:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C0A7207FC for ; Mon, 20 Apr 2020 17:30:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgDTRal (ORCPT ); Mon, 20 Apr 2020 13:30:41 -0400 Received: from smtprelay0214.hostedemail.com ([216.40.44.214]:39548 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726396AbgDTRaj (ORCPT ); Mon, 20 Apr 2020 13:30:39 -0400 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id CD7071802EC18; Mon, 20 Apr 2020 17:30:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wire77_794acccb34a52 X-Filterd-Recvd-Size: 2900 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Mon, 20 Apr 2020 17:30:33 +0000 (UTC) Message-ID: <0cff04825062a6e4b04a19cac80152b9943402b1.camel@perches.com> Subject: Re: [PATCHv3 01/50] kallsyms/printk: Add loglvl to print_ip_sym() From: Joe Perches To: Dmitry Safonov , linux-kernel@vger.kernel.org Cc: Dmitry Safonov <0x7f454c46@gmail.com>, Andrew Morton , Greg Kroah-Hartman , Ingo Molnar , Jiri Slaby , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Tetsuo Handa , Albert Ou , Ben Segall , Dietmar Eggemann , Greentime Hu , Ingo Molnar , James Hogan , Juri Lelli , Mel Gorman , Michal Simek , Palmer Dabbelt , Paul Burton , Paul Walmsley , Peter Zijlstra , Ralf Baechle , Thomas Gleixner , Vincent Chen , Vincent Guittot , Will Deacon , linux-mips@vger.kernel.org, linux-riscv@lists.infradead.org Date: Mon, 20 Apr 2020 10:28:17 -0700 In-Reply-To: <7616c5f4-def1-7362-ceef-db76107b9c2b@arista.com> References: <20200418201944.482088-1-dima@arista.com> <20200418201944.482088-2-dima@arista.com> <24a1f021e52ccabfd53baa22b93947ef10e6bf3b.camel@perches.com> <7616c5f4-def1-7362-ceef-db76107b9c2b@arista.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-04-20 at 18:25 +0100, Dmitry Safonov wrote: > Hi Joe, Hi Dmitry. > On 4/18/20 9:40 PM, Joe Perches wrote: > > On Sat, 2020-04-18 at 21:18 +0100, Dmitry Safonov wrote: > > > print_ip_sym() needs to have a log level parameter to comply with other > > > parts being printed. Otherwise, half of the expected backtrace would be > > > printed and other may be missing with some logging level. > > > > I'd rather create another extension to %ps that also emits > > the [
] along with the symbol lookup and retire > > print_ip_sym altogether. > > Makes sense. > Would you mind if I'll do it on the top of these patches? > [not to mix new printk-format with patches those add loglvl parameter] Of course not, but the proposal below doesn't compile and I've been playing with a slightly different implementation. I'll post it in a few days. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 191B2C3815B for ; Mon, 20 Apr 2020 17:30:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E233320782 for ; Mon, 20 Apr 2020 17:30:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UoSmlGqI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E233320782 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=perches.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8MswZOiyN5SsXP5ZkfJgUx+uPyPLybSx80K2hcHMS1A=; b=UoSmlGqIoO2xA5 Qf8EgeATb6B8V+ngWDTAO7UDUYO79pBOkpm0qdnhPm+tETUHCQYSSxC/f/r2TPpOQNM1MoZ2VEAD/ PGDdL7/59mGvSlp1pu2c8UcPzKCxQCtDZxWLY0hriOukYJY7iGcuZx3D04HGHkKCMEthc9hoTWpvm TIMJON1WS48vBnIbutqswOhHP30J65YvHgqlk1ZMQ9Ro+IFBTW/fuLFALI0GSrzf1VQFU6g7kx3oV NJM4yN6YaWfTYWFpOd0buqimMhIdoqSKCFn5VJs/OsXYUuxIDrhW6iAerAZ3xp7Y6n0Esc3ahAChk KjTSc6WI5kO6izShfmEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQaFs-0004IV-KC; Mon, 20 Apr 2020 17:30:48 +0000 Received: from smtprelay0200.hostedemail.com ([216.40.44.200] helo=smtprelay.hostedemail.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQaFp-0004Gu-S7 for linux-riscv@lists.infradead.org; Mon, 20 Apr 2020 17:30:47 +0000 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay05.hostedemail.com (Postfix) with ESMTP id CD7071802EC18; Mon, 20 Apr 2020 17:30:37 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: wire77_794acccb34a52 X-Filterd-Recvd-Size: 2900 Received: from XPS-9350.home (unknown [47.151.136.130]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Mon, 20 Apr 2020 17:30:33 +0000 (UTC) Message-ID: <0cff04825062a6e4b04a19cac80152b9943402b1.camel@perches.com> Subject: Re: [PATCHv3 01/50] kallsyms/printk: Add loglvl to print_ip_sym() From: Joe Perches To: Dmitry Safonov , linux-kernel@vger.kernel.org Date: Mon, 20 Apr 2020 10:28:17 -0700 In-Reply-To: <7616c5f4-def1-7362-ceef-db76107b9c2b@arista.com> References: <20200418201944.482088-1-dima@arista.com> <20200418201944.482088-2-dima@arista.com> <24a1f021e52ccabfd53baa22b93947ef10e6bf3b.camel@perches.com> <7616c5f4-def1-7362-ceef-db76107b9c2b@arista.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_103045_968956_7A7C97D6 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Juri Lelli , Tetsuo Handa , James Hogan , Dmitry Safonov <0x7f454c46@gmail.com>, Ben Segall , linux-riscv@lists.infradead.org, Vincent Chen , Will Deacon , Ingo Molnar , Vincent Guittot , Paul Burton , Peter Zijlstra , Ingo Molnar , Mel Gorman , Jiri Slaby , Petr Mladek , Albert Ou , Steven Rostedt , Greentime Hu , Paul Walmsley , Thomas Gleixner , Dietmar Eggemann , Michal Simek , Greg Kroah-Hartman , linux-mips@vger.kernel.org, Ralf Baechle , Sergey Senozhatsky , Palmer Dabbelt , Andrew Morton Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, 2020-04-20 at 18:25 +0100, Dmitry Safonov wrote: > Hi Joe, Hi Dmitry. > On 4/18/20 9:40 PM, Joe Perches wrote: > > On Sat, 2020-04-18 at 21:18 +0100, Dmitry Safonov wrote: > > > print_ip_sym() needs to have a log level parameter to comply with other > > > parts being printed. Otherwise, half of the expected backtrace would be > > > printed and other may be missing with some logging level. > > > > I'd rather create another extension to %ps that also emits > > the [
] along with the symbol lookup and retire > > print_ip_sym altogether. > > Makes sense. > Would you mind if I'll do it on the top of these patches? > [not to mix new printk-format with patches those add loglvl parameter] Of course not, but the proposal below doesn't compile and I've been playing with a slightly different implementation. I'll post it in a few days.