From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41A3AC47086 for ; Tue, 25 May 2021 20:12:18 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6E7B61157 for ; Tue, 25 May 2021 20:12:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6E7B61157 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:57032 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lldPU-0003G8-MC for qemu-devel@archiver.kernel.org; Tue, 25 May 2021 16:12:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44430) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldOV-00029X-IN for qemu-devel@nongnu.org; Tue, 25 May 2021 16:11:15 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:36097) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lldOS-0005Yg-5V for qemu-devel@nongnu.org; Tue, 25 May 2021 16:11:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621973470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZqSvmDIZmECssVJpX0Q6Yp4UgcheCZ+p5Uxb9ejdyVE=; b=JjTr/g1WaJ9ANkwYrM0o3pgrH7QbsD5893OmHye0T/YQxkIlihG9bwaadKQ7KbrnI1shNk GX8mgCh9JaDxFbwmZjmpnAKIllzUoZ8V48UsBf0PsDf1/GXoaG8+ddETWaI6Ih7lSiV2Jm x2MAHNqlxE6kvsjZaIT9KAOp4HOb3Xs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-483-Vl9c8LwaPkyQ42qqB4kf4A-1; Tue, 25 May 2021 16:11:06 -0400 X-MC-Unique: Vl9c8LwaPkyQ42qqB4kf4A-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E4C264167; Tue, 25 May 2021 20:11:05 +0000 (UTC) Received: from [10.10.116.137] (ovpn-116-137.rdu2.redhat.com [10.10.116.137]) by smtp.corp.redhat.com (Postfix) with ESMTP id 811805D9C0; Tue, 25 May 2021 20:10:55 +0000 (UTC) Subject: Re: [PATCH v6 23/25] python: add .gitignore To: Cleber Rosa References: <20210512231241.2816122-1-jsnow@redhat.com> <20210512231241.2816122-24-jsnow@redhat.com> From: John Snow Message-ID: <0d0053ab-4410-e905-7261-332f21fd8852@redhat.com> Date: Tue, 25 May 2021 16:10:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jsnow@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=216.205.24.124; envelope-from=jsnow@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.371, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Fam Zheng , Thomas Huth , Eduardo Habkost , qemu-block@nongnu.org, =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org, Wainer dos Santos Moschetta , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Willian Rampazzo , Willian Rampazzo , Max Reitz , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Beraldo Leal Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 5/25/21 3:36 PM, Cleber Rosa wrote: > On Wed, May 12, 2021 at 07:12:39PM -0400, John Snow wrote: >> Ignore *Python* build and package output (build, dist, qemu.egg-info); >> these files are not created as part of a QEMU build. >> >> Ignore miscellaneous cached python confetti (__pycache__, *.pyc, >> .mypy_cache). >> >> Ignore .idea (pycharm) .vscode, and .venv (pipenv et al). >> >> Signed-off-by: John Snow >> --- >> python/.gitignore | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 python/.gitignore >> >> diff --git a/python/.gitignore b/python/.gitignore >> new file mode 100644 >> index 00000000000..e27c99e009c >> --- /dev/null >> +++ b/python/.gitignore >> @@ -0,0 +1,19 @@ >> +# python bytecode cache >> +*.pyc > > This is a duplicate from the parent .gitignore, so I would avoid it. > >> +__pycache__/ > > And this one is interesting because, the only thing that *should* be > in __pycache__ dirs is .pyc files (covered by the parent .gitignore > file). > > So, I get the same behavior without these two entries here, so I would > skip them. Let me know if you have any reason for explicitly > including them. > > - Cleber. > Hm, not really ... Just completeness, I suppose, since this directory is becoming increasingly separate from the rest of the tree. It isn't crucial, it just seemed like a weird omission if they weren't listed here. *shrug* --js