From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12EBAC4332D for ; Fri, 20 Mar 2020 03:21:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E332020709 for ; Fri, 20 Mar 2020 03:21:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbgCTDVT (ORCPT ); Thu, 19 Mar 2020 23:21:19 -0400 Received: from mga09.intel.com ([134.134.136.24]:24463 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726103AbgCTDVT (ORCPT ); Thu, 19 Mar 2020 23:21:19 -0400 IronPort-SDR: mBhsYZVjZNSQZ8UTmCAti8ZmW8sK8JOm8Spi8EBLW5GYLi8/QNgeYixqdqXtMrUDdnIOavvhET mkR2owc0Tbiw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 20:21:19 -0700 IronPort-SDR: mR03DYeqvkIQcgn0WcWd2qJ7otYBW15lrJjlF8zdd6PSU699Wr5FRC2o0WZ3rL9yRLtxxBUDjJ ut+0mQv3w5ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="324731214" Received: from jliu231-mobl1.ccr.corp.intel.com (HELO [10.254.208.65]) ([10.254.208.65]) by orsmga001.jf.intel.com with ESMTP; 19 Mar 2020 20:21:16 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Mark Brown , Pierre-Louis Bossart Cc: Dominik Brodowski , Cezary Rojewski , kuninori.morimoto.gx@renesas.com, alsa-devel@alsa-project.org, curtis@malainey.com, linux-kernel@vger.kernel.org, tiwai@suse.com, liam.r.girdwood@linux.intel.com References: <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> <20200319165157.GA2254@light.dominikbrodowski.net> <20200319173502.GC3983@sirena.org.uk> From: Keyon Jie Message-ID: <0d01b2ce-9531-1a08-e632-4608ab894fbe@linux.intel.com> Date: Fri, 20 Mar 2020 11:21:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200319173502.GC3983@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/20/20 1:35 AM, Mark Brown wrote: > On Thu, Mar 19, 2020 at 12:21:47PM -0500, Pierre-Louis Bossart wrote: >> On 3/19/20 11:51 AM, Dominik Brodowski wrote: > >>> That patch fixes the issue(s). I didn't even need to revert 64df6afa0dab >>> ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF") >>> on top of that. But you can assess better whether that patch needs care for >>> other reasons; for me, this one-liner you have suggested is perfect. > > Good news! > >> .ignore_suspend is set for bdw-rt5677.c and bdw-rt5650.c as well. I don't >> know if that was intentional. > > The intended use case is for applications doing audio during suspend > like telephony audio between the modem and CODEC on a phone or > compressed audio playback. I guess the compressed audio playback case > could possibly apply with these systems though x86 suspend/resume is > usually sufficiently heavyweight that it's surprising. I think that's true, on many of SKL- intel platforms(byt, hsw, bdw), we are seeing this .ignore_suspend set with offload or deep buffer FE dai_links configured together. So it looks we can't ignore calling codec's suspend/resume callbacks during the power cycle for rt286 codec(on the Dell XPS here), which is actually supported on Chromebook SAMUS(rt5677)? Thanks, ~Keyon > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC8FBC4332D for ; Fri, 20 Mar 2020 03:22:22 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4695C20709 for ; Fri, 20 Mar 2020 03:22:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="JsLr7Lp2" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4695C20709 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 7AC8317B1; Fri, 20 Mar 2020 04:21:30 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 7AC8317B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1584674540; bh=P+FjRK2wXx/zGqnWUz4J8BzKVLQR19Evv1TIJT/tL0I=; h=Subject:To:References:From:Date:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=JsLr7Lp2jk16BF2mDuEDsH5GVmGHQ2gxYnDNvbWtTsps82vPxIugLhW+NA5Q79S70 GZ4b5IlEo8tnu89hCAq2J+HDwB1bk9iURAatD11algu4ZfKhO5czPnexSJNlK6tPP1 lNVe3JmFkluQz4ogQDt4VaLWgxvsBEGru5XYfA3Y= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id D2C81F80139; Fri, 20 Mar 2020 04:21:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B169EF8015B; Fri, 20 Mar 2020 04:21:26 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 41914F800C0 for ; Fri, 20 Mar 2020 04:21:22 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 41914F800C0 IronPort-SDR: 6QRANaKpFGL40cQHjR0lLkNJEnXmNDfMXG/6Bpqqet4VIYynrvn3hg4u79z6wylZAlj632xDGw CZ3HDnegSTBw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2020 20:21:19 -0700 IronPort-SDR: mR03DYeqvkIQcgn0WcWd2qJ7otYBW15lrJjlF8zdd6PSU699Wr5FRC2o0WZ3rL9yRLtxxBUDjJ ut+0mQv3w5ng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,283,1580803200"; d="scan'208";a="324731214" Received: from jliu231-mobl1.ccr.corp.intel.com (HELO [10.254.208.65]) ([10.254.208.65]) by orsmga001.jf.intel.com with ESMTP; 19 Mar 2020 20:21:16 -0700 Subject: Re: snd_hda_intel/sst-acpi sound breakage on suspend/resume since 5.6-rc1 To: Mark Brown , Pierre-Louis Bossart References: <20200318192213.GA2987@light.dominikbrodowski.net> <20200318215218.GA2439@light.dominikbrodowski.net> <20200319130049.GA2244@light.dominikbrodowski.net> <20200319134139.GB3983@sirena.org.uk> <20200319165157.GA2254@light.dominikbrodowski.net> <20200319173502.GC3983@sirena.org.uk> From: Keyon Jie Message-ID: <0d01b2ce-9531-1a08-e632-4608ab894fbe@linux.intel.com> Date: Fri, 20 Mar 2020 11:21:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200319173502.GC3983@sirena.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Cc: Cezary Rojewski , kuninori.morimoto.gx@renesas.com, curtis@malainey.com, tiwai@suse.com, alsa-devel@alsa-project.org, Dominik Brodowski , linux-kernel@vger.kernel.org, liam.r.girdwood@linux.intel.com X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" On 3/20/20 1:35 AM, Mark Brown wrote: > On Thu, Mar 19, 2020 at 12:21:47PM -0500, Pierre-Louis Bossart wrote: >> On 3/19/20 11:51 AM, Dominik Brodowski wrote: > >>> That patch fixes the issue(s). I didn't even need to revert 64df6afa0dab >>> ("ASoC: Intel: broadwell: change cpu_dai and platform components for SOF") >>> on top of that. But you can assess better whether that patch needs care for >>> other reasons; for me, this one-liner you have suggested is perfect. > > Good news! > >> .ignore_suspend is set for bdw-rt5677.c and bdw-rt5650.c as well. I don't >> know if that was intentional. > > The intended use case is for applications doing audio during suspend > like telephony audio between the modem and CODEC on a phone or > compressed audio playback. I guess the compressed audio playback case > could possibly apply with these systems though x86 suspend/resume is > usually sufficiently heavyweight that it's surprising. I think that's true, on many of SKL- intel platforms(byt, hsw, bdw), we are seeing this .ignore_suspend set with offload or deep buffer FE dai_links configured together. So it looks we can't ignore calling codec's suspend/resume callbacks during the power cycle for rt286 codec(on the Dell XPS here), which is actually supported on Chromebook SAMUS(rt5677)? Thanks, ~Keyon >