From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 343FBC64E93 for ; Sat, 29 Sep 2018 09:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EF43920879 for ; Sat, 29 Sep 2018 09:36:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF43920879 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727850AbeI2QEG (ORCPT ); Sat, 29 Sep 2018 12:04:06 -0400 Received: from foss.arm.com ([217.140.101.70]:59690 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727540AbeI2QEF (ORCPT ); Sat, 29 Sep 2018 12:04:05 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DC1FC80D; Sat, 29 Sep 2018 02:36:20 -0700 (PDT) Received: from [192.168.0.21] (usa-sjc-mx-foss1.foss.arm.com [217.140.101.70]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 56F2E3F5BD; Sat, 29 Sep 2018 02:36:17 -0700 (PDT) Subject: Re: [PATCH v2 1/7] arm64: move arm uprobes code to be reused by arm64 To: Maciej Slodczyk , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: linux@armlinux.org.uk, oleg@redhat.com, catalin.marinas@arm.com, will.deacon@arm.com, peterz@infradead.org, mingo@redhat.com, acme@kernel.org, alexander.shishkin@linux.intel.com, jolsa@redhat.com, namhyung@kernel.org, b.zolnierkie@samsung.com, m.szyprowski@samsung.com, k.lewandowsk@samsung.com References: <1537963925-25313-1-git-send-email-m.slodczyk2@partner.samsung.com> <1537963925-25313-2-git-send-email-m.slodczyk2@partner.samsung.com> From: Suzuki K Poulose Message-ID: <0d10bc6d-5fb1-fac3-3d68-352b0cfd4af2@arm.com> Date: Sat, 29 Sep 2018 10:37:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <1537963925-25313-2-git-send-email-m.slodczyk2@partner.samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/26/2018 01:11 PM, Maciej Slodczyk wrote: > Move ARM32 uprobes code from arch/arm/probes/ to a more common location - > lib/probes/arm/. This code will be used by ARM64 code when uprobing 32-bit > applications. The patch looks OK to me, with the following nit: The subject tag looks incorrect. Since this patch moves the ARM code around and has nothing to do with arm64 (yet). So, the subject could be : ARM: move uprobes code to be reused by arm64 which could allow the concerned arm people to check this patch. Suzuki From mboxrd@z Thu Jan 1 00:00:00 1970 From: suzuki.poulose@arm.com (Suzuki K Poulose) Date: Sat, 29 Sep 2018 10:37:18 +0100 Subject: [PATCH v2 1/7] arm64: move arm uprobes code to be reused by arm64 In-Reply-To: <1537963925-25313-2-git-send-email-m.slodczyk2@partner.samsung.com> References: <1537963925-25313-1-git-send-email-m.slodczyk2@partner.samsung.com> <1537963925-25313-2-git-send-email-m.slodczyk2@partner.samsung.com> Message-ID: <0d10bc6d-5fb1-fac3-3d68-352b0cfd4af2@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 09/26/2018 01:11 PM, Maciej Slodczyk wrote: > Move ARM32 uprobes code from arch/arm/probes/ to a more common location - > lib/probes/arm/. This code will be used by ARM64 code when uprobing 32-bit > applications. The patch looks OK to me, with the following nit: The subject tag looks incorrect. Since this patch moves the ARM code around and has nothing to do with arm64 (yet). So, the subject could be : ARM: move uprobes code to be reused by arm64 which could allow the concerned arm people to check this patch. Suzuki