All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Jeroen Roovers <jer@xs4all.nl>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Richard Henderson <rth@twiddle.net>,
	Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
	Matt Turner <mattst88@gmail.com>,
	"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
	Helge Deller <deller@gmx.de>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	linux-alpha@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org,
	netdev@vger.kernel.org, linux-sparse@vger.kernel.org
Subject: Re: [PATCH 2/4] net: i825xx: Use absolute_pointer for memcpy on fixed memory location
Date: Sun, 12 Sep 2021 09:16:07 -0700	[thread overview]
Message-ID: <0d118e7b-e3cf-67df-00dc-f85b40ada682@roeck-us.net> (raw)
In-Reply-To: <20210912181148.60f147c8@wim.jer>

On 9/12/21 9:11 AM, Jeroen Roovers wrote:
> On Sun, 12 Sep 2021 09:01:47 -0700
> Guenter Roeck <linux@roeck-us.net> wrote:
> 
>> gcc 11.x reports the following compiler warning/error.
>>
>> drivers/net/ethernet/i825xx/82596.c: In function 'i82596_probe':
>>      ./arch/m68k/include/asm/string.h:72:25: error:
>>              '__builtin_memcpy' reading 6 bytes from a region of size 0
>>                      [-Werror=stringop-overread]
>>
>> Use absolute_address() to work around the problem.
> 
> => absolute_pointer()
> 

Oopsie. Thanks!

Guenter

>> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
>> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
>> ---
>>   drivers/net/ethernet/i825xx/82596.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/i825xx/82596.c
>> b/drivers/net/ethernet/i825xx/82596.c index
>> b8a40146b895..b482f6f633bd 100644 ---
>> a/drivers/net/ethernet/i825xx/82596.c +++
>> b/drivers/net/ethernet/i825xx/82596.c @@ -1144,7 +1144,7 @@ static
>> struct net_device * __init i82596_probe(void) err = -ENODEV;
>>   			goto out;
>>   		}
>> -		memcpy(eth_addr, (void *) 0xfffc1f2c,
>> ETH_ALEN);	/* YUCK! Get addr from NOVRAM */
>> +		memcpy(eth_addr, absolute_pointer(0xfffc1f2c),
>> ETH_ALEN); /* YUCK! Get addr from NOVRAM */ dev->base_addr =
>> MVME_I596_BASE; dev->irq = (unsigned) MVME16x_IRQ_I596;
>>   		goto found;
> 
> 
> Regards,
>        jer
> 


  reply	other threads:[~2021-09-12 16:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-12 16:01 [PATCH 0/4] Introduce and use absolute_pointer macro Guenter Roeck
2021-09-12 16:01 ` [PATCH 1/4] compiler.h: Introduce " Guenter Roeck
2021-09-12 16:01 ` [PATCH 2/4] net: i825xx: Use absolute_pointer for memcpy on fixed memory location Guenter Roeck
2021-09-12 16:11   ` Jeroen Roovers
2021-09-12 16:16     ` Guenter Roeck [this message]
2021-09-12 16:01 ` [PATCH 3/4] parisc: Use absolute_pointer for memcmp " Guenter Roeck
2021-09-12 19:11   ` Linus Torvalds
2021-09-12 19:58     ` Helge Deller
2021-09-12 20:28       ` Guenter Roeck
2021-09-12 16:01 ` [PATCH 4/4] alpha: Use absolute_pointer for strcmp " Guenter Roeck
2021-09-12 19:13   ` Linus Torvalds
2021-09-12 20:15     ` Guenter Roeck
2021-09-12 20:37     ` Guenter Roeck
2021-09-12 22:58       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d118e7b-e3cf-67df-00dc-f85b40ada682@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=davem@davemloft.net \
    --cc=deller@gmx.de \
    --cc=geert@linux-m68k.org \
    --cc=ink@jurassic.park.msu.ru \
    --cc=jer@xs4all.nl \
    --cc=kuba@kernel.org \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-sparse@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=rth@twiddle.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.