From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5179EC432BE for ; Tue, 31 Aug 2021 20:50:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3643461053 for ; Tue, 31 Aug 2021 20:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241249AbhHaUu4 (ORCPT ); Tue, 31 Aug 2021 16:50:56 -0400 Received: from mga11.intel.com ([192.55.52.93]:51488 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229916AbhHaUux (ORCPT ); Tue, 31 Aug 2021 16:50:53 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="215434694" X-IronPort-AV: E=Sophos;i="5.84,367,1620716400"; d="scan'208";a="215434694" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 13:49:57 -0700 X-IronPort-AV: E=Sophos;i="5.84,367,1620716400"; d="scan'208";a="460331329" Received: from krbo1-mobl1.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.32.188]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Aug 2021 13:49:57 -0700 Subject: Re: [PATCH v5 08/12] x86/tdx: Add HLT support for TDX guest To: Borislav Petkov , Sean Christopherson Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org References: <20210804181329.2899708-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210804181329.2899708-9-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <0d2421ac-c501-d33f-d3fc-be9dac7e221c@linux.intel.com> Date: Tue, 31 Aug 2021 13:49:54 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Boris, On 8/24/21 10:27 AM, Borislav Petkov wrote: > I think in the next version all those _tdx_hypercall() wrappers should > spell it out what the parameters they pass are used for. > > Hohumm. Regarding details about _tdx_hypercall() wrapper usage, do you want me to document the ABI details? For example for MSR read, static u64 tdx_read_msr_safe(unsigned int msr, int *err) { struct tdx_hypercall_output out = {0}; u64 ret; WARN_ON_ONCE(tdx_is_context_switched_msr(msr)); /* * TDX MSR READ Hypercall ABI: * * Input Registers: * * R11(EXIT_REASON_MSR_READ) - hypercall sub function id * R12(msr) - MSR index * * Output Registers: * * R10(out.r10) - Hypercall return error code * R11(out.r11) - MSR read value * RAX(ret) - TDCALL error code */ ret = _tdx_hypercall(EXIT_REASON_MSR_READ, msr, 0, 0, 0, &out); Let me know if you agree with above format? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer