From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cHAeh-0007rF-Ad for qemu-devel@nongnu.org; Wed, 14 Dec 2016 09:35:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cHAeb-0008Q2-QR for qemu-devel@nongnu.org; Wed, 14 Dec 2016 09:35:39 -0500 References: <20161214142518.10504-1-stefanha@redhat.com> From: Stefan Weil Message-ID: <0d2c1d9f-dbfd-6e7f-ee26-aca391e02376@weilnetz.de> Date: Wed, 14 Dec 2016 15:35:24 +0100 MIME-Version: 1.0 In-Reply-To: <20161214142518.10504-1-stefanha@redhat.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-2.8] ui/gtk: fix "Copy" menu item segfault List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org Cc: Kevin Wolf , qemu-stable , "Michael S. Tsirkin" Am 14.12.2016 um 15:25 schrieb Stefan Hajnoczi: > The "Copy" menu item copies VTE terminal text to the clipboard. This > only works with VTE terminals, not with graphics consoles. > > Disable the menu item when the current notebook page isn't a VTE > terminal. > > This patch fixes a segfault. Reproducer: Start QEMU and click the Copy > menu item when the guest display is visible. > > Reported-by: Kevin Wolf > Cc: Michael S. Tsirkin > Cc: Gerd Hoffmann > Signed-off-by: Stefan Hajnoczi > --- > ui/gtk.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > Gerd, Michael: if you post Reviewed-by I can merge this directly without > requiring you to send a pull request. It's a user interface segfault so it > would be nice to resolve it in QEMU 2.8. > Tested-by: Stefan Weil CC'ing QEMU-stable because I think that 2.7 needs that fix, too. Stefan