All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hangyu Hua <hbh25y@gmail.com>
To: yashi@spacecubics.com, wg@grandegger.com, mkl@pengutronix.de,
	davem@davemloft.net, kuba@kernel.org, mailhol.vincent@wanadoo.fr,
	stefan.maetje@esd.eu, paskripkin@gmail.com,
	remigiusz.kollataj@mobica.com
Cc: linux-can@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] can: mcba_usb: fix possible double dev_kfree_skb in mcba_usb_start_xmit
Date: Mon, 21 Mar 2022 09:47:30 +0800	[thread overview]
Message-ID: <0d2f9980-fb1d-4068-7868-effc77892a97@gmail.com> (raw)
In-Reply-To: <20220311080208.45047-1-hbh25y@gmail.com>

Gentle ping.

On 2022/3/11 16:02, Hangyu Hua wrote:
> There is no need to call dev_kfree_skb when usb_submit_urb fails beacause
> can_put_echo_skb deletes original skb and can_free_echo_skb deletes the cloned
> skb.
> 
> Fixes: 51f3baad7de9 ("can: mcba_usb: Add support for Microchip CAN BUS Analyzer")
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>   drivers/net/can/usb/mcba_usb.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/can/usb/mcba_usb.c b/drivers/net/can/usb/mcba_usb.c
> index 77bddff86252..7c198eb5bc9c 100644
> --- a/drivers/net/can/usb/mcba_usb.c
> +++ b/drivers/net/can/usb/mcba_usb.c
> @@ -364,7 +364,6 @@ static netdev_tx_t mcba_usb_start_xmit(struct sk_buff *skb,
>   xmit_failed:
>   	can_free_echo_skb(priv->netdev, ctx->ndx, NULL);
>   	mcba_usb_free_ctx(ctx);
> -	dev_kfree_skb(skb);
>   	stats->tx_dropped++;
>   
>   	return NETDEV_TX_OK;

  reply	other threads:[~2022-03-21  1:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-11  8:02 [PATCH] can: mcba_usb: fix possible double dev_kfree_skb in mcba_usb_start_xmit Hangyu Hua
2022-03-21  1:47 ` Hangyu Hua [this message]
2022-03-22 23:08 ` Yasushi SHOJI
2022-03-23  2:12   ` Hangyu Hua

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d2f9980-fb1d-4068-7868-effc77892a97@gmail.com \
    --to=hbh25y@gmail.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=paskripkin@gmail.com \
    --cc=remigiusz.kollataj@mobica.com \
    --cc=stefan.maetje@esd.eu \
    --cc=wg@grandegger.com \
    --cc=yashi@spacecubics.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.