From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chris Wilson Subject: Re: [PATCH 0/8] drm/i915/context Date: Wed, 02 Feb 2011 23:29:37 +0000 Message-ID: <0d30dc$kupvbd@orsmga001.jf.intel.com> References: <1296687620-27019-1-git-send-email-bwidawsk@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id D53619E96C for ; Wed, 2 Feb 2011 15:29:49 -0800 (PST) In-Reply-To: <1296687620-27019-1-git-send-email-bwidawsk@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Ben Widawsky , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org I don't think we should be pinning contexts for their entire lifetime. The page should only be pinned whilst it is being referenced by the hardware, and it looks like you already parts of the infrastructure to be able to track this. You will also need to track seqno and retire contexts... Being picky, there are still renames ;-) But it is much easier to see what you are introducing in each step, thanks! I'm not convinced by the locking strategy, there seems to be quite a few holes left, and is something else that is much easier to make it correct from the beginning and incrementally adjust. And then there are lots of little changes to try and make the code tidier... But those are probably best left for another day. -Chris -- Chris Wilson, Intel Open Source Technology Centre