From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 1/3] ethdev: support metadata as flow rule
	criteria
Date: Fri, 5 Oct 2018 14:31:36 +0100
Message-ID: <0d34ba46-336c-6853-55d3-19b8f46d2db9@intel.com>
References: <1537108670-11380-1-git-send-email-dekelp@mellanox.com>
 <1538056677-33846-2-git-send-email-dekelp@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: shahafs@mellanox.com, orika@mellanox.com
To: Dekel Peled <dekelp@mellanox.com>, wenzhuo.lu@intel.com,
 jingjing.wu@intel.com, bernard.iremonger@intel.com, dev@dpdk.org,
 olivier.matz@6wind.com, adrien.mazarguil@6wind.com, thomas@monjalon.net,
 arybchenko@solarflare.com
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 0D96A1B11A
 for <dev@dpdk.org>; Fri,  5 Oct 2018 15:31:40 +0200 (CEST)
In-Reply-To: <1538056677-33846-2-git-send-email-dekelp@mellanox.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/27/2018 2:57 PM, Dekel Peled wrote:
> As described in [1], a new rte_flow item is added to support metadata
> to use as flow rule match pattern.
> The metadata is an opaque item, fully controlled by the application.
> 
> The use of metadata is relevant for egress rules only.
> It can be set in the flow rule using the RTE_FLOW_ITEM_META.
> 
> In order to avoid change in mbuf API, exisitng field buf.hash.fdir.hi
> is used to carry the metadata item. This field is used only in
> ingress packets, so using it for egress metadata will not cause
> conflicts.
> 
> Application should set the packet metadata in the mbuf dedicated field,
> and set the PKT_TX_METADATA flag in the mbuf->ol_flags.
> The NIC will use the packet metadata as match criteria for relevant
> flow rules.
> 
> This patch introduces metadata item type for rte_flow RTE_FLOW_ITEM_META,
> along with corresponding struct rte_flow_item_meta and ol_flag
> PKT_TX_METADATA.
> 
> [1] "[RFC,v2] ethdev: support metadata as flow rule criteria"
>     http://mails.dpdk.org/archives/dev/2018-August/110194.html
> 
> Signed-off-by: Dekel Peled <dekelp@mellanox.com>

<...>

> @@ -526,6 +532,12 @@ struct rte_mbuf {
>  			uint32_t hi;
>  			/**< First 4 flexible bytes or FD ID, dependent on
>  			     PKT_RX_FDIR_* flag in ol_flags. */
> +			/**
> +			 * Above member has optional use on egress:
> +			 * Application specific metadata value
> +			 * for flow rule match.
> +			 * Valid if PKT_TX_METADATA is set.
> +			 */
>  		} fdir;           /**< Filter identifier if FDIR enabled */

Any objection/comment to use hash.fdir.hi for this new "metadata" meaning? Olivier?