From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbdBGKJS (ORCPT ); Tue, 7 Feb 2017 05:09:18 -0500 Received: from thoth.sbs.de ([192.35.17.2]:54408 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751617AbdBGKJO (ORCPT ); Tue, 7 Feb 2017 05:09:14 -0500 Subject: Re: [PATCH v13 1/2] serial: exar: split out the exar code from 8250_pci To: Sudip Mukherjee , Andy Shevchenko References: <1485815302-5708-1-git-send-email-sudipm.mukherjee@gmail.com> <82b6d515-7ac8-5593-e4e7-d694612f94c1@siemens.com> <5898F301.60202@gmail.com> Cc: Greg Kroah-Hartman , Jiri Slaby , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org From: Jan Kiszka Message-ID: <0d363224-8189-f01a-782b-8f30645fba42@siemens.com> Date: Tue, 7 Feb 2017 11:09:05 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <5898F301.60202@gmail.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-06 23:04, Sudip Mukherjee wrote: > On Monday 06 February 2017 02:45 PM, Jan Kiszka wrote: >> On 2017-01-30 23:28, Sudip Mukherjee wrote: >>> From: Sudip Mukherjee >>> >>> Add the serial driver for the Exar chips. And also register the >>> platform device for the GPIO provided by the Exar chips. >>> >> >> And another question: you left pci_fastcom335_setup and related things >> untouched - did that code come later, or is it left in 8250_pci.c for a >> reason? > > That was discussed. > Those are separate chips from different vendor and this patchset was > specifically for Exar chips. So i suggested I will do it via separate > patch. If they are from different vendors, why are they addressing Exar registers? Seems more like they are just rebranded and should indeed be moved as well. Jan