From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7362DCD1284 for ; Thu, 4 Apr 2024 18:29:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3B116B0093; Thu, 4 Apr 2024 14:29:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EEB3B6B0095; Thu, 4 Apr 2024 14:29:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D64A36B0098; Thu, 4 Apr 2024 14:29:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B94636B0093 for ; Thu, 4 Apr 2024 14:29:50 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 86D60140BBB for ; Thu, 4 Apr 2024 18:29:50 +0000 (UTC) X-FDA: 81972688140.14.F62CA33 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id 49D158000E for ; Thu, 4 Apr 2024 18:29:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ny5f9WRC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1712255388; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wK4Vh1q/P9Xg5lV+yRAMtvZv9KW8I92bRtSkAxtk6rs=; b=6yiumFpUqmhBjuiSJbCFiNuRLKgyGOTzG1OnwZfDWU2USDuMv3KcX5ylRvrAoNsbNo8u/z LnzKauYLrfilRgcfm3oZB6QRrsh0Ya1IpaZ+Cec8Z3mTZnej0MD1C4uwYqPjMDI5TsS86H ZWrLubgz8fqSATUeIe7v+5pMnkETHcU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Ny5f9WRC; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1712255388; a=rsa-sha256; cv=none; b=Si3/jjNq4qXDm8QwI+QmxTQcdxTF67HrNU+gyhaQIMCRDDkZm5IGSTv4Q+o7BvlZfbZLjJ PHSJSrFNV2iOYw4Ox3KcsbDcJHAjFHmDJH/l85Ol+vydX38xvTdLkd9TexAfu+aIWCjZjd 0jHIwTzK7vhv3i1fOTONYYlIIoKbcdA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1712255387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=wK4Vh1q/P9Xg5lV+yRAMtvZv9KW8I92bRtSkAxtk6rs=; b=Ny5f9WRCGWVyllVSVWxKqVyqMOZG1Km+4htZ5dJQG2PaFQvnSesUzW2SCbcBtoHUje/Ja+ BiEEEYL4U0ZAwYVqWWopo2kXJiNu0GyOm8pZWfxRwI0G4ywZlQ09jfx+IMZFiRDPb6pWoj HHYl4mnPPcVhl+p3QRsBFoTUnEaPXGM= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-324-Tphw5ztJNBaLKHuwGK-qMA-1; Thu, 04 Apr 2024 14:29:45 -0400 X-MC-Unique: Tphw5ztJNBaLKHuwGK-qMA-1 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-343c6bb1f21so487225f8f.1 for ; Thu, 04 Apr 2024 11:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712255384; x=1712860184; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wK4Vh1q/P9Xg5lV+yRAMtvZv9KW8I92bRtSkAxtk6rs=; b=srNcTz+20BTwOYosele72hOOK80UVDpsvvsE35YeYfjFI68xRsHAARUWqZjoDWXiyk LmQ1nGXryazukAeNri0sOu22v9WNHPgGhQyL+IeUKTSt5UfgsFfRtySUbLtyYC8G7m5M rKJOecupVgHkjNjpOqOYle3arKPINbqsQ1tFYoZa3o1HeB0q2qQG8/5QbtOnYKVV27nK QGt8s2RXOxWsfP9I2zh/8Ze4QJSuQK98bkFYnQ+v/0EgdtWhktm5wN0R/YhQ/kDKBrG6 xunHVFmxu1iLWTizGHHju+zXjQwzMHQiY1ENYiw25qbapyFhgRui91KtBu480KLzJjfa LbGA== X-Gm-Message-State: AOJu0YwxRWS9gZK/kqDjmbyJS/uQjEGyNDaNkTpiY0wubcfJb6HJc1No PY5uRsONIJbPV4xXzHdqWoR3WmNX/GTSePbAQjwyk33PR+ooJpeSYwgBVNSv0Pk/jOrGhHNDmks zusbFcjIkEv0iOeidoyOYxkpt1W3aRYpFPCm0t+y1nhmdOYK0 X-Received: by 2002:a5d:6347:0:b0:343:8bd7:fca2 with SMTP id b7-20020a5d6347000000b003438bd7fca2mr2364977wrw.35.1712255384664; Thu, 04 Apr 2024 11:29:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF8g6vKmfFFXNSo7mzVJUmAPcmuanXCvApDifK7mT/tzBul+QVDtIAGACCDYG94/SEaGErBAQ== X-Received: by 2002:a5d:6347:0:b0:343:8bd7:fca2 with SMTP id b7-20020a5d6347000000b003438bd7fca2mr2364964wrw.35.1712255384326; Thu, 04 Apr 2024 11:29:44 -0700 (PDT) Received: from ?IPV6:2003:cb:c743:de00:7030:120f:d1c9:4c3c? (p200300cbc743de007030120fd1c94c3c.dip0.t-ipconnect.de. [2003:cb:c743:de00:7030:120f:d1c9:4c3c]) by smtp.gmail.com with ESMTPSA id o27-20020adfa11b000000b00341cc9c1871sm52417wro.0.2024.04.04.11.29.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Apr 2024 11:29:43 -0700 (PDT) Message-ID: <0d399619-28c1-44de-ac29-c8c1139f9700@redhat.com> Date: Thu, 4 Apr 2024 20:29:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 08/10] slub: Remove use of page->flags To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org References: <20240326171045.410737-1-willy@infradead.org> <20240326171045.410737-9-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240326171045.410737-9-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 49D158000E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: od3fs9onkxy1dba8oobse69k31aswy8n X-HE-Tag: 1712255388-568759 X-HE-Meta: U2FsdGVkX19wpi3xulThLfprGfT+ZRU9zVUEqOne+3lb5rFEtLE1XHVIufCuVN/tXoydH6S2iQH+t+6VAJx+doIWWfYv+drxnb75IA3RcLTjB7B0I7FUwYmbol+OnhJ5RSBCEYO7TIhxxhuJbigbCTnmKmIF54FOgkA2Ku1JgihMJ9Pl66zqWPUc9OaBrCCxTwTJAmWOPFJaWfdeT3vlAoEKASvAQXiiATSQcMXVO0zl5jAHeOnZwtbHNVOeHql/+Zt2HrRDLb5j159rsX9/qXtbKuAFYFDuIDx11QjzcFutBPFA2XtTyv4kOvirLBWfR/r8/CgJ0Qu7rWgaXhve/oEkEyuGY0hSE5AgEcIPVaFB10rDiuvSe5wZr7MYO68FX8KW2pL2pmXRuFKca9e8sX2QatMwUQ73pV3KSqCDDI66VzqT4SVNtzE2d88zzlktnf3p/hyV4IbNgIb90z9EYOf4Hdwy6g/hN1bTss2RhKUbjL92gwBb5PPBPu0rgliQqyM0N4y2R0pBse14hSr4Xim8ITq1s4d63kKdwt7QOmOI7P11FUa/Cj/1M2ERFAYauCqWGQmEqW9KqhZziqg4cMYAdfD0Pv/q4wldnb3ytVMKQqoM8SwVSDkNOskVwgzrsx02CfJoJBaGAPupzX+MtaNYTIjeLg9H3gpPJEw8ZF8mDfbgClcL/+21scnZ/Uh/jKagAjK7btRRTUPntihFrjAwbCNinmxo7bBAG4Gi/yUGbH9ehxiEBCwDRqL/rC8fNMp/9VKUybkkoBQa5cmel6kviLk5xpDQBjCaEuJGOjmtKCJBg6i416ChTsZFlQsIpNJp6fbSSGH04Dm4TLu49xA3KrE5xUUPd3gOGzmLZCaPs+dbZ+wPaOfdwoWT4yMjLMG7Jn+eGt6YlXK5jhw3y6B6m3b+jXI05DijHa7xLh05XAg4TNMNw4+u9/cqS2//mAezTm6esFFmaFmjOwo dtEwZwNq WfY+OZSNE34tfHRDB2JGafqzf3pdshoYg6Qp0AI7OODf475ZxGznYvWmBuMxl/NF4ujQMtEpM/8kekDioHqi1yCItS+14m5jG6escMrURVdPMEqS20oVp/REHmqLwSIFGELz39D4ptTduOux6VNi6esSCtfqasq9oNyQ/zcCZ7au/ONbg9eTk4Rce01qtzpcdQVgWEpZgKHWrbQm5g1AtC41V/m34u5iC8BQQqjE3NnjffffdubgkzRnkzN3CbkYKM6HE836kFSvMksteUznWQmeDXAWhVpj4FLKj6WkwEHJ6P+iS9uQad04sLZ2yeADSGe6jTCoNW6NGr+Rz3sw9yqMPfpvgbBzsMEcZQWEt3OyBwGf/jNDRQtRQWMTxfEsskeR6G9Fw5dzVwD3ZKth4EaC8h2PtnrnuP8PTzY36hUO3hV3/VA28hqc/oe7bY0UrP/gh5TZs2r03u6j/Z/FALTDhC3ngCTirkLu2190rhQtomPWG4eZxwg3whA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.03.24 18:10, Matthew Wilcox (Oracle) wrote: > Use slub->__page_flags instead. We can also remove the assertion that > it's not a tail page as struct slab never points to a tail page. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/slub.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index ceee8d76e1a9..1500546a9b68 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -616,18 +616,12 @@ slub_set_cpu_partial(struct kmem_cache *s, unsigned int nr_objects) > */ > static __always_inline void slab_lock(struct slab *slab) > { > - struct page *page = slab_page(slab); > - > - VM_BUG_ON_PAGE(PageTail(page), page); > - bit_spin_lock(PG_locked, &page->flags); > + bit_spin_lock(PG_locked, &slab->__page_flags); > } > > static __always_inline void slab_unlock(struct slab *slab) > { > - struct page *page = slab_page(slab); > - > - VM_BUG_ON_PAGE(PageTail(page), page); > - bit_spin_unlock(PG_locked, &page->flags); > + bit_spin_unlock(PG_locked, &slab->__page_flags); > } > > static inline bool Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb