All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>
To: "jic23@kernel.org" <jic23@kernel.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>
Cc: "Jonathan.Cameron@huawei.com" <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 7/7] iio: light: vl6180: swap of.h for mod_devicetable.h and drop of_match_ptr
Date: Mon, 20 Apr 2020 06:19:17 +0000	[thread overview]
Message-ID: <0d3e8e58e39060ce9a28f2bb3b1d0161f4ed36f1.camel@analog.com> (raw)
In-Reply-To: <20200419150206.43033-8-jic23@kernel.org>

On Sun, 2020-04-19 at 16:02 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Enables probing via ACPI PRP0001 route and removes an example of
> an approach we no longer want people to copy.
> 

This doesn't include 'linux/mod_devicetable.h'.
I'm wondering now if it is needed at all.
Should we remove it from the rest?

With that addressed:

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/iio/light/vl6180.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/light/vl6180.c b/drivers/iio/light/vl6180.c
> index d9533a76b8f6..7e67d7b3bfb6 100644
> --- a/drivers/iio/light/vl6180.c
> +++ b/drivers/iio/light/vl6180.c
> @@ -537,7 +537,7 @@ MODULE_DEVICE_TABLE(i2c, vl6180_id);
>  static struct i2c_driver vl6180_driver = {
>  	.driver = {
>  		.name   = VL6180_DRV_NAME,
> -		.of_match_table = of_match_ptr(vl6180_of_match),
> +		.of_match_table = vl6180_of_match,
>  	},
>  	.probe  = vl6180_probe,
>  	.id_table = vl6180_id,

  reply	other threads:[~2020-04-20  6:19 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-19 15:01 [PATCH 0/7] iio: light: clean out of_match_ptr and tidy headers jic23
2020-04-19 15:02 ` [PATCH 1/7] iio: light: bh1780: use mod_devicetable.h and drop of_match_ptr macro jic23
2020-04-20  6:05   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 2/7] iio: light: cm32181: Add mod_devicetable.h and remove of_match_ptr jic23
2020-04-20  6:05   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 3/7] iio: light: cm3232: Add mod_devicetable.h include and drop of_match_ptr jic23
2020-04-20  6:05   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 4/7] iio: light: gp2ap020a00f: Swap of.h for mod_devicetable.h + " jic23
2020-04-20  6:06   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 5/7] iio: light: opt3001: Add mod_devicetable.h and drop use of of_match_ptr jic23
2020-04-20  6:06   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 6/7] iio: light: st_uvis25: Add mod_devicetable.h and drop of_match_ptr jic23
2020-04-20  6:08   ` Ardelean, Alexandru
2020-04-19 15:02 ` [PATCH 7/7] iio: light: vl6180: swap of.h for " jic23
2020-04-20  6:19   ` Ardelean, Alexandru [this message]
2020-04-20 15:45     ` Jonathan Cameron
2020-04-21  6:58       ` Ardelean, Alexandru
2020-04-20  6:04 ` [PATCH 0/7] iio: light: clean out of_match_ptr and tidy headers Ardelean, Alexandru
2020-04-20  6:22   ` Ardelean, Alexandru
2020-04-20 15:48     ` Jonathan Cameron
2020-04-21  0:50       ` Andy Shevchenko
2020-04-25 14:49         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d3e8e58e39060ce9a28f2bb3b1d0161f4ed36f1.camel@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.