From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB3CFC433F5 for ; Thu, 2 Dec 2021 03:36:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355225AbhLBDjf (ORCPT ); Wed, 1 Dec 2021 22:39:35 -0500 Received: from mailgw01.mediatek.com ([60.244.123.138]:52306 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1355206AbhLBDjU (ORCPT ); Wed, 1 Dec 2021 22:39:20 -0500 X-UUID: 35066ef134af4aa2affe830ba67adfab-20211202 X-UUID: 35066ef134af4aa2affe830ba67adfab-20211202 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1064289280; Thu, 02 Dec 2021 11:35:53 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Thu, 2 Dec 2021 11:35:52 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Dec 2021 11:35:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 2 Dec 2021 11:35:51 +0800 Message-ID: <0d3f33e26b67cabc82246c49c0e952194a9a88c1.camel@mediatek.com> Subject: Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver From: moudy ho To: AngeloGioacchino Del Regno , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec CC: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , "Maoguang Meng" , daoyuan huang , Ping-Hsun Wu , , , , , , , , Date: Thu, 2 Dec 2021 11:35:51 +0800 In-Reply-To: <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> References: <20211201095031.31606-1-moudy.ho@mediatek.com> <20211201095031.31606-8-moudy.ho@mediatek.com> <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2021-12-01 at 11:37 +0100, AngeloGioacchino Del Regno wrote: > Il 01/12/21 10:50, Moudy Ho ha scritto: > > This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3). > > It provides the following functions: > > color transform, format conversion, resize, crop, rotate, flip > > and additional image quality enhancement. > > > > The MDP3 driver is mainly used for Google Chromebook products to > > import the new architecture to set the HW settings as shown below: > > User -> V4L2 framework > > -> MDP3 driver -> SCP (setting calculations) > > -> MDP3 driver -> CMDQ (GCE driver) -> HW > > > > Each modules' related operation control is sited in mtk-mdp3-comp.c > > Each modules' register table is defined in file with "mdp_reg_" > > prefix > > GCE related API, operation control sited in mtk-mdp3-cmdq.c > > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c > > Probe, power, suspend/resume, system level functions are defined in > > mtk-mdp3-core.c > > > > Signed-off-by: Ping-Hsun Wu > > Signed-off-by: daoyuan huang > > Signed-off-by: Moudy Ho > > Reported-by: kernel test robot > > --- > > drivers/media/platform/Kconfig | 19 + > > drivers/media/platform/Makefile | 2 + > > drivers/media/platform/mtk-mdp3/Makefile | 6 + > > .../media/platform/mtk-mdp3/mdp_reg_ccorr.h | 19 + > > drivers/media/platform/mtk-mdp3/mdp_reg_isp.h | 27 + > > .../media/platform/mtk-mdp3/mdp_reg_rdma.h | 65 + > > drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h | 39 + > > .../media/platform/mtk-mdp3/mdp_reg_wdma.h | 47 + > > .../media/platform/mtk-mdp3/mdp_reg_wrot.h | 55 + > > drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 280 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 514 +++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.h | 46 + > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 1264 > > +++++++++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 147 ++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 338 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 76 + > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 789 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.h | 49 + > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 737 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 372 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.c | 312 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.h | 78 + > > 22 files changed, 5281 insertions(+) > > create mode 100644 drivers/media/platform/mtk-mdp3/Makefile > > create mode 100644 drivers/media/platform/mtk- > > mdp3/mdp_reg_ccorr.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_isp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wrot.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.h > > > > snip... > > > diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > new file mode 100644 > > index 000000000000..a643f3ee928b > > --- /dev/null > > +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > @@ -0,0 +1,514 @@ > > Looks like you forgot to check my review comments to this entire > file. > Can you please send a new version after applying the changes to this > file > suggested in my review of series v8? Hi Angelo, Thanks for the reminder and sorry for my carelessness. Considering the compatibility of subsequent chips and function independence, I plan to move those mutex mod definition to the corresponding driver, and release next version ASAP. Thanks & Regards, Moudy Ho > Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BBB4C433F5 for ; Thu, 2 Dec 2021 03:36:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rF6kmzPjBekZONErDpA39mZ10qdCdxB6nqvzsIxNifw=; b=W9UwzSgaf7bFqe xtK5KbF2B15EkVrAQJvycLh0gk4K6/SnRVMEsbzCusG2E+9r8HghuNEpUpOCPdtf297nC8eqDcdaL EugnL/ChxatzQUcKtIYXfuEQ6/VubiSnAhTDh1MEw44icDpZ9Ku3F2xjtLF80jDgH2EZO92H3ouTy nWU2DECFyQpFqF5vkGMt3gB4n6jt/cuWzBQ+1h2t3/lutjtKiBuBqGfou1MOejRtNnQOpoq0dqDzT 7ZQyziLC9ojXNEVytUwoIn6CNASjvzfI+MsFw6nokkpim6S8b1QrxzVuuJEQkxm9j/TKB8j/qgrrO 3ofIGmjxLmpVy9nYvliQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msctT-00Agz3-18; Thu, 02 Dec 2021 03:36:23 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msctG-00AgxD-8T; Thu, 02 Dec 2021 03:36:12 +0000 X-UUID: de6738d411374730ab8d673d1aa8845f-20211201 X-UUID: de6738d411374730ab8d673d1aa8845f-20211201 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1539040595; Wed, 01 Dec 2021 20:36:06 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Dec 2021 19:36:04 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Dec 2021 11:35:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 2 Dec 2021 11:35:51 +0800 Message-ID: <0d3f33e26b67cabc82246c49c0e952194a9a88c1.camel@mediatek.com> Subject: Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver From: moudy ho To: AngeloGioacchino Del Regno , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec CC: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , "Maoguang Meng" , daoyuan huang , Ping-Hsun Wu , , , , , , , , Date: Thu, 2 Dec 2021 11:35:51 +0800 In-Reply-To: <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> References: <20211201095031.31606-1-moudy.ho@mediatek.com> <20211201095031.31606-8-moudy.ho@mediatek.com> <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_193610_346492_E2A1C0C5 X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Wed, 2021-12-01 at 11:37 +0100, AngeloGioacchino Del Regno wrote: > Il 01/12/21 10:50, Moudy Ho ha scritto: > > This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3). > > It provides the following functions: > > color transform, format conversion, resize, crop, rotate, flip > > and additional image quality enhancement. > > > > The MDP3 driver is mainly used for Google Chromebook products to > > import the new architecture to set the HW settings as shown below: > > User -> V4L2 framework > > -> MDP3 driver -> SCP (setting calculations) > > -> MDP3 driver -> CMDQ (GCE driver) -> HW > > > > Each modules' related operation control is sited in mtk-mdp3-comp.c > > Each modules' register table is defined in file with "mdp_reg_" > > prefix > > GCE related API, operation control sited in mtk-mdp3-cmdq.c > > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c > > Probe, power, suspend/resume, system level functions are defined in > > mtk-mdp3-core.c > > > > Signed-off-by: Ping-Hsun Wu > > Signed-off-by: daoyuan huang > > Signed-off-by: Moudy Ho > > Reported-by: kernel test robot > > --- > > drivers/media/platform/Kconfig | 19 + > > drivers/media/platform/Makefile | 2 + > > drivers/media/platform/mtk-mdp3/Makefile | 6 + > > .../media/platform/mtk-mdp3/mdp_reg_ccorr.h | 19 + > > drivers/media/platform/mtk-mdp3/mdp_reg_isp.h | 27 + > > .../media/platform/mtk-mdp3/mdp_reg_rdma.h | 65 + > > drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h | 39 + > > .../media/platform/mtk-mdp3/mdp_reg_wdma.h | 47 + > > .../media/platform/mtk-mdp3/mdp_reg_wrot.h | 55 + > > drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 280 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 514 +++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.h | 46 + > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 1264 > > +++++++++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 147 ++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 338 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 76 + > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 789 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.h | 49 + > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 737 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 372 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.c | 312 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.h | 78 + > > 22 files changed, 5281 insertions(+) > > create mode 100644 drivers/media/platform/mtk-mdp3/Makefile > > create mode 100644 drivers/media/platform/mtk- > > mdp3/mdp_reg_ccorr.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_isp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wrot.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.h > > > > snip... > > > diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > new file mode 100644 > > index 000000000000..a643f3ee928b > > --- /dev/null > > +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > @@ -0,0 +1,514 @@ > > Looks like you forgot to check my review comments to this entire > file. > Can you please send a new version after applying the changes to this > file > suggested in my review of series v8? Hi Angelo, Thanks for the reminder and sorry for my carelessness. Considering the compatibility of subsequent chips and function independence, I plan to move those mutex mod definition to the corresponding driver, and release next version ASAP. Thanks & Regards, Moudy Ho > Thanks. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29B10C433F5 for ; Thu, 2 Dec 2021 03:37:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zKV2F2FqrXBSPeC2N485HXFIGGz9005FZCU6h3t9GVI=; b=SsMydCMcxMr4mN JScVPhZmkc+r6qcWevoKlgLCIySnMP5wIC44+PYydIeh9NXK87o7o9HGQX2bqslyYjbdLkGX5hPdm azSAPyI3SDP7Fn93MPWnAEIq9mWsRxUBzcrTXbvYBoHc7l12plEMjEY6cvERAJNIBEz+hBV2DpqLS hnoZOVfp0BmKgiDw1gITUWURAyTFbXkesRdCtOhl5Eq5lRcpTQyR+C2YFMc5293BygBD8yhPsCbBG fOGWkhhyfutWahf9nX/pSh/YiL3IwBy12XJu3aXenF0m62IQ7ZdhfRZB+lFk70cgAsz3tcZX3qePt bAx6T/NgMAXlsS+oa0mQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msctJ-00Agxh-Uo; Thu, 02 Dec 2021 03:36:14 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msctG-00AgxD-8T; Thu, 02 Dec 2021 03:36:12 +0000 X-UUID: de6738d411374730ab8d673d1aa8845f-20211201 X-UUID: de6738d411374730ab8d673d1aa8845f-20211201 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1539040595; Wed, 01 Dec 2021 20:36:06 -0700 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 1 Dec 2021 19:36:04 -0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 2 Dec 2021 11:35:51 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 2 Dec 2021 11:35:51 +0800 Message-ID: <0d3f33e26b67cabc82246c49c0e952194a9a88c1.camel@mediatek.com> Subject: Re: [PATCH v9 7/7] media: platform: mtk-mdp3: add Mediatek MDP3 driver From: moudy ho To: AngeloGioacchino Del Regno , Mauro Carvalho Chehab , Rob Herring , Matthias Brugger , Hans Verkuil , Jernej Skrabec CC: Chun-Kuang Hu , Geert Uytterhoeven , Rob Landley , Laurent Pinchart , , , , , , Alexandre Courbot , , , , , "Maoguang Meng" , daoyuan huang , Ping-Hsun Wu , , , , , , , , Date: Thu, 2 Dec 2021 11:35:51 +0800 In-Reply-To: <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> References: <20211201095031.31606-1-moudy.ho@mediatek.com> <20211201095031.31606-8-moudy.ho@mediatek.com> <103b1664-d04c-c1fc-ff4c-e2c92ce45ee8@collabora.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211201_193610_346492_E2A1C0C5 X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-12-01 at 11:37 +0100, AngeloGioacchino Del Regno wrote: > Il 01/12/21 10:50, Moudy Ho ha scritto: > > This patch adds driver for Mediatek's Media Data Path ver.3 (MDP3). > > It provides the following functions: > > color transform, format conversion, resize, crop, rotate, flip > > and additional image quality enhancement. > > > > The MDP3 driver is mainly used for Google Chromebook products to > > import the new architecture to set the HW settings as shown below: > > User -> V4L2 framework > > -> MDP3 driver -> SCP (setting calculations) > > -> MDP3 driver -> CMDQ (GCE driver) -> HW > > > > Each modules' related operation control is sited in mtk-mdp3-comp.c > > Each modules' register table is defined in file with "mdp_reg_" > > prefix > > GCE related API, operation control sited in mtk-mdp3-cmdq.c > > V4L2 m2m device functions are implemented in mtk-mdp3-m2m.c > > Probe, power, suspend/resume, system level functions are defined in > > mtk-mdp3-core.c > > > > Signed-off-by: Ping-Hsun Wu > > Signed-off-by: daoyuan huang > > Signed-off-by: Moudy Ho > > Reported-by: kernel test robot > > --- > > drivers/media/platform/Kconfig | 19 + > > drivers/media/platform/Makefile | 2 + > > drivers/media/platform/mtk-mdp3/Makefile | 6 + > > .../media/platform/mtk-mdp3/mdp_reg_ccorr.h | 19 + > > drivers/media/platform/mtk-mdp3/mdp_reg_isp.h | 27 + > > .../media/platform/mtk-mdp3/mdp_reg_rdma.h | 65 + > > drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h | 39 + > > .../media/platform/mtk-mdp3/mdp_reg_wdma.h | 47 + > > .../media/platform/mtk-mdp3/mdp_reg_wrot.h | 55 + > > drivers/media/platform/mtk-mdp3/mtk-img-ipi.h | 280 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 514 +++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-cmdq.h | 46 + > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.c | 1264 > > +++++++++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-comp.h | 147 ++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.c | 338 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-core.h | 76 + > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.c | 789 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-m2m.h | 49 + > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.c | 737 ++++++++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-regs.h | 372 +++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.c | 312 ++++ > > .../media/platform/mtk-mdp3/mtk-mdp3-vpu.h | 78 + > > 22 files changed, 5281 insertions(+) > > create mode 100644 drivers/media/platform/mtk-mdp3/Makefile > > create mode 100644 drivers/media/platform/mtk- > > mdp3/mdp_reg_ccorr.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_isp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_rsz.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wdma.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mdp_reg_wrot.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-img-ipi.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > cmdq.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > comp.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > core.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-m2m.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3- > > regs.h > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.c > > create mode 100644 drivers/media/platform/mtk-mdp3/mtk-mdp3-vpu.h > > > > snip... > > > diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > new file mode 100644 > > index 000000000000..a643f3ee928b > > --- /dev/null > > +++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c > > @@ -0,0 +1,514 @@ > > Looks like you forgot to check my review comments to this entire > file. > Can you please send a new version after applying the changes to this > file > suggested in my review of series v8? Hi Angelo, Thanks for the reminder and sorry for my carelessness. Considering the compatibility of subsequent chips and function independence, I plan to move those mutex mod definition to the corresponding driver, and release next version ASAP. Thanks & Regards, Moudy Ho > Thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel