From: Jason Wang <jasowang@redhat.com> To: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Cc: "David S. Miller" <davem@davemloft.net>, "Jakub Kicinski" <kuba@kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>, "Björn Töpel" <bjorn@kernel.org>, "Magnus Karlsson" <magnus.karlsson@intel.com>, "Jonathan Lemon" <jonathan.lemon@gmail.com>, "Alexei Starovoitov" <ast@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Jesper Dangaard Brouer" <hawk@kernel.org>, "John Fastabend" <john.fastabend@gmail.com>, "Andrii Nakryiko" <andrii@kernel.org>, "Martin KaFai Lau" <kafai@fb.com>, "Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>, "KP Singh" <kpsingh@kernel.org>, virtualization@lists.linux-foundation.org, bpf@vger.kernel.org, "dust.li" <dust.li@linux.alibaba.com>, netdev@vger.kernel.org, "yuri Benditovich" <yuri.benditovich@daynix.com>, "Andrew Melnychenko" <andrew@daynix.com> Subject: Re: [PATCH net-next v5 13/15] virtio-net: support AF_XDP zc rx Date: Thu, 17 Jun 2021 14:03:29 +0800 [thread overview] Message-ID: <0d4c5ff5-2b53-6b55-b5aa-bd943af98bb7@redhat.com> (raw) In-Reply-To: <1623909234.193789-1-xuanzhuo@linux.alibaba.com> 在 2021/6/17 下午1:53, Xuan Zhuo 写道: > On Thu, 17 Jun 2021 11:23:52 +0800, Jason Wang <jasowang@redhat.com> wrote: >> 在 2021/6/10 下午4:22, Xuan Zhuo 写道: >>> Compared to the case of xsk tx, the case of xsk zc rx is more >>> complicated. >>> >>> When we process the buf received by vq, we may encounter ordinary >>> buffers, or xsk buffers. What makes the situation more complicated is >>> that in the case of mergeable, when num_buffer > 1, we may still >>> encounter the case where xsk buffer is mixed with ordinary buffer. >>> >>> Another thing that makes the situation more complicated is that when we >>> get an xsk buffer from vq, the xsk bound to this xsk buffer may have >>> been unbound. >>> >>> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> >> >> This is somehow similar to the case of tx where we don't have per vq reset. >> >> [...] >> >>> - if (vi->mergeable_rx_bufs) >>> + if (is_xsk_ctx(ctx)) >>> + skb = receive_xsk(dev, vi, rq, buf, len, xdp_xmit, stats); >>> + else if (vi->mergeable_rx_bufs) >>> skb = receive_mergeable(dev, vi, rq, buf, ctx, len, xdp_xmit, >>> stats); >>> else if (vi->big_packets) >>> @@ -1175,6 +1296,14 @@ static bool try_fill_recv(struct virtnet_info *vi, struct receive_queue *rq, >>> int err; >>> bool oom; >>> >>> + /* Because virtio-net does not yet support flow direct, >> >> Note that this is not the case any more. RSS has been supported by >> virtio spec and qemu/vhost/tap now. We just need some work on the >> virtio-net driver part (e.g the ethool interface). > Oh, are there any plans? Who is doing this work, can I help? Qemu and spec has support RSS. TAP support is ready via steering eBPF program, you can try to play it with current qemu master. The only thing missed is the Linux driver, I think Yuri or Andrew is working on this. Thanks > > Thanks. > >> Thanks >> >>
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Xuan Zhuo <xuanzhuo@linux.alibaba.com> Cc: "Song Liu" <songliubraving@fb.com>, "Martin KaFai Lau" <kafai@fb.com>, "Jesper Dangaard Brouer" <hawk@kernel.org>, "Daniel Borkmann" <daniel@iogearbox.net>, "Michael S. Tsirkin" <mst@redhat.com>, "Yonghong Song" <yhs@fb.com>, "John Fastabend" <john.fastabend@gmail.com>, "Alexei Starovoitov" <ast@kernel.org>, "Andrew Melnychenko" <andrew@daynix.com>, "Andrii Nakryiko" <andrii@kernel.org>, netdev@vger.kernel.org, "yuri Benditovich" <yuri.benditovich@daynix.com>, "Björn Töpel" <bjorn@kernel.org>, "dust.li" <dust.li@linux.alibaba.com>, "Jonathan Lemon" <jonathan.lemon@gmail.com>, "KP Singh" <kpsingh@kernel.org>, "Jakub Kicinski" <kuba@kernel.org>, bpf@vger.kernel.org, virtualization@lists.linux-foundation.org, "David S. Miller" <davem@davemloft.net>, "Magnus Karlsson" <magnus.karlsson@intel.com> Subject: Re: [PATCH net-next v5 13/15] virtio-net: support AF_XDP zc rx Date: Thu, 17 Jun 2021 14:03:29 +0800 [thread overview] Message-ID: <0d4c5ff5-2b53-6b55-b5aa-bd943af98bb7@redhat.com> (raw) In-Reply-To: <1623909234.193789-1-xuanzhuo@linux.alibaba.com> 在 2021/6/17 下午1:53, Xuan Zhuo 写道: > On Thu, 17 Jun 2021 11:23:52 +0800, Jason Wang <jasowang@redhat.com> wrote: >> 在 2021/6/10 下午4:22, Xuan Zhuo 写道: >>> Compared to the case of xsk tx, the case of xsk zc rx is more >>> complicated. >>> >>> When we process the buf received by vq, we may encounter ordinary >>> buffers, or xsk buffers. What makes the situation more complicated is >>> that in the case of mergeable, when num_buffer > 1, we may still >>> encounter the case where xsk buffer is mixed with ordinary buffer. >>> >>> Another thing that makes the situation more complicated is that when we >>> get an xsk buffer from vq, the xsk bound to this xsk buffer may have >>> been unbound. >>> >>> Signed-off-by: Xuan Zhuo <xuanzhuo@linux.alibaba.com> >> >> This is somehow similar to the case of tx where we don't have per vq reset. >> >> [...] >> >>> - if (vi->mergeable_rx_bufs) >>> + if (is_xsk_ctx(ctx)) >>> + skb = receive_xsk(dev, vi, rq, buf, len, xdp_xmit, stats); >>> + else if (vi->mergeable_rx_bufs) >>> skb = receive_mergeable(dev, vi, rq, buf, ctx, len, xdp_xmit, >>> stats); >>> else if (vi->big_packets) >>> @@ -1175,6 +1296,14 @@ static bool try_fill_recv(struct virtnet_info *vi, struct receive_queue *rq, >>> int err; >>> bool oom; >>> >>> + /* Because virtio-net does not yet support flow direct, >> >> Note that this is not the case any more. RSS has been supported by >> virtio spec and qemu/vhost/tap now. We just need some work on the >> virtio-net driver part (e.g the ethool interface). > Oh, are there any plans? Who is doing this work, can I help? Qemu and spec has support RSS. TAP support is ready via steering eBPF program, you can try to play it with current qemu master. The only thing missed is the Linux driver, I think Yuri or Andrew is working on this. Thanks > > Thanks. > >> Thanks >> >> _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2021-06-17 6:03 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-10 8:21 [PATCH net-next v5 00/15] virtio-net: support xdp socket zero copy Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-10 8:21 ` [PATCH net-next v5 01/15] netdevice: priv_flags extend to 64bit Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-10 8:21 ` [PATCH net-next v5 02/15] netdevice: add priv_flags IFF_NOT_USE_DMA_ADDR Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-10 8:21 ` [PATCH net-next v5 03/15] virtio-net: " Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-16 9:27 ` Jason Wang 2021-06-16 9:27 ` Jason Wang 2021-06-16 10:27 ` Xuan Zhuo 2021-06-10 8:21 ` [PATCH net-next v5 04/15] xsk: XDP_SETUP_XSK_POOL support option IFF_NOT_USE_DMA_ADDR Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-10 8:21 ` [PATCH net-next v5 05/15] virtio: support virtqueue_detach_unused_buf_ctx Xuan Zhuo 2021-06-10 8:21 ` Xuan Zhuo 2021-06-17 2:48 ` kernel test robot 2021-06-17 2:48 ` kernel test robot 2021-06-10 8:22 ` [PATCH net-next v5 06/15] virtio-net: unify the code for recycling the xmit ptr Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 2:42 ` Jason Wang 2021-06-16 2:42 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 07/15] virtio-net: standalone virtnet_aloc_frag function Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 2:45 ` Jason Wang 2021-06-16 2:45 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 08/15] virtio-net: split the receive_mergeable function Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 7:33 ` Jason Wang 2021-06-16 7:33 ` Jason Wang 2021-06-16 7:52 ` Xuan Zhuo 2021-06-10 8:22 ` [PATCH net-next v5 09/15] virtio-net: virtnet_poll_tx support budget check Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-10 8:22 ` [PATCH net-next v5 10/15] virtio-net: independent directory Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 7:34 ` Jason Wang 2021-06-16 7:34 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 11/15] virtio-net: move to virtio_net.h Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 7:35 ` Jason Wang 2021-06-16 7:35 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 12/15] virtio-net: support AF_XDP zc tx Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-16 9:26 ` Jason Wang 2021-06-16 9:26 ` Jason Wang 2021-06-16 10:10 ` Magnus Karlsson 2021-06-16 10:19 ` Xuan Zhuo 2021-06-16 12:51 ` Jason Wang 2021-06-16 12:51 ` Jason Wang 2021-06-16 12:57 ` Xuan Zhuo 2021-06-17 2:36 ` Jason Wang 2021-06-17 2:36 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 13/15] virtio-net: support AF_XDP zc rx Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-17 2:48 ` kernel test robot 2021-06-17 2:48 ` kernel test robot 2021-06-17 3:23 ` Jason Wang 2021-06-17 3:23 ` Jason Wang 2021-06-17 5:53 ` Xuan Zhuo 2021-06-17 6:03 ` Jason Wang [this message] 2021-06-17 6:03 ` Jason Wang 2021-06-17 6:37 ` Xuan Zhuo 2021-06-17 6:58 ` Jason Wang 2021-06-17 6:58 ` Jason Wang 2021-06-21 3:26 ` kernel test robot 2021-06-21 3:26 ` kernel test robot 2021-06-10 8:22 ` [PATCH net-next v5 14/15] virtio-net: xsk direct xmit inside xsk wakeup Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-17 3:07 ` Jason Wang 2021-06-17 3:07 ` Jason Wang 2021-06-17 5:55 ` Xuan Zhuo 2021-06-17 6:01 ` Jason Wang 2021-06-17 6:01 ` Jason Wang 2021-06-10 8:22 ` [PATCH net-next v5 15/15] virtio-net: xsk zero copy xmit kick by threshold Xuan Zhuo 2021-06-10 8:22 ` Xuan Zhuo 2021-06-17 3:08 ` Jason Wang 2021-06-17 3:08 ` Jason Wang 2021-06-17 5:56 ` Xuan Zhuo 2021-06-17 6:00 ` Jason Wang 2021-06-17 6:00 ` Jason Wang 2021-06-17 6:43 ` Xuan Zhuo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=0d4c5ff5-2b53-6b55-b5aa-bd943af98bb7@redhat.com \ --to=jasowang@redhat.com \ --cc=andrew@daynix.com \ --cc=andrii@kernel.org \ --cc=ast@kernel.org \ --cc=bjorn@kernel.org \ --cc=bpf@vger.kernel.org \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=dust.li@linux.alibaba.com \ --cc=hawk@kernel.org \ --cc=john.fastabend@gmail.com \ --cc=jonathan.lemon@gmail.com \ --cc=kafai@fb.com \ --cc=kpsingh@kernel.org \ --cc=kuba@kernel.org \ --cc=magnus.karlsson@intel.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=songliubraving@fb.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xuanzhuo@linux.alibaba.com \ --cc=yhs@fb.com \ --cc=yuri.benditovich@daynix.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.