From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7012C3A5A7 for ; Tue, 3 Sep 2019 07:51:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD8942053B for ; Tue, 3 Sep 2019 07:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfICHvR (ORCPT ); Tue, 3 Sep 2019 03:51:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55348 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726698AbfICHvR (ORCPT ); Tue, 3 Sep 2019 03:51:17 -0400 Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4229D4ACA5 for ; Tue, 3 Sep 2019 07:51:16 +0000 (UTC) Received: by mail-ed1-f71.google.com with SMTP id z25so10044596edm.3 for ; Tue, 03 Sep 2019 00:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w8HIPoxJeKQ6uWeXwaqzJnrwZeqZuyXyHwG4+Nh5f8I=; b=N2HEi6V0FB/mV3CRCkJg/Ayfbc07ZGfFV/n7gybeBT3L0Q7lqrCm47/5WcBRKFt2qi 6kidp1R9VLltqVl3YgWNs9+JrTV3opFlcm7hf8JR/7Q6Qub8px2Xh+x1sJd9hrcuXlM8 WVX0nDf5y8VjrKZSpVspj6I20imNzhpnZ+eBGsA7EizzYmNOeJ5WlHesAOzlQB1/Tqgz 056SX2EVXwU4IfSQLzfzTAX/ywiTXMnYQvO98dhglqAhv5BNgzBZCJCXm1CxLIikWrjI EVXCb7VjW8ktXJ6RHh+/BXSSKbZuRDgrWSN1TOh2Zh1ljTyAGOleFZwL4fvgW5V5GFlI Cz9Q== X-Gm-Message-State: APjAAAXNjY19kACrf6ZXaWLi6LVd5XKD/VbOuKD/DdDXVorJCkHqT6l4 d0AT107yo6+JySJZb0P9Wiz3zEj/JsnKMdIPbQ6ulBisezfbvWe55kynUZxfEprUZwb1PtlOqYZ zy5I6HgEcEvvmrnw5S3TnnRLp X-Received: by 2002:a17:906:d7a3:: with SMTP id pk3mr13383193ejb.97.1567497075044; Tue, 03 Sep 2019 00:51:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcWpjWCgHm7od0lS3pQcg6L6ajmTNeMv46O7wYLrV4SdnJWrI2Vv4mBF3X9ZIiqJr2V6QZKg== X-Received: by 2002:a17:906:d7a3:: with SMTP id pk3mr13383184ejb.97.1567497074920; Tue, 03 Sep 2019 00:51:14 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id c1sm3244417edr.37.2019.09.03.00.51.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2019 00:51:14 -0700 (PDT) Subject: Re: [PATCH 5/9] crypto: ccree - Rename arrays to avoid conflict with crypto/sha256.h To: Gilad Ben-Yossef Cc: Herbert Xu , "David S . Miller" , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Russell King , Catalin Marinas , Will Deacon , Atul Gupta , Marc Zyngier , Eric Biggers , Andy Lutomirski , Ard Biesheuvel , Linux Crypto Mailing List , x86@kernel.org, linux-s390@vger.kernel.org, linux-efi@vger.kernel.org, Linux kernel mailing list , Linux ARM References: <20190901203532.2615-1-hdegoede@redhat.com> <20190901203532.2615-6-hdegoede@redhat.com> From: Hans de Goede Message-ID: <0d55a6a7-9cca-38cb-97a2-558280fdc122@redhat.com> Date: Tue, 3 Sep 2019 09:51:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Hi, On 03-09-19 09:45, Gilad Ben-Yossef wrote: > On Sun, Sep 1, 2019 at 11:36 PM Hans de Goede wrote: >> >> Rename the algo_init arrays to cc_algo_init so that they do not conflict >> with the functions declared in crypto/sha256.h. >> >> This is a preparation patch for folding crypto/sha256.h into crypto/sha.h. > > I'm fine with the renaming. > > Signed-off-by: Gilad Ben-Yossef Your Signed-off-by is only used when the patches passes through your hands, since Herbert will likely apply this directly that is not the case. You want either Acked-by or Reviewed-by to signal that you are ok with this patch. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA856C3A5A2 for ; Tue, 3 Sep 2019 07:51:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8D4482053B for ; Tue, 3 Sep 2019 07:51:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gm5wIo/C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8D4482053B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8iWFV/SGul8bu5+y4LcYRB++iuMsOERgamkztJ9vdyY=; b=gm5wIo/CZKrcuOIfDJb8qrY+Q Mp1jbUATNBqsEkBHCvHQAq3pgM5fCc8xgM78TSeIg17QytD+eTYsiY16a1XE/w3PIIhs5VEZkclX6 czX/vYsWhY5bbFUK98VHZzHRb2F9II+jrE+uJ1Uxmg7HigsG0j72VfitUomHBKJSfi9Oo0nXf6du1 DzWy2KDvyM9AtrOCG76Iq3YrdlpYFybDUWt6RKdh1DlR/uEeTwo+3hRAKn9uw51GrkRBK2IHpITt8 GGg7TsqY1A88n+JT2F3QNHDGzQQGv4MEX6p1xGStj17iesIXjXGibiefgWr89lNKen4MY1IX4gEe7 2pZFV98oA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i53ay-0007t7-Uc; Tue, 03 Sep 2019 07:51:20 +0000 Received: from mx1.redhat.com ([209.132.183.28]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i53av-0007sD-TD for linux-arm-kernel@lists.infradead.org; Tue, 03 Sep 2019 07:51:19 +0000 Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CC5C7C056807 for ; Tue, 3 Sep 2019 07:51:16 +0000 (UTC) Received: by mail-ed1-f70.google.com with SMTP id f5so1618933edr.19 for ; Tue, 03 Sep 2019 00:51:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=w8HIPoxJeKQ6uWeXwaqzJnrwZeqZuyXyHwG4+Nh5f8I=; b=f4llzWUAgWpBDUXR2IBzFw+QpUPArSQLZYRmrxgDZwlxz34eeeokoBL/mgtWboaz1U nKTb8uMEHoatssb2WtqpTH/+/9q06Iay/pKwSIO/NkKXJZit8C5bH5DRUzaHFXbjudNM Q0HyQqc0KlB4ponM4WRlAlkTqLeDnQBS1gOy+8SLvSyArD8LSM10HNaoORDt42saLEsK 99/j6Vp3IbysxLAaE7W3Alra+bLv9L1psJmMefM4JumNnoiBZblae6v7wi1ck3QDbcFD +RiPW8xH6llbHhTMBRtGgR2ETiE2O+ZWXa8P6o6crB5kpB3E0zXxjtymR2TVNfMBvNGd otKQ== X-Gm-Message-State: APjAAAWo6szoTKDg9b/kYT5iHw1uuOu2g9nQvEyON4uo68jKG0tsGUar sDPIitY79V/XIN5aavooMHWTpAJ0y7l7/GHXNUhdbITvQ9GkLGABIgwk5P8h+8W2R0wZkc1i0ze 7hKux9eJthmVs7QFYGR/oULj7vytvwVUTmh4= X-Received: by 2002:a17:906:d7a3:: with SMTP id pk3mr13383198ejb.97.1567497075044; Tue, 03 Sep 2019 00:51:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcWpjWCgHm7od0lS3pQcg6L6ajmTNeMv46O7wYLrV4SdnJWrI2Vv4mBF3X9ZIiqJr2V6QZKg== X-Received: by 2002:a17:906:d7a3:: with SMTP id pk3mr13383184ejb.97.1567497074920; Tue, 03 Sep 2019 00:51:14 -0700 (PDT) Received: from shalem.localdomain (84-106-84-65.cable.dynamic.v4.ziggo.nl. [84.106.84.65]) by smtp.gmail.com with ESMTPSA id c1sm3244417edr.37.2019.09.03.00.51.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Sep 2019 00:51:14 -0700 (PDT) Subject: Re: [PATCH 5/9] crypto: ccree - Rename arrays to avoid conflict with crypto/sha256.h To: Gilad Ben-Yossef References: <20190901203532.2615-1-hdegoede@redhat.com> <20190901203532.2615-6-hdegoede@redhat.com> From: Hans de Goede Message-ID: <0d55a6a7-9cca-38cb-97a2-558280fdc122@redhat.com> Date: Tue, 3 Sep 2019 09:51:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190903_005117_983234_4FD5D66A X-CRM114-Status: GOOD ( 19.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-efi@vger.kernel.org, Catalin Marinas , Heiko Carstens , "H . Peter Anvin" , Will Deacon , Atul Gupta , linux-s390@vger.kernel.org, Herbert Xu , x86@kernel.org, Russell King , Eric Biggers , Christian Borntraeger , Ingo Molnar , Vasily Gorbik , Marc Zyngier , Borislav Petkov , Andy Lutomirski , Thomas Gleixner , Linux ARM , Ard Biesheuvel , Linux kernel mailing list , Linux Crypto Mailing List , "David S . Miller" Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On 03-09-19 09:45, Gilad Ben-Yossef wrote: > On Sun, Sep 1, 2019 at 11:36 PM Hans de Goede wrote: >> >> Rename the algo_init arrays to cc_algo_init so that they do not conflict >> with the functions declared in crypto/sha256.h. >> >> This is a preparation patch for folding crypto/sha256.h into crypto/sha.h. > > I'm fine with the renaming. > > Signed-off-by: Gilad Ben-Yossef Your Signed-off-by is only used when the patches passes through your hands, since Herbert will likely apply this directly that is not the case. You want either Acked-by or Reviewed-by to signal that you are ok with this patch. Regards, Hans _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel