From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 779F3C4332F for ; Fri, 25 Nov 2022 04:00:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbiKYEAV (ORCPT ); Thu, 24 Nov 2022 23:00:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229529AbiKYEAT (ORCPT ); Thu, 24 Nov 2022 23:00:19 -0500 Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA0AB21E02; Thu, 24 Nov 2022 20:00:17 -0800 (PST) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2AP3Yqrq036587; Fri, 25 Nov 2022 11:34:52 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Nov 2022 11:59:21 +0800 Message-ID: <0d58e557-3ed9-669a-febb-b4ac714af01e@aspeedtech.com> Date: Fri, 25 Nov 2022 11:59:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Content-Language: en-US To: Zev Weiss CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "hverkuil-cisco@xs4all.nl" , "zev@bewilderbeest.net" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20221110095611.522-1-jammy_huang@aspeedtech.com> <20221122231216.GF18848@packtop> From: Jammy Huang In-Reply-To: <20221122231216.GF18848@packtop> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2AP3Yqrq036587 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Zev, On 2022/11/23 上午 07:12, Zev Weiss wrote: > On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote: >> If the host is powered off, there will be many warning log. To avoid the >> log spam in this condition, replace v4l2_warn with v4l2_dbg. >> >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> > Thanks Jammy -- after dropping the one hunk that wasn't applicable (due > to not having all the prerequisite patches) this definitely fixed the > log noise problems I'd been having. > > I'm assuming the prerequisite patches are from your aspeed-jpeg support > patch series? If so, since this is a smaller/simpler patch, I think it > might make sense to reorder things to try to get this merged first and > then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(), > rather than introducing a new instance of it and then patching it back > out later with this one. Yes, the prerequisite patches are 'aspeed-jpeg support' patch series. And that patch series has been accepted and pull for v6.2. Your suggestion is better to decouple these patches. I would pay attention to the problem like this to avoid this condition in the future. Many thanks for your kindly help. > > > Thanks, > Zev -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1654C433FE for ; Fri, 25 Nov 2022 04:00:50 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NJLkT0L5vz3f2n for ; Fri, 25 Nov 2022 15:00:49 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=aspeedtech.com (client-ip=211.20.114.71; helo=twspam01.aspeedtech.com; envelope-from=jammy_huang@aspeedtech.com; receiver=) Received: from twspam01.aspeedtech.com (twspam01.aspeedtech.com [211.20.114.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NJLjp4jhGz3c8V; Fri, 25 Nov 2022 15:00:12 +1100 (AEDT) Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2AP3Yqrq036587; Fri, 25 Nov 2022 11:34:52 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Nov 2022 11:59:21 +0800 Message-ID: <0d58e557-3ed9-669a-febb-b4ac714af01e@aspeedtech.com> Date: Fri, 25 Nov 2022 11:59:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Content-Language: en-US To: Zev Weiss References: <20221110095611.522-1-jammy_huang@aspeedtech.com> <20221122231216.GF18848@packtop> From: Jammy Huang In-Reply-To: <20221122231216.GF18848@packtop> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2AP3Yqrq036587 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-aspeed@lists.ozlabs.org" , "zev@bewilderbeest.net" , "andrew@aj.id.au" , "openbmc@lists.ozlabs.org" , "eajames@linux.ibm.com" , "linux-kernel@vger.kernel.org" , "joel@jms.id.au" , "hverkuil-cisco@xs4all.nl" , "mchehab@kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" Hi Zev, On 2022/11/23 上午 07:12, Zev Weiss wrote: > On Thu, Nov 10, 2022 at 01:56:11AM PST, Jammy Huang wrote: >> If the host is powered off, there will be many warning log. To avoid the >> log spam in this condition, replace v4l2_warn with v4l2_dbg. >> >> Signed-off-by: Jammy Huang >> --- >> drivers/media/platform/aspeed/aspeed-video.c | 16 ++++++++-------- >> 1 file changed, 8 insertions(+), 8 deletions(-) >> > Thanks Jammy -- after dropping the one hunk that wasn't applicable (due > to not having all the prerequisite patches) this definitely fixed the > log noise problems I'd been having. > > I'm assuming the prerequisite patches are from your aspeed-jpeg support > patch series? If so, since this is a smaller/simpler patch, I think it > might make sense to reorder things to try to get this merged first and > then fixing up that patchset to use v4l2_dbg() instead of v4l2_warn(), > rather than introducing a new instance of it and then patching it back > out later with this one. Yes, the prerequisite patches are 'aspeed-jpeg support' patch series. And that patch series has been accepted and pull for v6.2. Your suggestion is better to decouple these patches. I would pay attention to the problem like this to avoid this condition in the future. Many thanks for your kindly help. > > > Thanks, > Zev -- Best Regards Jammy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 455BAC4332F for ; Sat, 26 Nov 2022 10:29:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ePHAiFMZv+G76MnnaLfkzanNH1qohRqKYcM5LtSl3JY=; b=G/DMqeXsVLarLY D1mN6iscI8Pc9YYFQ/1ZTA+WTm5plwuZiq7z1G2Oc/BXVNDBAPGtRCzVESqrkUilDiL9lu0IrmXS5 5tkQa32f6vetREIGLY2LnQWZTTsG85QaZokGzGC+K3eYhZkmVIC5Bkt80+0tLiHmi+xXaObgrVk5f zfCrDzAteIsEEiwGfZOzy59FURUEqIvgnEu5z/zkZvuvtC77PC8jC2EpNPQzst6SaZXKzBOgdtyYx yHliOwik+buIwCBC1W4fwdsxhVaaV2ojaVUvGRLCcav6rHNA0mn4L6d70/6//g2Y5Tmf/wqllR7S0 PuVciwUGB4Jj9OXw1rMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oysQH-005VlK-Vw; Sat, 26 Nov 2022 10:28:38 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oysPy-005VcG-4B for linux-arm-kernel@bombadil.infradead.org; Sat, 26 Nov 2022 10:28:18 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=j7Eis1h9LoYbKPL14+oJzZJhOHgkDI7w3zKdK3aa1sw=; b=YrKzIEws3EpR+5CZxTW3xDNkSl KH9cPpnBh1aJsihPvpA8q0aCnr8N3ipzoQNtMxe/VlLAS6K2lMjnYvaRPnfQOLqdRRfp2CQnnO42I tXbs9lHAGc5fSbKcVmTZRd/mTI9cT5boBnPITOB/SZQncQ7fggV9PtcMKIXBlU+m8SIebeA4aUtZ6 4nVnFEdOPblWIaPFJj22a1QPSLJiXZgvd0rr4H0MHYExkI7FMkpbPbZKhLpWK/7Y+g0EbPCc6pd8E JMbjU9ZGY5sMUc+zCbT5XptDIF34057Z9jGX1YRwjTmCNo7/vEENJqAna4JTMAm31+SVcKwlHQhBz 7GRHoOLA==; Received: from twspam01.aspeedtech.com ([211.20.114.71]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyPsi-004PtB-5w for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 04:00:09 +0000 Received: from mail.aspeedtech.com ([192.168.0.24]) by twspam01.aspeedtech.com with ESMTP id 2AP3Yqrq036587; Fri, 25 Nov 2022 11:34:52 +0800 (GMT-8) (envelope-from jammy_huang@aspeedtech.com) Received: from [192.168.2.115] (192.168.2.115) by TWMBX02.aspeed.com (192.168.0.24) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 25 Nov 2022 11:59:21 +0800 Message-ID: <0d58e557-3ed9-669a-febb-b4ac714af01e@aspeedtech.com> Date: Fri, 25 Nov 2022 11:59:22 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] media: aspeed: Use v4l2_dbg to replace v4l2_warn to avoid log spam Content-Language: en-US To: Zev Weiss CC: "eajames@linux.ibm.com" , "mchehab@kernel.org" , "joel@jms.id.au" , "andrew@aj.id.au" , "hverkuil-cisco@xs4all.nl" , "zev@bewilderbeest.net" , "linux-media@vger.kernel.org" , "openbmc@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" References: <20221110095611.522-1-jammy_huang@aspeedtech.com> <20221122231216.GF18848@packtop> From: Jammy Huang In-Reply-To: <20221122231216.GF18848@packtop> X-Originating-IP: [192.168.2.115] X-ClientProxiedBy: TWMBX02.aspeed.com (192.168.0.24) To TWMBX02.aspeed.com (192.168.0.24) X-DNSRBL: X-MAIL: twspam01.aspeedtech.com 2AP3Yqrq036587 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_040007_359206_218F1CB1 X-CRM114-Status: GOOD ( 16.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgWmV2LAoKT24gMjAyMi8xMS8yMyDkuIrljYggMDc6MTIsIFpldiBXZWlzcyB3cm90ZToKPiBP biBUaHUsIE5vdiAxMCwgMjAyMiBhdCAwMTo1NjoxMUFNIFBTVCwgSmFtbXkgSHVhbmcgd3JvdGU6 Cj4+IElmIHRoZSBob3N0IGlzIHBvd2VyZWQgb2ZmLCB0aGVyZSB3aWxsIGJlIG1hbnkgd2Fybmlu ZyBsb2cuIFRvIGF2b2lkIHRoZQo+PiBsb2cgc3BhbSBpbiB0aGlzIGNvbmRpdGlvbiwgcmVwbGFj ZSB2NGwyX3dhcm4gd2l0aCB2NGwyX2RiZy4KPj4KPj4gU2lnbmVkLW9mZi1ieTogSmFtbXkgSHVh bmcgPGphbW15X2h1YW5nQGFzcGVlZHRlY2guY29tPgo+PiAtLS0KPj4gZHJpdmVycy9tZWRpYS9w bGF0Zm9ybS9hc3BlZWQvYXNwZWVkLXZpZGVvLmMgfCAxNiArKysrKysrKy0tLS0tLS0tCj4+IDEg ZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pCj4+Cj4gVGhhbmtz IEphbW15IC0tIGFmdGVyIGRyb3BwaW5nIHRoZSBvbmUgaHVuayB0aGF0IHdhc24ndCBhcHBsaWNh YmxlIChkdWUKPiB0byBub3QgaGF2aW5nIGFsbCB0aGUgcHJlcmVxdWlzaXRlIHBhdGNoZXMpIHRo aXMgZGVmaW5pdGVseSBmaXhlZCB0aGUKPiBsb2cgbm9pc2UgcHJvYmxlbXMgSSdkIGJlZW4gaGF2 aW5nLgo+Cj4gSSdtIGFzc3VtaW5nIHRoZSBwcmVyZXF1aXNpdGUgcGF0Y2hlcyBhcmUgZnJvbSB5 b3VyIGFzcGVlZC1qcGVnIHN1cHBvcnQKPiBwYXRjaCBzZXJpZXM/ICBJZiBzbywgc2luY2UgdGhp cyBpcyBhIHNtYWxsZXIvc2ltcGxlciBwYXRjaCwgSSB0aGluayBpdAo+IG1pZ2h0IG1ha2Ugc2Vu c2UgdG8gcmVvcmRlciB0aGluZ3MgdG8gdHJ5IHRvIGdldCB0aGlzIG1lcmdlZCBmaXJzdCBhbmQK PiB0aGVuIGZpeGluZyB1cCB0aGF0IHBhdGNoc2V0IHRvIHVzZSB2NGwyX2RiZygpIGluc3RlYWQg b2YgdjRsMl93YXJuKCksCj4gcmF0aGVyIHRoYW4gaW50cm9kdWNpbmcgYSBuZXcgaW5zdGFuY2Ug b2YgaXQgYW5kIHRoZW4gcGF0Y2hpbmcgaXQgYmFjawo+IG91dCBsYXRlciB3aXRoIHRoaXMgb25l LgoKWWVzLCB0aGUgcHJlcmVxdWlzaXRlIHBhdGNoZXMgYXJlICdhc3BlZWQtanBlZyBzdXBwb3J0 JyBwYXRjaCBzZXJpZXMuIApBbmQgdGhhdCBwYXRjaCBzZXJpZXMKCmhhcyBiZWVuIGFjY2VwdGVk IGFuZCBwdWxsIGZvciB2Ni4yLiBZb3VyIHN1Z2dlc3Rpb24gaXMgYmV0dGVyIHRvIApkZWNvdXBs ZSB0aGVzZSBwYXRjaGVzLgoKSSB3b3VsZCBwYXkgYXR0ZW50aW9uIHRvIHRoZSBwcm9ibGVtIGxp a2UgdGhpcyB0byBhdm9pZCB0aGlzIGNvbmRpdGlvbiAKaW4gdGhlIGZ1dHVyZS4KCk1hbnkgdGhh bmtzIGZvciB5b3VyIGtpbmRseSBoZWxwLgoKPgo+Cj4gVGhhbmtzLAo+IFpldgoKLS0gCkJlc3Qg UmVnYXJkcwpKYW1teQoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK