From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B37DC2B9F4 for ; Tue, 22 Jun 2021 22:17:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DDD260FF1 for ; Tue, 22 Jun 2021 22:17:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbhFVWTt (ORCPT ); Tue, 22 Jun 2021 18:19:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229675AbhFVWTt (ORCPT ); Tue, 22 Jun 2021 18:19:49 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D8FCC061574 for ; Tue, 22 Jun 2021 15:17:33 -0700 (PDT) Received: from [192.168.0.20] (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C6B67A66; Wed, 23 Jun 2021 00:17:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624400251; bh=EQGAcaXjURCpvn903fkMskzJfYK888/MW1sdDAuRA3o=; h=From:Subject:To:Cc:References:Date:In-Reply-To:From; b=SH0oUBq52oV90VySWUX9s8zZwF2xh4ngU5H3jGomH9GczOl4XuT7wzcOAIxzOaN/+ 7e0zbtNkZ4yX2e28BByEx8kSvLrh7X4uKlSXerSaKJpHyxV8cmjUeFAHQuxM33OJFU 60wE/MtbniaxuP5sNo2VDEbk3N5Cn++55He9y/kU= From: Kieran Bingham Subject: Re: [PATCH v3 4/4] drm: rcar-du: Use drm_bridge_connector_init() helper To: Laurent Pinchart , dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org References: <20210520065046.28978-1-laurent.pinchart+renesas@ideasonboard.com> <20210520065046.28978-5-laurent.pinchart+renesas@ideasonboard.com> Message-ID: <0d59a0d4-2201-210a-fc4e-fd67dd756d88@ideasonboard.com> Date: Tue, 22 Jun 2021 23:17:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210520065046.28978-5-laurent.pinchart+renesas@ideasonboard.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Laurent, On 20/05/2021 07:50, Laurent Pinchart wrote: > Use the drm_bridge_connector_init() helper to create a drm_connector for > each output, instead of relying on the bridge drivers doing so. Attach > the bridges with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to instruct > them not to create a connector. > > Signed-off-by: Laurent Pinchart > Reviewed-by: Jacopo Mondi Aha, this is the one that fixed my issues! Looks good, and tests well ;-) Reviewed-by: Kieran Bingham > --- > Changes since v2: > > - Declare ret variable > --- > drivers/gpu/drm/rcar-du/rcar_du_encoder.c | 26 ++++++++++++++++++----- > 1 file changed, 21 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > index ca3761772211..0daa8bba50f5 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_encoder.c > @@ -11,6 +11,7 @@ > #include > > #include > +#include > #include > #include > #include > @@ -53,7 +54,9 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, > struct device_node *enc_node) > { > struct rcar_du_encoder *renc; > + struct drm_connector *connector; > struct drm_bridge *bridge; > + int ret; > > /* > * Locate the DRM bridge from the DT node. For the DPAD outputs, if the > @@ -103,9 +106,22 @@ int rcar_du_encoder_init(struct rcar_du_device *rcdu, > > renc->output = output; > > - /* > - * Attach the bridge to the encoder. The bridge will create the > - * connector. > - */ > - return drm_bridge_attach(&renc->base, bridge, NULL, 0); > + /* Attach the bridge to the encoder. */ > + ret = drm_bridge_attach(&renc->base, bridge, NULL, > + DRM_BRIDGE_ATTACH_NO_CONNECTOR); > + if (ret) { > + dev_err(rcdu->dev, "failed to attach bridge for output %u\n", > + output); > + return ret; > + } > + > + /* Create the connector for the chain of bridges. */ > + connector = drm_bridge_connector_init(&rcdu->ddev, &renc->base); > + if (IS_ERR(connector)) { > + dev_err(rcdu->dev, > + "failed to created connector for output %u\n", output); > + return PTR_ERR(connector); > + } > + > + return drm_connector_attach_encoder(connector, &renc->base); > } >