All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
To: Riku Voipio <riku.voipio@linaro.org>
Cc: Michal Marek <mmarek@suse.com>,
	linux-kbuild <linux-kbuild@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] builddeb: allow building without headers/firmware packages
Date: Tue, 29 Nov 2016 11:06:49 +1100	[thread overview]
Message-ID: <0d78b326-96de-06dc-1bba-e8c3a88a27ae@au1.ibm.com> (raw)
In-Reply-To: <CAAqcGHm_SRcrWOr+yxTy2oxgxKFwqa6-=ZHvf0M7pNCxoE7q5g@mail.gmail.com>

On 25/11/16 23:24, Riku Voipio wrote:
> I'm not a big fan of this patch. It adds some complexity as evident by
> extra indent
> level it adds. On practice developers would end up passing a long command line
> with all KDEB_NO* variables.

That's fair! I think the approach in your new patch is probably better, 
I'll review that.

-- 
Andrew Donnellan              OzLabs, ADL Canberra
andrew.donnellan@au1.ibm.com  IBM Australia Limited

      reply	other threads:[~2016-11-29  0:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26  8:17 [PATCH 1/2] builddeb: fix typo Andrew Donnellan
2016-08-26  8:17 ` [PATCH 2/2] builddeb: allow building without headers/firmware packages Andrew Donnellan
2016-10-18  2:12   ` Andrew Donnellan
2016-11-25 12:24     ` Riku Voipio
2016-11-29  0:06       ` Andrew Donnellan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d78b326-96de-06dc-1bba-e8c3a88a27ae@au1.ibm.com \
    --to=andrew.donnellan@au1.ibm.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mmarek@suse.com \
    --cc=riku.voipio@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.