From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8D04C4338F for ; Thu, 5 Aug 2021 00:29:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B654E610FC for ; Thu, 5 Aug 2021 00:29:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236150AbhHEAaD (ORCPT ); Wed, 4 Aug 2021 20:30:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:37906 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229991AbhHEAaC (ORCPT ); Wed, 4 Aug 2021 20:30:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE4D7610FD; Thu, 5 Aug 2021 00:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628123388; bh=fKieLesTCiXaeb8urF0Ymy+tmaf0uoqUENpfp0I62go=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Vn5s/oVc4bdLiD2TOHDBnJ22Avzhv08uEdKUm50DR7qHK/EDLsSSNSy39IkNKM/XF KNHE01w6CuBc1oOktxPWGegJMb+8pxk117cVipqwomyhISSjn1ZjM3lLwt0Moe3nC4 ae1wLfe98IFvzSE4/v92+NuWnKEQ83PL9H4EupHvtedjY72NSYBtlRBkpa8mu+kLGw aGSYqPm/KGRvPtNyvPNKF3T7JSz9HdXp5HLocRPutOC+Cc8g6RF2C5SWqk9KkOcdKS 1uPTGhnpsm/YV3DJMSr+Au9nOB17PgrP08CK3oY4//mCOiEJNrxrzEczka7yVKhbsL Ev+48jc/QeSbg== Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent To: Jaegeuk Kim Cc: Chao Yu , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <20210804022348.1414543-1-chao@kernel.org> From: Chao Yu Message-ID: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> Date: Thu, 5 Aug 2021 08:29:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jaegeuk, On 2021/8/5 7:45, Jaegeuk Kim wrote: > Chao, > > How about this? > https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0 Looks more clean, thanks, > > I'm digging one bug in __insert_extent_tree w/ the patch tho. Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise, __try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check w/ uninitialized c_len of @ei. >> On 08/04, Chao Yu wrote: >>> + if (from_dnode) >>> + goto skip_reading_dnode; Wrong condition here, thanks for fixing. Thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DCD03C4338F for ; Thu, 5 Aug 2021 00:30:09 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 91529610FC; Thu, 5 Aug 2021 00:30:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 91529610FC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1mBRGx-00072S-7o; Thu, 05 Aug 2021 00:30:07 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mBRGv-00072D-P9 for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Aug 2021 00:30:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zb9AHjOuco5j8HO3p81lly/TL8E5hqZzd6iGFCCFAfw=; b=fdHgF7tbpgqnMr1LMN0ZCv//m8 VxBFAOz+f/EIXZ5yMgH8qJrjlqYlJul9LWgxWzin5UV8XEFG8nMQTVqs4q9+k4Y7Li6o/ahL1rK8P qN/n3/7jz+O9fRL8N6fF9T3nQKD9bDxn78/8/9sGt9//11teIknvUjzMjK4szFb/S5lU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=zb9AHjOuco5j8HO3p81lly/TL8E5hqZzd6iGFCCFAfw=; b=IR1O9jEnAjZmSlu1O2qJZeCmHu aM/+gAhuOrH9irRVST88dEhpeyra1pMUhzA+dzS9Yvdf/HlLl0yJj+a/oGTx1R93XciO7j7L9Fby7 XuG2ruAe9z6m+o80H2fkB/AarOhE2Lpx52F8JIE/VJKH2sjNcPjl+6a+gldWpKzVFohY=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1mBRGp-0000g2-7L for linux-f2fs-devel@lists.sourceforge.net; Thu, 05 Aug 2021 00:30:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id DE4D7610FD; Thu, 5 Aug 2021 00:29:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1628123388; bh=fKieLesTCiXaeb8urF0Ymy+tmaf0uoqUENpfp0I62go=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Vn5s/oVc4bdLiD2TOHDBnJ22Avzhv08uEdKUm50DR7qHK/EDLsSSNSy39IkNKM/XF KNHE01w6CuBc1oOktxPWGegJMb+8pxk117cVipqwomyhISSjn1ZjM3lLwt0Moe3nC4 ae1wLfe98IFvzSE4/v92+NuWnKEQ83PL9H4EupHvtedjY72NSYBtlRBkpa8mu+kLGw aGSYqPm/KGRvPtNyvPNKF3T7JSz9HdXp5HLocRPutOC+Cc8g6RF2C5SWqk9KkOcdKS 1uPTGhnpsm/YV3DJMSr+Au9nOB17PgrP08CK3oY4//mCOiEJNrxrzEczka7yVKhbsL Ev+48jc/QeSbg== To: Jaegeuk Kim References: <20210804022348.1414543-1-chao@kernel.org> From: Chao Yu Message-ID: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org> Date: Thu, 5 Aug 2021 08:29:46 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Headers-End: 1mBRGp-0000g2-7L Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Jaegeuk, On 2021/8/5 7:45, Jaegeuk Kim wrote: > Chao, > > How about this? > https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0 Looks more clean, thanks, > > I'm digging one bug in __insert_extent_tree w/ the patch tho. Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise, __try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check w/ uninitialized c_len of @ei. >> On 08/04, Chao Yu wrote: >>> + if (from_dnode) >>> + goto skip_reading_dnode; Wrong condition here, thanks for fixing. Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel