From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brijesh Singh Subject: Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device Date: Thu, 2 Mar 2017 13:11:04 -0600 Message-ID: <0db0055f-9208-524f-74aa-674894ee90d3@amd.com> References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> <20170302173936.GC11970@leverpostej> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Cc: linux-efi@vger.kernel.org, brijesh.singh@amd.com, labbott@fedoraproject.org, kvm@vger.kernel.org, rkrcmar@redhat.com, matt@codeblueprint.co.uk, linux-pci@vger.kernel.org, linus.walleij@linaro.org, gary.hook@amd.com, linux-mm@kvack.org, hpa@zytor.com, cl@linux.com, tglx@linutronix.de, aarcange@redhat.com, sfr@canb.auug.org.au, mchehab@kernel.org, simon.guinot@sequanux.org, bhe@redhat.com, xemul@parallels.com, joro@8bytes.org, x86@kernel.org, peterz@infradead.org, piotr.luc@intel.com, mingo@redhat.com, msalter@redhat.com, ross.zwisler@linux.intel.com, bp@suse.de, dyoung@redhat.com, thomas.lendacky@amd.com, jroedel@suse.de, keescook@chromium.org, arnd@arndb.de, toshi.kani@hpe.com, mathieu.desnoyers@efficios.com, luto@kernel.org, pbonzini@redhat.com, bhelgaas@google.com, dan.j.williams@intel.com, andriy.shevchenko@linux.intel.com, akpm@linux-foundation.org, herbert@gondor.ap To: Mark Rutland Return-path: In-Reply-To: <20170302173936.GC11970@leverpostej> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: linux-crypto.vger.kernel.org Hi Mark, On 03/02/2017 11:39 AM, Mark Rutland wrote: > On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: >> The CCP device is part of the AMD Secure Processor. In order to expand the >> usage of the AMD Secure Processor, create a framework that allows functional >> components of the AMD Secure Processor to be initialized and handled >> appropriately. >> >> Signed-off-by: Brijesh Singh >> Signed-off-by: Tom Lendacky >> --- >> drivers/crypto/Kconfig | 10 + >> drivers/crypto/ccp/Kconfig | 43 +++-- >> drivers/crypto/ccp/Makefile | 8 - >> drivers/crypto/ccp/ccp-dev-v3.c | 86 +++++----- >> drivers/crypto/ccp/ccp-dev-v5.c | 73 ++++----- >> drivers/crypto/ccp/ccp-dev.c | 137 +++++++++------- >> drivers/crypto/ccp/ccp-dev.h | 35 ---- >> drivers/crypto/ccp/sp-dev.c | 308 ++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-dev.h | 140 ++++++++++++++++ >> drivers/crypto/ccp/sp-pci.c | 324 ++++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-platform.c | 268 +++++++++++++++++++++++++++++++ >> include/linux/ccp.h | 3 >> 12 files changed, 1240 insertions(+), 195 deletions(-) >> create mode 100644 drivers/crypto/ccp/sp-dev.c >> create mode 100644 drivers/crypto/ccp/sp-dev.h >> create mode 100644 drivers/crypto/ccp/sp-pci.c >> create mode 100644 drivers/crypto/ccp/sp-platform.c > >> diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile >> index 346ceb8..8127e18 100644 >> --- a/drivers/crypto/ccp/Makefile >> +++ b/drivers/crypto/ccp/Makefile >> @@ -1,11 +1,11 @@ >> -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o >> -ccp-objs := ccp-dev.o \ >> +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o >> +ccp-objs := sp-dev.o sp-platform.o >> +ccp-$(CONFIG_PCI) += sp-pci.o >> +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ >> ccp-ops.o \ >> ccp-dev-v3.o \ >> ccp-dev-v5.o \ >> - ccp-platform.o \ >> ccp-dmaengine.o > > It looks like ccp-platform.c has morphed into sp-platform.c (judging by > the compatible string and general shape of the code), and the original > ccp-platform.c is no longer built. > > Shouldn't ccp-platform.c be deleted by this patch? > Good catch. Both ccp-platform.c and ccp-pci.c should have been deleted by this patch. I missed deleting it, will fix in next rev. ~ Brijesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751749AbdCBTrr (ORCPT ); Thu, 2 Mar 2017 14:47:47 -0500 Received: from mail-by2nam01on0059.outbound.protection.outlook.com ([104.47.34.59]:37723 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751744AbdCBTrj (ORCPT ); Thu, 2 Mar 2017 14:47:39 -0500 Authentication-Results: davemloft.net; dkim=none (message not signed) header.d=none;davemloft.net; dmarc=none action=none header.from=amd.com; Subject: Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device To: Mark Rutland References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> <20170302173936.GC11970@leverpostej> CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , From: Brijesh Singh Message-ID: <0db0055f-9208-524f-74aa-674894ee90d3@amd.com> Date: Thu, 2 Mar 2017 13:11:04 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170302173936.GC11970@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR16CA0013.namprd16.prod.outlook.com (10.169.34.23) To MWHPR12MB1613.namprd12.prod.outlook.com (10.172.56.14) X-MS-Office365-Filtering-Correlation-Id: 279be462-1a81-441e-042a-08d4619fe3ba X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:MWHPR12MB1613; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1613;3:YKN7IJIyRkg6UofDph96wBSL1cD6qAzViQ5FvPZUuI2T004ZlqfG/9BJ5Z4o4tL4VthS2FPsmAUZmq0FyJ64smFZyiCjgN5CObHatNSkr4RUwuPTFBMOV9vMD7174fXXqgJ1KqRxPt/ZNKWUFofAjcvCAxo9pWgjBMQTYO/M+11QIiLol8FyX+8Fj7ATv2eGt/0mWEDHMk4VMd3xU9GNZ035GeG9nQBoS8Kpt54o4hGmpkmNz8aA9dhLKsZjbiv+vbxYz71oOFWn33YYeHjyYcxuODSj1mw8g2cWbeX9Yu0=;25:a8k/QZQcU3TSRvYpuXgjxx3/E/zjTquM1AKQ1DrmKslHJ3m4Aj1OdH6NEe+ODr2WNW8zpItA6QiPm7TsnjQy60CrEKff67K1n1PnbodGPETd7E5GUTqGk+w7+QvB/Y5YsTjjFMn1ec0v17UkpcVnZujR30YJLat81dHs9dFqD7Zlz9Rsi3F8XQJCk7mzIEYnhGkgfN65R5RPt+J5ambvhScOCqmuCVTRqKGIPzFg8mNgrcvs0vMrQVc4wgzaZOXJ/x1dWAXtpj6MaVGBabuCXWih3ypUxpVhctHckmdED1qV8CQpvcqy2ybMCjGQ4U2QSZWF4Y6gyax7+SOxYUvY6owt6AeM72IZ4BGOo5ByODaEwR7Knwsm3HT3ekCG27kYO/dU6Jps5PfNZntj6wl9ucW57zkVjDJnXh9vK3n1cYarhUPeF6eQBSpNrKls3K11WkhZxRQsdyn9M/QgjNc82Q== X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1613;31:94SLJee4djuzFm5v31jxq0rNNny9v5iYnpflP6knc+7jmcHPZuzPxPv6Y1SMgn5n04nl0C6EWuiKzmrOhaAxc9emamCQC6sA04hyAi8/kkPCpUQ7IlvkvLsxu+Hdhc2WTNBgkzxsArjjzJDEMwRYCbWo43/zKi178f2vl1Q/QGnjON0NUyCiBhQ3BDvJa8QhpJswDbxGYqYq7rqJ9icSh9mekzvrN7aB6oZJR+5vUqNWYK205eQHaeNtGfbLKRDF;20:KD46Npt8voDuvZzJkGeypZQIWNlv4C9+bYzOec/YVyp0049sXIJ8xxksGNxDgF5XTVPBFimB25IeSamK5lUBMRLboUypjV3L6UBnq5qQCGLD+kjiWCtc2+TmswNsLwePFaQEc2WIZWV3R4AEAnFa4mcgA/iaw07K8deojlgOqagTHQZwTJtCyJTJ2bfgeNT1vHC54tjmbLPjZt3MlMzrcRpP75gCIqbe3xp5fVzqpa3vyAYVFguKW8jBK4yUxFLEAOJ2ZglEbk5de2P20mVAMK/dUVEN++RuriXBIXTIXpkjO7cqF98nhY5gaOFvWKI6A7U9NL0LD7qIoTy2nTsva9/xLCI0ZWnVzuFE9iqx59mh1P2KsloTBPNYJqRQc+l/K1rlxIwtgIwQSMJDw+WCRsgbrtyrIQBeTxOJrNRQAdptaqSoIsxXu6JDqJqWBtzYTZGcz48hP43u16gan3ABAg6n0AeaDx5GZrADxmjXif5zMFpGwj31AjNl/OzhL4jp X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123558025)(20161123564025)(6072148);SRVR:MWHPR12MB1613;BCL:0;PCL:0;RULEID:;SRVR:MWHPR12MB1613; X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1613;4:Xrg4mQgGVe94wN5r96sJEYj3quSY8obISqTVOE+cdCM7u7NaVJaj9lflvUNlgdcrE3HwajxvGMzfxdgc+no3e4XxTf4BolqOdLGyMnBR6RKwv2rIbc3QrCNRHbRbEB5YzRdmCAyYIwQtvlcubVLeLd6nfZve0J9Cvxee2QnaIN0EBVb2fEWalZL85YVR9ZpDIOVenJd2Z5RCsWRXOR2Xj7GGGSg8FW58JC0b7Z4ucJNWgoNlkZSIaIfGSfYzW/GAxiculx4sB74dIaYr1JcgoenfXxyoQtMUOaeoHoO+a+qyltTRMR1hvvYgFrFR+y8YwFYaZCNSQFjgdeUXidkfahsbFj0faegC3gvWDOQnHNzlIF+jkE0WNtOno8Mo3++TS8jKt0wF6gmY9zXML6eARO0dp1qFTsxN3ylCgyl3fQ4UcihFiyU/z8ydD9V5vieymsdGB7UGwWAjcCGGktEIuPcVo0c/kBnmmUKVB2M6IWwVqDsl33o2f1WqDFcWEffC+nxR9Jn0YXkH5HzFRaOnYpZTSh+oxYkoq+8jGx0A01Yp9TAeZmluguBdn8FTJKtOR/DQbddgmEFEdusLcxGFHdfpU9Fj25jXSCRO41sBaHW//VbjQ/xo+wMWk5KWP+W4CIFsPDPqWX+OPdzitOlbhdNEobV7ZyPafOMVYHt7NWI= X-Forefront-PRVS: 023495660C X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(7916002)(39840400002)(39860400002)(39850400002)(39410400002)(39450400003)(24454002)(377454003)(3846002)(54356999)(4326008)(230700001)(42186005)(110136004)(31686004)(76176999)(33646002)(5660300001)(2906002)(2950100002)(50986999)(6666003)(83506001)(6916009)(4001350100001)(6116002)(229853002)(66066001)(38730400002)(6246003)(25786008)(8676002)(65956001)(53936002)(92566002)(90366009)(189998001)(65806001)(6486002)(50466002)(54906002)(77096006)(86362001)(7406005)(31430400001)(7366002)(53546006)(64126003)(23746002)(31696002)(7416002)(36756003)(81166006)(305945005)(7736002)(47776003)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR12MB1613;H:[10.236.136.62];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR12MB1613;23:LMgqYHiCVmzny4UCg8cxaDKxTabyn1PRIoWqF?= =?Windows-1252?Q?VOU9vg06mKUelmlfMTlghw77KH6pkqUehMDP6KduY+CD9xD9LMhKe3A2?= =?Windows-1252?Q?efj8y3Ldm4sqJ4tXeq1bRpsoYtlLq9HNDojb0Nb3SoDWg/iGL759VDI+?= =?Windows-1252?Q?0yKsiMi4XsBSnK8/V8zIu5fz5kdSCwr3QGqBqfJwR14BdW28KnpSUsTX?= =?Windows-1252?Q?++QLg/A/QTJCqM3+3/d+f5YhoKL3A0ZmTGNB6sMM8dmYvLKvTq2CGW/7?= =?Windows-1252?Q?vpojgpM9WMQ8FSS1UIYEF+b6hUP1cuV8RVdvT3QitWz8nMMcjN4z3jtO?= =?Windows-1252?Q?V9BP8qOh/SzPCwsgXRqOa7IW1xGV6Eg5gzc/MRadFubB0QIIXrYLLvzP?= =?Windows-1252?Q?vwI1cqRt6AiFyV0mrsLgvcf9yTqkmCBQ7bbf3zyZsBPIGoV6+PrxNk/u?= =?Windows-1252?Q?nGjH61Gji73qOi99KiItPqXAKJyf6/DgR1WBawn/ywihWIEjOhBnRvGy?= =?Windows-1252?Q?aCDWMaEgpBpz6DYm/hPeResojH1ZBgRZY+uoG1cTVsWzMGn1pNHwiK/k?= =?Windows-1252?Q?qb9OjwOIIeym0YJNiDeyprJP/0ESch1692NH47Fo3Ml5TqUEBa7gEoez?= =?Windows-1252?Q?CaB6Hd17QqP5IAbqhiLPyiEPSbTU2uOIuHmCNCv9YAN2cwjX3NHJMs3O?= =?Windows-1252?Q?7hWp3vrFRqzfpZrfyq2Qblp7iz2E/ceQFmVnMxi85d7jGMptvvccTSOw?= =?Windows-1252?Q?mKqEZmkTMlm3JlefbCTQSa/wqiuY2nCfVKRpMnARqfRgu2Jpz1SElNHC?= =?Windows-1252?Q?1AIZveCJmIaTBuko9iH980R0pA0HhuiXJDCgzEsPkKPeDKCEeg8znEeR?= =?Windows-1252?Q?M+LBg6fERUk6jxMuc6exeArRvSLE07ms3GaedChFaJ7RRI5LTAawGVYd?= =?Windows-1252?Q?GurhuMHriKiXPwfS+aCSfU3hr1kFQLx05syS9IGtliA32DMlQU71vmN8?= =?Windows-1252?Q?lVbaNj2SnVxsyN7rcNWxIUv5AcdTGZsS6cyCFGMr2p5cqAcOZ9Sp5ksk?= =?Windows-1252?Q?gMeP0qWB0PNwfOSGMGjLeLQsdl3brRxFbwLae/UwbfCW21RRkb//zDVC?= =?Windows-1252?Q?PmA1nvLxET1J8kdnJELLqurkqSRSZxpRT7RnzRr9pC+FTjWCySeYDVeP?= =?Windows-1252?Q?OSjM+m1jLsu0xDKXWjtSs4XQcpGX1A8cmS/vwuPqoD1JXvXinePCalfy?= =?Windows-1252?Q?yW2uLnXhcEb/tGyIkOLTuQjEoZ+VENCEtNIhpJmhkhNv9bJ4sW4LJJZ9?= =?Windows-1252?Q?6a71a/z1MPOf3qcbR4qrByMqbyTNxicGxXIlBsDDWkQ7AKkESyzzHVcy?= =?Windows-1252?Q?1WTqlrgoMrqVFjV2XVccm8vRrSmZeuf4il345fNoV6qEXt3CghoOstaC?= =?Windows-1252?Q?gUvyIXqtu6l+SYiuRIn8yRXzN9pyzkwx9IdT29LIKLgXabVyjDQN924s?= =?Windows-1252?Q?kDFQ3+lg77fZHOHkE0LJOQmIBBNL/zZfJplUrZH9GVetqXPWgroqZcCL?= =?Windows-1252?Q?u2EvPGyTo4pvNM=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1613;6:teuIVPB0GZ+L2vcBp3wI7TBZd5SsAUrZg2AMo2s8d/jLkpqAx+YLK4zmQlGH8vBr2ZZm6AQhlRB0HW7pxKWYEW/r/U2IG/IeYkLy8o372JgbBbB+CgK+0Q8GEFvINhWy8yn5NvijWq90S7DeE25xYGYwNOg6PCaPUaeObKVXYn3Q0bqdtniP/P96OnPPb8d6WDG7PZ4JFlnuO6u8v90MdDsODdzc/JCoFeSjvmx0VERvddXtHvbzs37REqHzZaDS/NmH8l5MRyrfbjKBp3O1Zf6E9JU9rkqW16EWfctnSO2SZU4ftAmkeZeHUn0FvyBWtwzjgZoTMTUTLeZlHZL1aCnE5/wV9LZk8Gznyf3weTT3oD/cHvRXiYJtnkW0h8kyGgUnhgTRMVS4wh40N4rWEn+O7F8F1pFOdS+RbhgaqLI=;5:+U2laq96g7rv6Tc74y2WWsG0JH7hv/ME8Oe5gAV/TQzTFvuqZP5In6ZCS6mycXl0zGgOcl1ee8uWHoIUTGwqb9byR8SLGkXm4ojZfHqGtOJbESqAmNNrcqt6LgqEpFEBjPm23gKkeR0UmryI0RZx3g==;24:3iyHpdp7MOhVMzjbshjGzHpmewJQOfEHtSupEi0PXCZncFu3fOE5Gj9H8ht1n2JhHexpluFSo2mHxZpcFmuXDyfCf2hcAQhoa4D3K3Gi4Q0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR12MB1613;7:Qfc67nqQiRTE50lr2YP7oCQ7agStniduRWUl08HVigz4cz/AmCyASDXlXYxO6sRZTbvwMbLipvbpGr+gbV/i7qiyTHruv7qY9jFdZJrsrGrU3hi9S78t3OtNwQwtfsyN9LbGzDmQ26r91a1fS72b7Q66c0dXKkwymS/vjn9G6oClh0vjqqPgkd9w5NwPhqKY4tu1XZvPB26MR+u7zF0csEPd/jmhb76YKvb2wiSOvuIaWmJ5179bmJwuXK6ftv/Vgt6SzTsVYflxoSG94q+sqvnb443b1KRax80km9oI9760iYR5dUFlWxnPrxB41SQWAilbGPPyBD6TlQuZFU9cSQ==;20:b+sz+o4bayjLwQVLorIcgX4mILXoWo3V92183bNLqSDxurfT9sA04DzhX1LuWiABDoATUI0pvPSgp1QkOjILMX6h1jHAgwjpAkSGTEg9Wa7+eDh5r/7ZzfJPmn94guiDoKfc/IFRLvuj+C1q2vg6FrEnmb9UP26rNu7KoauizK1Wd/i9x1CyPg+vav9yVOatFI/dve3ikSlsxl9tHhE6mYOogklufIYuuojjhL/ihTZ7pcz6l2uSCr4ON2TZs9hz X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2017 19:11:07.6270 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1613 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, On 03/02/2017 11:39 AM, Mark Rutland wrote: > On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: >> The CCP device is part of the AMD Secure Processor. In order to expand the >> usage of the AMD Secure Processor, create a framework that allows functional >> components of the AMD Secure Processor to be initialized and handled >> appropriately. >> >> Signed-off-by: Brijesh Singh >> Signed-off-by: Tom Lendacky >> --- >> drivers/crypto/Kconfig | 10 + >> drivers/crypto/ccp/Kconfig | 43 +++-- >> drivers/crypto/ccp/Makefile | 8 - >> drivers/crypto/ccp/ccp-dev-v3.c | 86 +++++----- >> drivers/crypto/ccp/ccp-dev-v5.c | 73 ++++----- >> drivers/crypto/ccp/ccp-dev.c | 137 +++++++++------- >> drivers/crypto/ccp/ccp-dev.h | 35 ---- >> drivers/crypto/ccp/sp-dev.c | 308 ++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-dev.h | 140 ++++++++++++++++ >> drivers/crypto/ccp/sp-pci.c | 324 ++++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-platform.c | 268 +++++++++++++++++++++++++++++++ >> include/linux/ccp.h | 3 >> 12 files changed, 1240 insertions(+), 195 deletions(-) >> create mode 100644 drivers/crypto/ccp/sp-dev.c >> create mode 100644 drivers/crypto/ccp/sp-dev.h >> create mode 100644 drivers/crypto/ccp/sp-pci.c >> create mode 100644 drivers/crypto/ccp/sp-platform.c > >> diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile >> index 346ceb8..8127e18 100644 >> --- a/drivers/crypto/ccp/Makefile >> +++ b/drivers/crypto/ccp/Makefile >> @@ -1,11 +1,11 @@ >> -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o >> -ccp-objs := ccp-dev.o \ >> +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o >> +ccp-objs := sp-dev.o sp-platform.o >> +ccp-$(CONFIG_PCI) += sp-pci.o >> +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ >> ccp-ops.o \ >> ccp-dev-v3.o \ >> ccp-dev-v5.o \ >> - ccp-platform.o \ >> ccp-dmaengine.o > > It looks like ccp-platform.c has morphed into sp-platform.c (judging by > the compatible string and general shape of the code), and the original > ccp-platform.c is no longer built. > > Shouldn't ccp-platform.c be deleted by this patch? > Good catch. Both ccp-platform.c and ccp-pci.c should have been deleted by this patch. I missed deleting it, will fix in next rev. ~ Brijesh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi0-f69.google.com (mail-oi0-f69.google.com [209.85.218.69]) by kanga.kvack.org (Postfix) with ESMTP id 64C8F6B0387 for ; Thu, 2 Mar 2017 14:11:14 -0500 (EST) Received: by mail-oi0-f69.google.com with SMTP id 2so66339169oif.7 for ; Thu, 02 Mar 2017 11:11:14 -0800 (PST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0078.outbound.protection.outlook.com. [104.47.37.78]) by mx.google.com with ESMTPS id a124si3778514oih.67.2017.03.02.11.11.13 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 02 Mar 2017 11:11:13 -0800 (PST) Subject: Re: [RFC PATCH v2 19/32] crypto: ccp: Introduce the AMD Secure Processor device References: <148846752022.2349.13667498174822419498.stgit@brijesh-build-machine> <148846777589.2349.11698765767451886038.stgit@brijesh-build-machine> <20170302173936.GC11970@leverpostej> From: Brijesh Singh Message-ID: <0db0055f-9208-524f-74aa-674894ee90d3@amd.com> Date: Thu, 2 Mar 2017 13:11:04 -0600 MIME-Version: 1.0 In-Reply-To: <20170302173936.GC11970@leverpostej> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Mark Rutland Cc: brijesh.singh@amd.com, simon.guinot@sequanux.org, linux-efi@vger.kernel.org, kvm@vger.kernel.org, rkrcmar@redhat.com, matt@codeblueprint.co.uk, linux-pci@vger.kernel.org, linus.walleij@linaro.org, gary.hook@amd.com, linux-mm@kvack.org, paul.gortmaker@windriver.com, hpa@zytor.com, cl@linux.com, dan.j.williams@intel.com, aarcange@redhat.com, sfr@canb.auug.org.au, andriy.shevchenko@linux.intel.com, herbert@gondor.apana.org.au, bhe@redhat.com, xemul@parallels.com, joro@8bytes.org, x86@kernel.org, peterz@infradead.org, piotr.luc@intel.com, mingo@redhat.com, msalter@redhat.com, ross.zwisler@linux.intel.com, bp@suse.de, dyoung@redhat.com, thomas.lendacky@amd.com, jroedel@suse.de, keescook@chromium.org, arnd@arndb.de, toshi.kani@hpe.com, mathieu.desnoyers@efficios.com, luto@kernel.org, devel@linuxdriverproject.org, bhelgaas@google.com, tglx@linutronix.de, mchehab@kernel.org, iamjoonsoo.kim@lge.com, labbott@fedoraproject.org, tony.luck@intel.com, alexandre.bounine@idt.com, kuleshovmail@gmail.com, linux-kernel@vger.kernel.org, mcgrof@kernel.org, mst@redhat.com, linux-crypto@vger.kernel.org, tj@kernel.org, pbonzini@redhat.com, akpm@linux-foundation.org, davem@davemloft.net Hi Mark, On 03/02/2017 11:39 AM, Mark Rutland wrote: > On Thu, Mar 02, 2017 at 10:16:15AM -0500, Brijesh Singh wrote: >> The CCP device is part of the AMD Secure Processor. In order to expand the >> usage of the AMD Secure Processor, create a framework that allows functional >> components of the AMD Secure Processor to be initialized and handled >> appropriately. >> >> Signed-off-by: Brijesh Singh >> Signed-off-by: Tom Lendacky >> --- >> drivers/crypto/Kconfig | 10 + >> drivers/crypto/ccp/Kconfig | 43 +++-- >> drivers/crypto/ccp/Makefile | 8 - >> drivers/crypto/ccp/ccp-dev-v3.c | 86 +++++----- >> drivers/crypto/ccp/ccp-dev-v5.c | 73 ++++----- >> drivers/crypto/ccp/ccp-dev.c | 137 +++++++++------- >> drivers/crypto/ccp/ccp-dev.h | 35 ---- >> drivers/crypto/ccp/sp-dev.c | 308 ++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-dev.h | 140 ++++++++++++++++ >> drivers/crypto/ccp/sp-pci.c | 324 ++++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/sp-platform.c | 268 +++++++++++++++++++++++++++++++ >> include/linux/ccp.h | 3 >> 12 files changed, 1240 insertions(+), 195 deletions(-) >> create mode 100644 drivers/crypto/ccp/sp-dev.c >> create mode 100644 drivers/crypto/ccp/sp-dev.h >> create mode 100644 drivers/crypto/ccp/sp-pci.c >> create mode 100644 drivers/crypto/ccp/sp-platform.c > >> diff --git a/drivers/crypto/ccp/Makefile b/drivers/crypto/ccp/Makefile >> index 346ceb8..8127e18 100644 >> --- a/drivers/crypto/ccp/Makefile >> +++ b/drivers/crypto/ccp/Makefile >> @@ -1,11 +1,11 @@ >> -obj-$(CONFIG_CRYPTO_DEV_CCP_DD) += ccp.o >> -ccp-objs := ccp-dev.o \ >> +obj-$(CONFIG_CRYPTO_DEV_SP_DD) += ccp.o >> +ccp-objs := sp-dev.o sp-platform.o >> +ccp-$(CONFIG_PCI) += sp-pci.o >> +ccp-$(CONFIG_CRYPTO_DEV_CCP) += ccp-dev.o \ >> ccp-ops.o \ >> ccp-dev-v3.o \ >> ccp-dev-v5.o \ >> - ccp-platform.o \ >> ccp-dmaengine.o > > It looks like ccp-platform.c has morphed into sp-platform.c (judging by > the compatible string and general shape of the code), and the original > ccp-platform.c is no longer built. > > Shouldn't ccp-platform.c be deleted by this patch? > Good catch. Both ccp-platform.c and ccp-pci.c should have been deleted by this patch. I missed deleting it, will fix in next rev. ~ Brijesh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org