From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9871EC433E0 for ; Mon, 29 Jun 2020 20:56:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 77F6F206F1 for ; Mon, 29 Jun 2020 20:56:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YG1iZpSc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389899AbgF2U4m (ORCPT ); Mon, 29 Jun 2020 16:56:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43376 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731278AbgF2TNJ (ORCPT ); Mon, 29 Jun 2020 15:13:09 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00429C030F2E; Mon, 29 Jun 2020 09:45:36 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id f7so14214215wrw.1; Mon, 29 Jun 2020 09:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y9LuaHpAJp7j99mylhwwTrgsG7QR6yXOEQqHPjHK9qA=; b=YG1iZpScR2fnD/Dg0q0W5hkPvmMrLbNo9xlP1cqrwH2mupcSdQTr4LZR+9nZIKBkhS vNxlDaGanRq87QIVN4EIae1EoO1LKEPYH5/TT7VqNi3dm09PLW5A18bwk8y2bP0I19Dp 7amp7MNjaIvmjbUVxgBphis8bQqS+Cgq4t+mDKgU46afrmUTLt1XhOjJSJj9RnUaBGVS ygj++98OzqCSrPQ3NwRlILzhK+xS+zrrGXYuf8xJehhPVJI6DErMknEW/s2CXDG+9jUJ FK73oiZ8EUmGLsRotn44ygJAd1jKxyLIhwh73uooLRa7ZgXTWD0Som4EYsuGKhwxeaUL wFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y9LuaHpAJp7j99mylhwwTrgsG7QR6yXOEQqHPjHK9qA=; b=jvQILgQd4+Bg1f5MIOHkaUezSJ/cEF1Jb1IsWjjj74YDRGEmmKnuz9MCRz0IJpKA3B Nrv/Y24LXxUvQB6vfp+fDPRO56slUNxKh9KwbDfZf7DUJXjadGJZ3IVrcwP4cVOhcd4n mS0kCrLhrbpytwAUd8IMqwpleIehufaFba5nE7RSHBVbqsZ/fg07muBMht9IrRzuv+vW 87ovKFgueySPTAQpGaOwG7hR9iIqN7YvsCms/LTqmMuBngnDgJhA/bQXSjxGt68EG1/3 4PxhzpyUhQy77+2l0UKEvNpH4hcVdR15VeX4rgSFA5jde5mtq+AVE+SbUY4YA9VEHdGI G8cQ== X-Gm-Message-State: AOAM532CkdQ9p1Gb1YN0cQTpvVenWFCJ/1pqAly4fHdYhSKcRu2DnS+u udO4w6rj/7v0k8yOND92aZM= X-Google-Smtp-Source: ABdhPJyO9Vl/0aowtNg2HaFwebZPM9zO5kDm6GzEIHIzbBOeZOCT+P6YXcPb6Z5tEMB0sRox55sZ8g== X-Received: by 2002:adf:e8ce:: with SMTP id k14mr17120164wrn.93.1593449135758; Mon, 29 Jun 2020 09:45:35 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x11sm371016wmc.26.2020.06.29.09.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 09:45:35 -0700 (PDT) Subject: Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle To: Lee Jones , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com References: <20200629124752.1018358-1-lee.jones@linaro.org> <20200629124752.1018358-3-lee.jones@linaro.org> From: Florian Fainelli Message-ID: <0db8ebc7-b75b-a74c-8852-b235daedaf82@gmail.com> Date: Mon, 29 Jun 2020 09:45:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629124752.1018358-3-lee.jones@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/29/2020 5:47 AM, Lee Jones wrote: > 'dc' here is an unsigned long, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you remove it as well, you can add: Reviewed-by: Florian Fainelli -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5BDC433E0 for ; Mon, 29 Jun 2020 16:47:06 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 164982559E for ; Mon, 29 Jun 2020 16:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ArXaM9gO"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YG1iZpSc" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 164982559E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2cxyZaPCKXG8HLiXQX4qg69q+5LajJWk4e93vnjOatQ=; b=ArXaM9gOQFXCg26k9H7TSAwpq 0evwLZnNhs7GtZuwAb+96gaBjXDCdMZs66GgSoHYiFlAdmsV9nKdJTTRa6d8f1MWJf2d+xwpKbyN+ UubKQFw0XVBgcDfZT57yP9UgebxUnt8lI7iDTet8Q1BvXoeYb3g1Mtmvlf4v+mRIjsfouxqIkC7zq wl6zJB6EHQc/EQya58I0yZ+dtoIx8v6I9YrrmLnWx91cAkaw5oG1Fcc6BrAfacMX9euNqcOkPPCyZ qpQYfwPNN8eY1Lh522ki0iUmgqpO6xtHE3KUAeq0nId5IteOukBf9/dG+ZQxzApaaB22g8KR0sI40 h/P1AJ3cw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwuY-0006Tr-P4; Mon, 29 Jun 2020 16:45:38 +0000 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jpwuW-0006Sn-IR for linux-arm-kernel@lists.infradead.org; Mon, 29 Jun 2020 16:45:37 +0000 Received: by mail-wr1-x441.google.com with SMTP id h5so17197457wrc.7 for ; Mon, 29 Jun 2020 09:45:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Y9LuaHpAJp7j99mylhwwTrgsG7QR6yXOEQqHPjHK9qA=; b=YG1iZpScR2fnD/Dg0q0W5hkPvmMrLbNo9xlP1cqrwH2mupcSdQTr4LZR+9nZIKBkhS vNxlDaGanRq87QIVN4EIae1EoO1LKEPYH5/TT7VqNi3dm09PLW5A18bwk8y2bP0I19Dp 7amp7MNjaIvmjbUVxgBphis8bQqS+Cgq4t+mDKgU46afrmUTLt1XhOjJSJj9RnUaBGVS ygj++98OzqCSrPQ3NwRlILzhK+xS+zrrGXYuf8xJehhPVJI6DErMknEW/s2CXDG+9jUJ FK73oiZ8EUmGLsRotn44ygJAd1jKxyLIhwh73uooLRa7ZgXTWD0Som4EYsuGKhwxeaUL wFDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Y9LuaHpAJp7j99mylhwwTrgsG7QR6yXOEQqHPjHK9qA=; b=AmY+esXYeI0YVOPxZ3PVKJFb0SwI7hkMpRGlKD6kecDJPZpOayvyVtUEzhPlY6ZIhw 07MQCWrSW2g84Cc8k/BUIOwlAuf8eG3YiY+PKhW/NXgqVWj2+1FLWoQZRHfT5zZPAFcs IdHooIFKs1vRalwdlTouGz02nC9XXNqFZirXusdK9WJ5y3ZFVFQgAtw5owkRzEL/krOW utoO1aQHTywGNq1i5EouueFSIXmxzD5DFT/s/i5rsq9JLlXnyXjQqHWGGigqqYa6HtjS rPaHLvt67EEKLK9/ODk4B1GECQZCjtNzaroewRIBw2s0NjhzKKpJ/hi1Vnwk3I0mP32n vp9Q== X-Gm-Message-State: AOAM531fq63qkd82ghrOy/6I/2wibbChUVR41oi4InCtEGrSjlIaRD7J 1iwWcB+VwpxCG1mvGFNlIuw= X-Google-Smtp-Source: ABdhPJyO9Vl/0aowtNg2HaFwebZPM9zO5kDm6GzEIHIzbBOeZOCT+P6YXcPb6Z5tEMB0sRox55sZ8g== X-Received: by 2002:adf:e8ce:: with SMTP id k14mr17120164wrn.93.1593449135758; Mon, 29 Jun 2020 09:45:35 -0700 (PDT) Received: from [10.230.30.107] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x11sm371016wmc.26.2020.06.29.09.45.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2020 09:45:35 -0700 (PDT) Subject: Re: [PATCH 2/4] pwm: bcm-kona: Remove impossible comparison when validating duty cycle To: Lee Jones , thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, linux-pwm@vger.kernel.org References: <20200629124752.1018358-1-lee.jones@linaro.org> <20200629124752.1018358-3-lee.jones@linaro.org> From: Florian Fainelli Message-ID: <0db8ebc7-b75b-a74c-8852-b235daedaf82@gmail.com> Date: Mon, 29 Jun 2020 09:45:31 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Firefox/68.0 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200629124752.1018358-3-lee.jones@linaro.org> Content-Language: en-US X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 6/29/2020 5:47 AM, Lee Jones wrote: > 'dc' here is an unsigned long, thus checking for <0 will always > evaluate to false. > > Fixes the following W=1 warning: > > drivers/pwm/pwm-bcm-kona.c:141:35: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] > > Cc: Florian Fainelli > Cc: Ray Jui > Cc: Scott Branden > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-pwm@vger.kernel.org > Signed-off-by: Lee Jones And similar to patch #1, DUTY_CYCLE_HIGH_MIN now gets unused, so if you remove it as well, you can add: Reviewed-by: Florian Fainelli -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel