From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robin Murphy Subject: Re: [PATCH v2 7/8] drm/panfrost: Rework page table flushing and runtime PM interaction Date: Fri, 23 Aug 2019 12:11:58 +0100 Message-ID: <0dc17539-99d0-d0ea-9b24-506f4dafef71@arm.com> References: <20190823021216.5862-1-robh@kernel.org> <20190823021216.5862-8-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id C5C416EC78 for ; Fri, 23 Aug 2019 11:12:02 +0000 (UTC) In-Reply-To: <20190823021216.5862-8-robh@kernel.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rob Herring , dri-devel@lists.freedesktop.org Cc: Maxime Ripard , Tomeu Vizoso , David Airlie , Steven Price , Boris Brezillon , Alyssa Rosenzweig , Sean Paul List-Id: dri-devel@lists.freedesktop.org T24gMjMvMDgvMjAxOSAwMzoxMiwgUm9iIEhlcnJpbmcgd3JvdGU6Cj4gVGhlcmUgaXMgbm8gcG9p bnQgaW4gcmVzdW1pbmcgdGhlIGgvdyBqdXN0IHRvIGRvIGZsdXNoIG9wZXJhdGlvbnMgYW5kCj4g ZG9pbmcgc28gdGFrZXMgc2V2ZXJhbCBsb2NrcyB3aGljaCBjYXVzZSBsb2NrZGVwIGlzc3VlcyB3 aXRoIHRoZSBzaHJpbmtlci4KPiBSZXdvcmsgdGhlIGZsdXNoIG9wZXJhdGlvbnMgdG8gb25seSBo YXBwZW4gd2hlbiB0aGUgaC93IGlzIGFscmVhZHkgYXdha2UuCj4gVGhpcyBhdm9pZHMgdGFraW5n IGFueSBsb2NrcyBhc3NvY2lhdGVkIHdpdGggcmVzdW1pbmcuCj4gCj4gQ2M6IFRvbWV1IFZpem9z byA8dG9tZXUudml6b3NvQGNvbGxhYm9yYS5jb20+Cj4gQ2M6IFN0ZXZlbiBQcmljZSA8c3RldmVu LnByaWNlQGFybS5jb20+Cj4gQ2M6IEFseXNzYSBSb3Nlbnp3ZWlnIDxhbHlzc2Eucm9zZW56d2Vp Z0Bjb2xsYWJvcmEuY29tPgo+IENjOiBEYXZpZCBBaXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4g Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KPiBTaWduZWQtb2ZmLWJ5OiBSb2Ig SGVycmluZyA8cm9iaEBrZXJuZWwub3JnPgo+IC0tLQo+IHYyOiBuZXcgcGF0Y2gKPiAKPiAgIGRy aXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9tbXUuYyB8IDQxICsrKysrKysrKysrKy0t LS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAyMCBpbnNlcnRpb25zKCspLCAyMSBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZy b3N0X21tdS5jIGIvZHJpdmVycy9ncHUvZHJtL3BhbmZyb3N0L3BhbmZyb3N0X21tdS5jCj4gaW5k ZXggODQyYmRkN2NmNmJlLi5jY2Y2NzFhOWMzZmIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL3BhbmZyb3N0L3BhbmZyb3N0X21tdS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL3BhbmZy b3N0L3BhbmZyb3N0X21tdS5jCj4gQEAgLTIyMCw2ICsyMjAsMjMgQEAgc3RhdGljIHNpemVfdCBn ZXRfcGdzaXplKHU2NCBhZGRyLCBzaXplX3Qgc2l6ZSkKPiAgIAlyZXR1cm4gU1pfMk07Cj4gICB9 Cj4gICAKPiArdm9pZCBwYW5mcm9zdF9tbXVfZmx1c2hfcmFuZ2Uoc3RydWN0IHBhbmZyb3N0X2Rl dmljZSAqcGZkZXYsCj4gKwkJCSAgICAgIHN0cnVjdCBwYW5mcm9zdF9tbXUgKm1tdSwKPiArCQkJ ICAgICAgdTY0IGlvdmEsIHNpemVfdCBzaXplKQo+ICt7Cj4gKwlpZiAobW11LT5hcyA8IDApCj4g KwkJcmV0dXJuOwo+ICsKPiArCS8qIEZsdXNoIHRoZSBQVHMgb25seSBpZiB3ZSdyZSBhbHJlYWR5 IGF3YWtlICovCj4gKwlpZiAoIXBtX3J1bnRpbWVfZ2V0X2lmX2luX3VzZShwZmRldi0+ZGV2KSkK PiArCQlyZXR1cm47CgpJcyB0aGUgTU1VIGd1YXJhbnRlZWQgdG8gYmUgcmVzZXQgb24gcmVzdW1l IHN1Y2ggdGhhdCB0aGUgVExCcyB3aWxsIAphbHdheXMgY29tZSB1cCBjbGVhbj8gT3RoZXJ3aXNl IHRoZXJlIGFyZSBwb3RlbnRpYWxseSBjb3JuZXJzIHdoZXJlIApzdGFsZSBlbnRyaWVzIHRoYXQg d2Ugc2tpcCBoZXJlIG1pZ2h0IGhhbmcgYXJvdW5kIGlmIHRoZSBoYXJkd2FyZSBsaWVzIAphYm91 dCBwb3dlcmluZyB0aGluZ3MgZG93bi4KClJvYmluLgoKPiArCj4gKwltbXVfaHdfZG9fb3BlcmF0 aW9uKHBmZGV2LCBtbXUsIGlvdmEsIHNpemUsIEFTX0NPTU1BTkRfRkxVU0hfUFQpOwo+ICsKPiAr CXBtX3J1bnRpbWVfbWFya19sYXN0X2J1c3kocGZkZXYtPmRldik7Cj4gKwlwbV9ydW50aW1lX3B1 dF9hdXRvc3VzcGVuZChwZmRldi0+ZGV2KTsKPiArfQo+ICsKPiAgIHN0YXRpYyBpbnQgbW11X21h cF9zZyhzdHJ1Y3QgcGFuZnJvc3RfZGV2aWNlICpwZmRldiwgc3RydWN0IHBhbmZyb3N0X21tdSAq bW11LAo+ICAgCQkgICAgICB1NjQgaW92YSwgaW50IHByb3QsIHN0cnVjdCBzZ190YWJsZSAqc2d0 KQo+ICAgewo+IEBAIC0yNDYsMTEgKzI2MywxMCBAQCBzdGF0aWMgaW50IG1tdV9tYXBfc2coc3Ry dWN0IHBhbmZyb3N0X2RldmljZSAqcGZkZXYsIHN0cnVjdCBwYW5mcm9zdF9tbXUgKm1tdSwKPiAg IAkJfQo+ICAgCX0KPiAgIAo+IC0JbW11X2h3X2RvX29wZXJhdGlvbihwZmRldiwgbW11LCBzdGFy dF9pb3ZhLCBpb3ZhIC0gc3RhcnRfaW92YSwKPiAtCQkJICAgIEFTX0NPTU1BTkRfRkxVU0hfUFQp Owo+IC0KPiAgIAltdXRleF91bmxvY2soJm1tdS0+bG9jayk7Cj4gICAKPiArCXBhbmZyb3N0X21t dV9mbHVzaF9yYW5nZShwZmRldiwgbW11LCBzdGFydF9pb3ZhLCBpb3ZhIC0gc3RhcnRfaW92YSk7 Cj4gKwo+ICAgCXJldHVybiAwOwo+ICAgfQo+ICAgCj4gQEAgLTI1OSw3ICsyNzUsNiBAQCBpbnQg cGFuZnJvc3RfbW11X21hcChzdHJ1Y3QgcGFuZnJvc3RfZ2VtX29iamVjdCAqYm8pCj4gICAJc3Ry dWN0IGRybV9nZW1fb2JqZWN0ICpvYmogPSAmYm8tPmJhc2UuYmFzZTsKPiAgIAlzdHJ1Y3QgcGFu ZnJvc3RfZGV2aWNlICpwZmRldiA9IHRvX3BhbmZyb3N0X2RldmljZShvYmotPmRldik7Cj4gICAJ c3RydWN0IHNnX3RhYmxlICpzZ3Q7Cj4gLQlpbnQgcmV0Owo+ICAgCWludCBwcm90ID0gSU9NTVVf UkVBRCB8IElPTU1VX1dSSVRFOwo+ICAgCj4gICAJaWYgKFdBUk5fT04oYm8tPmlzX21hcHBlZCkp Cj4gQEAgLTI3MiwxNCArMjg3LDcgQEAgaW50IHBhbmZyb3N0X21tdV9tYXAoc3RydWN0IHBhbmZy b3N0X2dlbV9vYmplY3QgKmJvKQo+ICAgCWlmIChXQVJOX09OKElTX0VSUihzZ3QpKSkKPiAgIAkJ cmV0dXJuIFBUUl9FUlIoc2d0KTsKPiAgIAo+IC0JcmV0ID0gcG1fcnVudGltZV9nZXRfc3luYyhw ZmRldi0+ZGV2KTsKPiAtCWlmIChyZXQgPCAwKQo+IC0JCXJldHVybiByZXQ7Cj4gLQo+ICAgCW1t dV9tYXBfc2cocGZkZXYsIGJvLT5tbXUsIGJvLT5ub2RlLnN0YXJ0IDw8IFBBR0VfU0hJRlQsIHBy b3QsIHNndCk7Cj4gLQo+IC0JcG1fcnVudGltZV9tYXJrX2xhc3RfYnVzeShwZmRldi0+ZGV2KTsK PiAtCXBtX3J1bnRpbWVfcHV0X2F1dG9zdXNwZW5kKHBmZGV2LT5kZXYpOwo+ICAgCWJvLT5pc19t YXBwZWQgPSB0cnVlOwo+ICAgCj4gICAJcmV0dXJuIDA7Cj4gQEAgLTI5MywxNyArMzAxLDEyIEBA IHZvaWQgcGFuZnJvc3RfbW11X3VubWFwKHN0cnVjdCBwYW5mcm9zdF9nZW1fb2JqZWN0ICpibykK PiAgIAl1NjQgaW92YSA9IGJvLT5ub2RlLnN0YXJ0IDw8IFBBR0VfU0hJRlQ7Cj4gICAJc2l6ZV90 IGxlbiA9IGJvLT5ub2RlLnNpemUgPDwgUEFHRV9TSElGVDsKPiAgIAlzaXplX3QgdW5tYXBwZWRf bGVuID0gMDsKPiAtCWludCByZXQ7Cj4gICAKPiAgIAlpZiAoV0FSTl9PTighYm8tPmlzX21hcHBl ZCkpCj4gICAJCXJldHVybjsKPiAgIAo+ICAgCWRldl9kYmcocGZkZXYtPmRldiwgInVubWFwOiBh cz0lZCwgaW92YT0lbGx4LCBsZW49JXp4IiwgYm8tPm1tdS0+YXMsIGlvdmEsIGxlbik7Cj4gICAK PiAtCXJldCA9IHBtX3J1bnRpbWVfZ2V0X3N5bmMocGZkZXYtPmRldik7Cj4gLQlpZiAocmV0IDwg MCkKPiAtCQlyZXR1cm47Cj4gLQo+ICAgCW11dGV4X2xvY2soJmJvLT5tbXUtPmxvY2spOwo+ICAg Cj4gICAJd2hpbGUgKHVubWFwcGVkX2xlbiA8IGxlbikgewo+IEBAIC0zMTgsMTMgKzMyMSw5IEBA IHZvaWQgcGFuZnJvc3RfbW11X3VubWFwKHN0cnVjdCBwYW5mcm9zdF9nZW1fb2JqZWN0ICpibykK PiAgIAkJdW5tYXBwZWRfbGVuICs9IHBnc2l6ZTsKPiAgIAl9Cj4gICAKPiAtCW1tdV9od19kb19v cGVyYXRpb24ocGZkZXYsIGJvLT5tbXUsIGJvLT5ub2RlLnN0YXJ0IDw8IFBBR0VfU0hJRlQsCj4g LQkJCSAgICBiby0+bm9kZS5zaXplIDw8IFBBR0VfU0hJRlQsIEFTX0NPTU1BTkRfRkxVU0hfUFQp Owo+IC0KPiAgIAltdXRleF91bmxvY2soJmJvLT5tbXUtPmxvY2spOwo+ICAgCj4gLQlwbV9ydW50 aW1lX21hcmtfbGFzdF9idXN5KHBmZGV2LT5kZXYpOwo+IC0JcG1fcnVudGltZV9wdXRfYXV0b3N1 c3BlbmQocGZkZXYtPmRldik7Cj4gKwlwYW5mcm9zdF9tbXVfZmx1c2hfcmFuZ2UocGZkZXYsIGJv LT5tbXUsIGJvLT5ub2RlLnN0YXJ0IDw8IFBBR0VfU0hJRlQsIGxlbik7Cj4gICAJYm8tPmlzX21h cHBlZCA9IGZhbHNlOwo+ICAgfQo+ICAgCj4gCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbA==