From: Marc Zyngier <maz@kernel.org>
To: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net>
Cc: linux-arm-kernel@lists.infradead.org,
Thomas Gleixner <tglx@linutronix.de>,
kernel-team@android.com, Stephen Rothwell <sfr@canb.auug.org.au>
Subject: Re: [PATCH] irqchip/wpcm450: Drop COMPILE_TEST
Date: Thu, 08 Apr 2021 11:43:19 +0100 [thread overview]
Message-ID: <0dd30fb16e1b9d9c7fe226cc102f8fac@kernel.org> (raw)
In-Reply-To: <YG7CwB0lMWJGylt7@latitude>
On 2021-04-08 09:45, Jonathan Neuschäfer wrote:
> On Thu, Apr 08, 2021 at 09:00:30AM +0100, Marc Zyngier wrote:
>> This driver is (for now) ARM specific, and currently doesn't
>> build with a variety of architectures (ia64, RISC-V, x86_64
>> at the very least).
>>
>> Drop COMPILE_TEST from Kconfig until it gets sorted out.
>>
>> Cc: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
>> Reported-by: Stephen Rothwell <sfr@canb.auug.org.au>
>> Signed-off-by: Marc Zyngier <maz@kernel.org>
>> ---
>
> Reviewed-by: Jonathan Neuschäfer <j.neuschaefer@gmx.net>
Thanks for that.
>
>> drivers/irqchip/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
>> index 38ad9dcf42c3..715eb4366e35 100644
>> --- a/drivers/irqchip/Kconfig
>> +++ b/drivers/irqchip/Kconfig
>> @@ -579,7 +579,7 @@ config MST_IRQ
>>
>> config WPCM450_AIC
>> bool "Nuvoton WPCM450 Advanced Interrupt Controller"
>> - depends on ARCH_WPCM450 || COMPILE_TEST
>> + depends on ARCH_WPCM450
>
> I guess I could use (COMPILE_TEST && ARM) or something…
One of the major interest of COMPILE_TEST to be able to check code
cross-architecture. For code that cannot compile cross-architecture,
I'm not sure it matters much.
We can achieve the same result by enabling multi-platform builds (and
this system should probably end-up in multi_v5_defconfig).
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-08 10:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 8:00 [PATCH] irqchip/wpcm450: Drop COMPILE_TEST Marc Zyngier
2021-04-08 8:45 ` Jonathan Neuschäfer
2021-04-08 10:43 ` Marc Zyngier [this message]
2021-04-08 11:51 ` Jonathan Neuschäfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0dd30fb16e1b9d9c7fe226cc102f8fac@kernel.org \
--to=maz@kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.